Re: Failure in contrib test _int on loach

2019-05-14 Thread Heikki Linnakangas
On 08/05/2019 01:31, Heikki Linnakangas wrote: On 02/05/2019 10:37, Heikki Linnakangas wrote: On 29/04/2019 16:16, Anastasia Lubennikova wrote: In previous emails, I have sent two patches with test and bugfix (see attached). After Heikki shared his concerns, I've rechecked the algorithm and hav

Re: Failure in contrib test _int on loach

2019-05-07 Thread Heikki Linnakangas
On 02/05/2019 10:37, Heikki Linnakangas wrote: (resending, previous attempt didn't make it to pgsql-hackers) On 29/04/2019 16:16, Anastasia Lubennikova wrote: In previous emails, I have sent two patches with test and bugfix (see attached). After Heikki shared his concerns, I've rechecked the al

Re: Failure in contrib test _int on loach

2019-05-02 Thread Heikki Linnakangas
(resending, previous attempt didn't make it to pgsql-hackers) On 29/04/2019 16:16, Anastasia Lubennikova wrote: In previous emails, I have sent two patches with test and bugfix (see attached). After Heikki shared his concerns, I've rechecked the algorithm and haven't found any potential error. S

Re: Failure in contrib test _int on loach

2019-04-30 Thread Teodor Sigaev
Hi! So, if other hackers are agreed with my reasoning, the suggested fix is sufficient and can be committed. Patch looks right, but I think that comment should be improved in follow piece: if (stack->blkno != GIST_ROOT_BLKNO && - stack->parent->lsn < GistPageGetNSN(stack->

Re: Failure in contrib test _int on loach

2019-04-29 Thread Anastasia Lubennikova
27.04.2019 22:05, Tom Lane wrote: Anastasia Lubennikova writes: So it is possible, but it doesn't require any extra algorithm changes. I didn't manage to generate dataset to reproduce grandparent split. Though, I do agree that it's worth checking out. Do you have any ideas? Ping? This thread

Re: Failure in contrib test _int on loach

2019-04-27 Thread Tom Lane
Anastasia Lubennikova writes: > So it is possible, but it doesn't require any extra algorithm changes. > I didn't manage to generate dataset to reproduce grandparent split. > Though, I do agree that it's worth checking out. Do you have any ideas? Ping? This thread has gone cold, but the bug is s

Re: Failure in contrib test _int on loach

2019-04-11 Thread Anastasia Lubennikova
10.04.2019 18:25, Heikki Linnakangas writes: On 09/04/2019 19:11, Anastasia Lubennikova wrote: 05.04.2019 19:41, Anastasia Lubennikova writes: In attachment, you can find patch with a test that allows to reproduce the bug not randomly, but on every run. Now I'm trying to find a way to fix the i

Re: Failure in contrib test _int on loach

2019-04-11 Thread Andrey Lepikhov
On 11/04/2019 13:14, Heikki Linnakangas wrote: On 11/04/2019 09:10, Andrey Lepikhov wrote: On 10/04/2019 20:25, Heikki Linnakangas wrote: On 09/04/2019 19:11, Anastasia Lubennikova wrote: After introducing GistBuildNSN this code path became unreachable. To fix it, I added new flag to detect

Re: Failure in contrib test _int on loach

2019-04-11 Thread Heikki Linnakangas
On 11/04/2019 09:10, Andrey Lepikhov wrote: On 10/04/2019 20:25, Heikki Linnakangas wrote: On 09/04/2019 19:11, Anastasia Lubennikova wrote: After introducing GistBuildNSN this code path became unreachable. To fix it, I added new flag to detect such splits during indexbuild. Isn't it possible

Re: Failure in contrib test _int on loach

2019-04-10 Thread Andrey Lepikhov
On 10/04/2019 20:25, Heikki Linnakangas wrote: On 09/04/2019 19:11, Anastasia Lubennikova wrote: 05.04.2019 19:41, Anastasia Lubennikova writes: In attachment, you can find patch with a test that allows to reproduce the bug not randomly, but on every run. Now I'm trying to find a way to fix t

Re: Failure in contrib test _int on loach

2019-04-10 Thread Heikki Linnakangas
On 09/04/2019 19:11, Anastasia Lubennikova wrote: 05.04.2019 19:41, Anastasia Lubennikova writes: In attachment, you can find patch with a test that allows to reproduce the bug not randomly, but on every run. Now I'm trying to find a way to fix the issue. The problem was caused by incorrect de

Re: Failure in contrib test _int on loach

2019-04-09 Thread Anastasia Lubennikova
05.04.2019 19:41, Anastasia Lubennikova writes: 05.04.2019 18:01, Tom Lane writes: Andrew Dunstan writes: On Fri, Apr 5, 2019 at 2:02 AM Thomas Munro wrote: This is a strange failure: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=loach&dt=2019-04-05%2005%3A15%3A00 [ wrong answe

Re: Failure in contrib test _int on loach

2019-04-05 Thread Anastasia Lubennikova
05.04.2019 18:01, Tom Lane writes: Andrew Dunstan writes: On Fri, Apr 5, 2019 at 2:02 AM Thomas Munro wrote: This is a strange failure: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=loach&dt=2019-04-05%2005%3A15%3A00 [ wrong answers from queries using a GIST index ] There are a co

Re: Failure in contrib test _int on loach

2019-04-05 Thread Tom Lane
Andrew Dunstan writes: > On Fri, Apr 5, 2019 at 2:02 AM Thomas Munro wrote: >> This is a strange failure: >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=loach&dt=2019-04-05%2005%3A15%3A00 >> [ wrong answers from queries using a GIST index ] > There are a couple of other recent instan

Re: Failure in contrib test _int on loach

2019-04-05 Thread Andrew Dunstan
On Fri, Apr 5, 2019 at 2:02 AM Thomas Munro wrote: > > Hi, > > This is a strange failure: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=loach&dt=2019-04-05%2005%3A15%3A00 > > test _int ... FAILED 649 ms > > = pgsql.build/contrib/intarray/r

Failure in contrib test _int on loach

2019-04-04 Thread Thomas Munro
Hi, This is a strange failure: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=loach&dt=2019-04-05%2005%3A15%3A00 test _int ... FAILED 649 ms = pgsql.build/contrib/intarray/regression.diffs === diff -U3 /usr/home/pgbf/buildro