Re:Re: Feature: Add reloption support for table access method

2023-05-10 Thread 吴昊
> > The rest of this mail is to talk about the first issue. It looks reasonable > > to add a similar callback in > > struct TableAmRoutine, and parse reloptions by the callback. This patch is > > in the attachment file. > > Why did you add relkind to the callbacks? The callbacks are specific to a

Re: Feature: Add reloption support for table access method

2023-05-10 Thread Jelte Fennema
I'm definitely in favor of this general idea of supporting custom rel options, we could use that for Citus its columnar TableAM. There have been at least two other discussions on this topic: 1. https://www.postgresql.org/message-id/flat/CAFF0-CG4KZHdtYHMsonWiXNzj16gWZpduXAn8yF7pDDub%2BGQMg%40mail.

Re: Feature: Add reloption support for table access method

2023-05-09 Thread Andres Freund
Hi, On 2023-05-05 16:44:39 +0800, 吴昊 wrote: > When I wrote an extension to implement a new storage by table access method. > I found some issues > that the existing code has strong assumptions for heap tables now. Here are 3 > issues that I currently have: > > > 1. Index access method has a ca

Feature: Add reloption support for table access method

2023-05-05 Thread 吴昊
Hi pg-hackers, When I wrote an extension to implement a new storage by table access method. I found some issues that the existing code has strong assumptions for heap tables now. Here are 3 issues that I currently have: 1. Index access method has a callback to handle reloptions, but table acc