Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)

2018-06-27 Thread Amit Kapila
On Tue, Jun 26, 2018 at 7:11 PM, Alvaro Herrera wrote: > On 2018-Jun-26, Amit Kapila wrote: > >> Andrew, Alvaro, do you think we can go ahead with above naming >> suggestions or do we want to brainstorm more on it? > > Looks good to me in a quick skim. > Thanks, pushed! -- With Regards, Amit Ka

Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)

2018-06-26 Thread Alvaro Herrera
On 2018-Jun-26, Amit Kapila wrote: > Andrew, Alvaro, do you think we can go ahead with above naming > suggestions or do we want to brainstorm more on it? Looks good to me in a quick skim. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote

Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)

2018-06-25 Thread Amit Kapila
On Fri, Jun 15, 2018 at 9:46 AM, Amit Kapila wrote: > On Fri, Jun 15, 2018 at 12:54 AM, Andrew Dunstan > wrote: >> >> On 06/14/2018 02:01 PM, Alvaro Herrera wrote: >>> >>> We used to use prefixes for common struct members names to help >>> disambiguate across members that would otherwise have ide

Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)

2018-06-14 Thread Amit Kapila
On Fri, Jun 15, 2018 at 12:54 AM, Andrew Dunstan wrote: > > On 06/14/2018 02:01 PM, Alvaro Herrera wrote: >> >> On 2018-Jun-14, Amit Kapila wrote: >> >>> On Sun, Jun 3, 2018 at 5:08 AM, Amit Kapila >>> wrote: 2. +/* + * Structure used to represent value to be used when the att

Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)

2018-06-14 Thread Andrew Dunstan
Somehow I missed this thread ... On 06/14/2018 02:01 PM, Alvaro Herrera wrote: On 2018-Jun-14, Amit Kapila wrote: On Sun, Jun 3, 2018 at 5:08 AM, Amit Kapila wrote: 2. +/* + * Structure used to represent value to be used when the attribute is not + * present at all in a tuple, i.e. when

Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)

2018-06-14 Thread Alvaro Herrera
On 2018-Jun-14, Amit Kapila wrote: > On Sun, Jun 3, 2018 at 5:08 AM, Amit Kapila wrote: > > 2. > > +/* > > + * Structure used to represent value to be used when the attribute is not > > + * present at all in a tuple, i.e. when the column was created after the > > tuple > > + */ > > + > > +typede

Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)

2018-06-14 Thread Amit Kapila
On Sun, Jun 3, 2018 at 5:08 AM, Amit Kapila wrote: > Some assorted comments: > > 2. > +/* > + * Structure used to represent value to be used when the attribute is not > + * present at all in a tuple, i.e. when the column was created after the > tuple > + */ > + > +typedef struct attrMissing > +{ >

Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)

2018-06-02 Thread Amit Kapila
Some assorted comments: 1. -When a column is added with ADD COLUMN, all existing -rows in the table are initialized with the column's default value -(NULL if no DEFAULT clause is specified). -If there is no DEFAULT clause, this is merely a metadata -change and does not require