Re: Finding database for pg_upgrade missing library

2018-07-28 Thread Bruce Momjian
On Tue, Jul 24, 2018 at 10:33:48AM +0200, Daniel Gustafsson wrote: > > Looking at the code, we do a qsort(), then detect (since they are all > > now adjacent) and remove the duplicate references to the library. What > > I think should be done is to move the duplicate detection down to the > > plac

Re: Finding database for pg_upgrade missing library

2018-07-24 Thread Daniel Gustafsson
> On 16 Jul 2018, at 14:13, Bruce Momjian wrote: > > On Sat, Jul 14, 2018 at 12:14:51AM +0200, Daniel Gustafsson wrote: >>> On 13 Jul 2018, at 18:28, Bruce Momjian wrote: >>> >>> I received a private pg_upgrade feature request to report the database >>> name for missing loadable libraries. Cur

Re: Finding database for pg_upgrade missing library

2018-07-16 Thread Bruce Momjian
On Fri, Jul 13, 2018 at 10:15:34PM -0500, Justin T Pryzby wrote: > On Fri, Jul 13, 2018 at 12:28:15PM -0400, Bruce Momjian wrote: > > I received a private pg_upgrade feature request to report the database > > name for missing loadable libraries. Currently we report "could not > > load library" and

Re: Finding database for pg_upgrade missing library

2018-07-16 Thread Bruce Momjian
On Sat, Jul 14, 2018 at 12:14:51AM +0200, Daniel Gustafsson wrote: > > On 13 Jul 2018, at 18:28, Bruce Momjian wrote: > > > > I received a private pg_upgrade feature request to report the database > > name for missing loadable libraries. Currently we report "could not > > load library" and the l

Re: Finding database for pg_upgrade missing library

2018-07-13 Thread Justin T Pryzby
On Fri, Jul 13, 2018 at 12:28:15PM -0400, Bruce Momjian wrote: > I received a private pg_upgrade feature request to report the database > name for missing loadable libraries. Currently we report "could not > load library" and the library file name, e.g. $libdir/pgpool-regclass. > > The request is

Re: Finding database for pg_upgrade missing library

2018-07-13 Thread Daniel Gustafsson
> On 13 Jul 2018, at 18:28, Bruce Momjian wrote: > > I received a private pg_upgrade feature request to report the database > name for missing loadable libraries. Currently we report "could not > load library" and the library file name, e.g. $libdir/pgpool-regclass. > > The request is that we r

Finding database for pg_upgrade missing library

2018-07-13 Thread Bruce Momjian
I received a private pg_upgrade feature request to report the database name for missing loadable libraries. Currently we report "could not load library" and the library file name, e.g. $libdir/pgpool-regclass. The request is that we report the _database_ name that contained the loadable library r