Re: Fix PGresult leak in pg_dump during binary upgrade

2024-05-15 Thread Daniel Gustafsson
> On 15 May 2024, at 20:46, Tom Lane wrote: > > Daniel Gustafsson writes: >> While looking at pg_dump performance today I noticed that pg_dump fails to >> clear query results in binary_upgrade_set_pg_class_oids during binary upgrade >> mode. 9a974cbcba00 moved the query to the outer block, but

Re: Fix PGresult leak in pg_dump during binary upgrade

2024-05-15 Thread Tom Lane
Daniel Gustafsson writes: > While looking at pg_dump performance today I noticed that pg_dump fails to > clear query results in binary_upgrade_set_pg_class_oids during binary upgrade > mode. 9a974cbcba00 moved the query to the outer block, but left the PQclear > and query buffer destruction in

Fix PGresult leak in pg_dump during binary upgrade

2024-05-15 Thread Daniel Gustafsson
While looking at pg_dump performance today I noticed that pg_dump fails to clear query results in binary_upgrade_set_pg_class_oids during binary upgrade mode. 9a974cbcba00 moved the query to the outer block, but left the PQclear and query buffer destruction in the is_index conditional, making it