Re: Fix a race condition in ConditionVariableTimedSleep()

2025-05-05 Thread Yura Sokolov
05.05.2025 17:05, Bertrand Drouvot пишет: > Hi, > > On Mon, May 05, 2025 at 02:15:15PM +0300, Yura Sokolov wrote: >> Interestingly, our colleague stepped into same problem recently [1] . It >> happened because he attempted to make overcomplex timeout (SIGALARM) handler. >> >> But his solution was

Re: Fix a race condition in ConditionVariableTimedSleep()

2025-05-05 Thread Bertrand Drouvot
Hi, On Mon, May 05, 2025 at 02:15:15PM +0300, Yura Sokolov wrote: > Interestingly, our colleague stepped into same problem recently [1] . It > happened because he attempted to make overcomplex timeout (SIGALARM) handler. > > But his solution was a bit different [2]. > > [1] https://postgr.es/m/0

Re: Fix a race condition in ConditionVariableTimedSleep()

2025-05-05 Thread Bertrand Drouvot
Hi, On Mon, May 05, 2025 at 12:15:39PM +0300, Nazir Bilal Yavuz wrote: > Hi, > > Thanks for the report and the patch! > > On Mon, 5 May 2025 at 10:53, Bertrand Drouvot > wrote: > > > > The proposed fix attached is done in ConditionVariableTimedSleep() as this > > is the > > place that introduc

Re: Fix a race condition in ConditionVariableTimedSleep()

2025-05-05 Thread Yura Sokolov
05.05.2025 10:52, Bertrand Drouvot пишет: > Hi hackers, > > While working on wait event related stuff I observed a failed assertion: > > " > TRAP: failed Assert("node->next == 0 && node->prev == 0"), File: > "../../../../src/include/storage/proclist.h", Line: 91 > " > > during pg_regress/databa

Re: Fix a race condition in ConditionVariableTimedSleep()

2025-05-05 Thread Nazir Bilal Yavuz
Hi, Thanks for the report and the patch! On Mon, 5 May 2025 at 10:53, Bertrand Drouvot wrote: > > The proposed fix attached is done in ConditionVariableTimedSleep() as this is > the > place that introduces the race condition. It re-assigns cv_sleep_target to cv > and then ensures that cv_sleep_

Fix a race condition in ConditionVariableTimedSleep()

2025-05-05 Thread Bertrand Drouvot
>From 7823cfe0328883cec4179d5b024bbeb99c270f75 Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot Date: Mon, 5 May 2025 06:57:29 + Subject: [PATCH v1] Fix a race condition in ConditionVariableTimedSleep() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit