Re: Fix a typo in pg_rotate_logfile

2024-03-04 Thread Daniel Gustafsson
> On 14 Feb 2024, at 21:48, Daniel Gustafsson wrote: >> On 14 Feb 2024, at 19:51, Nathan Bossart wrote: >> On Wed, Feb 14, 2024 at 10:04:49AM -0500, Tom Lane wrote: >>> Daniel Gustafsson writes: Attached is a diff to show what it would look like to remove adminpack (catalog vers

Re: Fix a typo in pg_rotate_logfile

2024-02-15 Thread Bharath Rupireddy
On Thu, Feb 15, 2024 at 2:18 AM Daniel Gustafsson wrote: > > >>> Searching on Github and Debian Codesearch I cannot find any reference to > >>> anyone > >>> using any function from adminpack. With pgAdminIII being EOL it might be > >>> to > >>> remove it now rather than be on the hook to mainta

Re: Fix a typo in pg_rotate_logfile

2024-02-14 Thread Daniel Gustafsson
> On 14 Feb 2024, at 19:51, Nathan Bossart wrote: > > On Wed, Feb 14, 2024 at 10:04:49AM -0500, Tom Lane wrote: >> Daniel Gustafsson writes: >>> On 14 Feb 2024, at 11:35, Dave Page wrote: That said, pgAdmin III has been out of support for many years, and as far as I know, it (and simi

Re: Fix a typo in pg_rotate_logfile

2024-02-14 Thread Nathan Bossart
On Wed, Feb 14, 2024 at 10:04:49AM -0500, Tom Lane wrote: > Daniel Gustafsson writes: >> On 14 Feb 2024, at 11:35, Dave Page wrote: >>> That said, pgAdmin III has been out of support for many years, and as >>> far as I know, it (and similarly old versions of EDB's PEM which was >>> based on it) w

Re: Fix a typo in pg_rotate_logfile

2024-02-14 Thread Tom Lane
Daniel Gustafsson writes: > On 14 Feb 2024, at 11:35, Dave Page wrote: >> That said, pgAdmin III has been out of support for many years, and as far as >> I know, it (and similarly old versions of EDB's PEM which was based on it) >> were the only consumers of adminpack. I would not be sad to see

Re: Fix a typo in pg_rotate_logfile

2024-02-14 Thread Daniel Gustafsson
> On 14 Feb 2024, at 11:35, Dave Page wrote: > That said, pgAdmin III has been out of support for many years, and as far as > I know, it (and similarly old versions of EDB's PEM which was based on it) > were the only consumers of adminpack. I would not be sad to see it removed > entirely Sear

Re: Fix a typo in pg_rotate_logfile

2024-02-14 Thread Dave Page
Hi On Mon, 12 Feb 2024 at 21:31, Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Tue, Feb 13, 2024 at 2:29 AM Daniel Gustafsson wrote: > > > > On that note though, we might want to consider just dropping it > altogether in > > v17 (while fixing the incorrect hint in backb

Re: Fix a typo in pg_rotate_logfile

2024-02-12 Thread Bharath Rupireddy
On Tue, Feb 13, 2024 at 2:29 AM Daniel Gustafsson wrote: > > On that note though, we might want to consider just dropping it altogether in > v17 (while fixing the incorrect hint in backbranches)? I can't imagine > adminpack 1.0 being in heavy use today, and skimming pgAdmin code it seems > it's

Re: Fix a typo in pg_rotate_logfile

2024-02-12 Thread Daniel Gustafsson
> On 12 Feb 2024, at 21:46, Nathan Bossart wrote: > > On Mon, Feb 12, 2024 at 09:39:06PM +0100, Daniel Gustafsson wrote: >>> On 12 Feb 2024, at 21:32, Bharath Rupireddy >>> wrote: >>> I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c >>> - the hint message wrongly mentions t

Re: Fix a typo in pg_rotate_logfile

2024-02-12 Thread Nathan Bossart
On Mon, Feb 12, 2024 at 09:39:06PM +0100, Daniel Gustafsson wrote: >> On 12 Feb 2024, at 21:32, Bharath Rupireddy >> wrote: >> I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c >> - the hint message wrongly mentions that pg_logfile_rotate is part of >> the core; which is actua

Re: Fix a typo in pg_rotate_logfile

2024-02-12 Thread Daniel Gustafsson
> On 12 Feb 2024, at 21:32, Bharath Rupireddy > wrote: > I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c > - the hint message wrongly mentions that pg_logfile_rotate is part of > the core; which is actually not. pg_logfile_rotate is an adminpack's > 1.0 SQL function dropped

Fix a typo in pg_rotate_logfile

2024-02-12 Thread Bharath Rupireddy
4 13:30:31 + Subject: [PATCH v1] Fix a typo in pg_rotate_logfile --- src/backend/storage/ipc/signalfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/storage/ipc/signalfuncs.c b/src/backend/storage/ipc/signalfuncs.c index 81d1a59659..c05a2af48b 100644