On 06/08/2024 18:16, Tom Lane wrote:
Heikki Linnakangas writes:
Hmm, ok I see. Then I propose:
1. Revert
2. Just fix the comment to say int64 instead of uint64.
Yeah, it's probably reasonable to specify the output as int64
not uint64 (especially since it looks like that's what the
macros a
Heikki Linnakangas writes:
> Hmm, ok I see. Then I propose:
> 1. Revert
> 2. Just fix the comment to say int64 instead of uint64.
Yeah, it's probably reasonable to specify the output as int64
not uint64 (especially since it looks like that's what the
macros actually produce).
Hi,
On Tue, Aug 06, 2024 at 05:49:32PM +0300, Heikki Linnakangas wrote:
> On 06/08/2024 17:20, Tom Lane wrote:
> > Heikki Linnakangas writes:
> > > On 06/08/2024 11:54, Bertrand Drouvot wrote:
> > > > Please find attached a tiny patch to correct those and, in passing,
> > > > remove what
> > > >
From 47a209a1840c9f66b584fb03a99baf56c5abe69f Mon Sep 17 00:00:00 2001
From: Heikki Linnakangas
Date: Tue, 6 Aug 2024 17:46:58 +0300
Subject: [PATCH 1/2] Revert "Fix comments in instr_time.h and remove an
unneeded cast to int64"
This reverts commit 3dcb09de7b. Tom Lane pointed out that it broke the
abstraction provide
Heikki Linnakangas writes:
> On 06/08/2024 11:54, Bertrand Drouvot wrote:
>> Please find attached a tiny patch to correct those and, in passing, remove
>> what
>> I think is an unneeded cast to int64.
> Applied, thanks!
I think this comment change is a dis-improvement. It's removed the
documen
On 06/08/2024 11:54, Bertrand Drouvot wrote:
Hi hackers,
While working on [1], I came across what seems to be incorrect comments in
instr_time.h and an unneeded cast to int64.
Indeed, 03023a2664 represented time as an int64 on all platforms but forgot to
update the comment related to INSTR_TIME
Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
>From 1d1f8089a9eba4e87af66d7c0f23f30d52dc042c Mon Sep 17 00:00:00 2001
From: Bertrand Drouvot
Date: Tue, 6 Aug 2024 08:04:43 +
Subject: [PATCH v1] Fix comments in instr_time.h and remove an unneeded cast
to in
