Re: Fix for pg_stat_activity putting client hostaddr into appname field

2018-04-11 Thread Michael Paquier
On Thu, Apr 12, 2018 at 12:01:29AM +0300, Heikki Linnakangas wrote: > Thanks for the debugging and the patch, Edmund! Thanks for the commit, Heikki. -- Michael signature.asc Description: PGP signature

Re: Fix for pg_stat_activity putting client hostaddr into appname field

2018-04-11 Thread Heikki Linnakangas
On 29/03/18 10:46, Michael Paquier wrote: On Tue, Mar 27, 2018 at 03:47:07PM +1300, Edmund Horner wrote: I considered whether aux processes really need those strings (especially st_clienthostname), but decided it was more consistent just to assume that they might. (It's an extra 3 kB... if we w

Re: Fix for pg_stat_activity putting client hostaddr into appname field

2018-04-05 Thread Michael Paquier
On Fri, Apr 06, 2018 at 10:46:27AM +1200, Edmund Horner wrote: > Thanks for making a note of it, Michael. I guess it should be > considered for the next patch release of v10 too? The issue is tracked on the wiki, so at least we are sure that we won't lose sight of it :) After that, the timing a

Re: Fix for pg_stat_activity putting client hostaddr into appname field

2018-04-05 Thread Edmund Horner
On 29 March 2018 at 20:46, Michael Paquier wrote: > On Tue, Mar 27, 2018 at 03:47:07PM +1300, Edmund Horner wrote: >> But the stats array includes auxiliary processes, which means it has >> NumBackendStatSlots items. The pointers for the aux process strings >> are out of range. In the case of my

Re: Fix for pg_stat_activity putting client hostaddr into appname field

2018-03-29 Thread Michael Paquier
On Tue, Mar 27, 2018 at 03:47:07PM +1300, Edmund Horner wrote: > But the stats array includes auxiliary processes, which means it has > NumBackendStatSlots items. The pointers for the aux process strings > are out of range. In the case of my query, the pointers for > st_appname in the aux process

Re: Fix for pg_stat_activity putting client hostaddr into appname field

2018-03-28 Thread Edmund Horner
I sent the original in haste, and now I need to make some corrections... sigh. > Subject: Fix for pg_stat_activity putting client hostaddr into appname field Actually, it's the hostname appears in the appname field. > I noticed when querying pg_stat_activity (in 10.1): 10.1 was wh

Fix for pg_stat_activity putting client hostaddr into appname field

2018-03-26 Thread Edmund Horner
I noticed when querying pg_stat_activity (in 10.1): $ SELECT pid, application_name, client_hostname, backend_type FROM pg_stat_activity; pid | application_name |client_hostname| backend_type ---+--+---+