Re: Fix resource leak (src/backend/libpq/be-secure-common.c)

Em ter., 14 de mai. de 2024 às 07:21, Daniel Gustafsson escreveu: > > On 14 May 2024, at 08:03, Michael Paquier wrote: > > > > On Mon, May 13, 2024 at 08:06:57PM +0200, Daniel Gustafsson wrote: > >>> Any chance we'll have these fixes in v17? > >> > >> Nice timing, I was actually rebasing them to

Re: Fix resource leak (src/backend/libpq/be-secure-common.c)

> On 14 May 2024, at 08:03, Michael Paquier wrote: > > On Mon, May 13, 2024 at 08:06:57PM +0200, Daniel Gustafsson wrote: >>> Any chance we'll have these fixes in v17? >> >> Nice timing, I was actually rebasing them today to get them committed. > > Looks sensible seen from here, as these paths

Re: Fix resource leak (src/backend/libpq/be-secure-common.c)

On Mon, May 13, 2024 at 08:06:57PM +0200, Daniel Gustafsson wrote: >> Any chance we'll have these fixes in v17? > > Nice timing, I was actually rebasing them today to get them committed. Looks sensible seen from here, as these paths could use a LOG or rely on a memory context permanent to the bac

Re: Fix resource leak (src/backend/libpq/be-secure-common.c)

> On 13 May 2024, at 20:05, Ranier Vilela wrote: > Em qua., 10 de abr. de 2024 às 15:33, Daniel Gustafsson > escreveu: > Thanks, I'll have a look. I've left this for post-freeze on purpose to not > cause unnecessary rebasing. Will take a look over the next few days unless > beaten to it. > A

Re: Fix resource leak (src/backend/libpq/be-secure-common.c)

Em qua., 10 de abr. de 2024 às 15:33, Daniel Gustafsson escreveu: > On 10 Apr 2024, at 20:31, Ranier Vilela wrote: > > Em ter., 2 de abr. de 2024 às 15:31, Daniel Gustafsson > escreveu: > >> > On 2 Apr 2024, at 20:13, Ranier Vilela wrote: >> >> > Fix by freeing the pointer, like pclose_check (

Re: Fix resource leak (src/backend/libpq/be-secure-common.c)

> On 10 Apr 2024, at 20:31, Ranier Vilela wrote: > > Em ter., 2 de abr. de 2024 às 15:31, Daniel Gustafsson > escreveu: >> > On 2 Apr 2024, at 20:13, Ranier Vilela > > > wrote: >> >> > Fix by freeing the pointer, like pclose_check (src/common/

Re: Fix resource leak (src/backend/libpq/be-secure-common.c)

Em ter., 2 de abr. de 2024 às 15:31, Daniel Gustafsson escreveu: > > On 2 Apr 2024, at 20:13, Ranier Vilela wrote: > > > Fix by freeing the pointer, like pclose_check (src/common/exec.c) > similar case. > > Off the cuff, seems reasonable when loglevel is LOG. > Per Coverity. Another case of re

Re: Fix resource leak (src/backend/libpq/be-secure-common.c)

> On 2 Apr 2024, at 20:13, Ranier Vilela wrote: > Fix by freeing the pointer, like pclose_check (src/common/exec.c) similar > case. Off the cuff, seems reasonable when loglevel is LOG. -- Daniel Gustafsson

Fix resource leak (src/backend/libpq/be-secure-common.c)

Hi, Per Coverity. Coverity reported a resource leak at the function run_ssl_passphrase_command. 7. alloc_fn: Storage is returned from allocation function wait_result_to_str.["show details"] 8. noescape: Assuming resource wait_result_to_str(pclose_rc) is not freed or pointed-to as ellipsis argume