Fix typos and inconsistencies for HEAD (take 7)

2019-07-20 Thread Alexander Lakhin
Hello hackers, Please consider fixing the next pack of typos and inconsistencies in the tree: 7.1. h04m05s06 -> h04mm05s06 (in fact it's broken since 6af04882, but h04mm05s06.789 still accepted) 7.2. hasbucketcleanup -> hashbucketcleanup 7.3. _hashm_spare -> hashm_spares 7.4. hashtbl -> hash table

Fix typos and inconsistencies for HEAD (take 7)

2019-07-20 Thread Alexander Lakhin
Hello hackers, Please consider fixing the next pack of typos and inconsistencies in the tree: 7.1. h04m05s06 -> h04mm05s06 (in fact it's broken since 6af04882, but h04mm05s06.789 still accepted) 7.2. hasbucketcleanup -> hashbucketcleanup 7.3. _hashm_spare -> hashm_spares 7.4. hashtbl -> hash table

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Tom Lane
Alexander Lakhin writes: > Also, I found e-mail headers in optimizer/plan/README not relevant, so I > propose to remove them. FWIW, I think they're highly relevant, because they put a date on that text. I've not gone through that README lately, but I wouldn't be surprised if it's largely obsolet

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Michael Paquier
On Sun, Jul 21, 2019 at 08:28:53AM +0300, Alexander Lakhin wrote: > Please consider fixing the next pack of typos and inconsistencies in the > tree: Thanks, all those things look fine. I have noticed one mistake. > 7.44. json_plperl -> jsonb_plperlu The path was incorrect here. > Also, I found

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Tom Lane
Michael Paquier writes: > On Sun, Jul 21, 2019 at 08:28:53AM +0300, Alexander Lakhin wrote: >> And another finding is related to the sleep effective resolution. `man 7 >> time` says "Since kernel 2.6.13, the HZ value is a kernel configuration  >> parameter  and  can  be 100, 250 (the default) ..."

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Alexander Lakhin
Hello Michael, 22.07.2019 4:05, Michael Paquier wrote: >> Also, I found e-mail headers in optimizer/plan/README not relevant, so I >> propose to remove them. > Not sure about that part. I agree that the proposed fix is not complete, but just raises the demand for a subsequent fix. If you don't mind

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Alexander Lakhin
Hello Tom, 22.07.2019 7:14, Tom Lane wrote: >> Fixing both places sounds adapted to me. An alternative we could use >> here is just to say something like that: >> The effective resolution is only 1/HZ, which can be configured with >> kernel parameter (see man 7 time), and is 4 milliseconds by >> d

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Tom Lane
Alexander Lakhin writes: > Also, I found e-mail headers in optimizer/plan/README not relevant, so I > propose to remove them. FWIW, I think they're highly relevant, because they put a date on that text. I've not gone through that README lately, but I wouldn't be surprised if it's largely obsolet

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Michael Paquier
On Sun, Jul 21, 2019 at 08:28:53AM +0300, Alexander Lakhin wrote: > Please consider fixing the next pack of typos and inconsistencies in the > tree: Thanks, all those things look fine. I have noticed one mistake. > 7.44. json_plperl -> jsonb_plperlu The path was incorrect here. > Also, I found

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Tom Lane
Michael Paquier writes: > On Sun, Jul 21, 2019 at 08:28:53AM +0300, Alexander Lakhin wrote: >> And another finding is related to the sleep effective resolution. `man 7 >> time` says "Since kernel 2.6.13, the HZ value is a kernel configuration  >> parameter  and  can  be 100, 250 (the default) ..."

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Alexander Lakhin
Hello Michael, 22.07.2019 4:05, Michael Paquier wrote: >> Also, I found e-mail headers in optimizer/plan/README not relevant, so I >> propose to remove them. > Not sure about that part. I agree that the proposed fix is not complete, but just raises the demand for a subsequent fix. If you don't mind

Re: Fix typos and inconsistencies for HEAD (take 7)

2019-07-21 Thread Alexander Lakhin
Hello Tom, 22.07.2019 7:14, Tom Lane wrote: >> Fixing both places sounds adapted to me. An alternative we could use >> here is just to say something like that: >> The effective resolution is only 1/HZ, which can be configured with >> kernel parameter (see man 7 time), and is 4 milliseconds by >> d