On Tue, May 02, 2023 at 12:26:31PM +0900, Michael Paquier wrote:
> On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote:
>> 4. CommitTSBuffer -> CommitTsBuffer // the inconsistency exists since
>> 5da14938f; maybe this change should be backpatched
>
> Yes, we'd better backpatch that.
On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote:
> Please look at the following two bunches for v14+ and v13+ (split to ease
> back-patching if needed). Having processed them, I've reached the state that
> could be considered "clean" ([2], [3]); at least I don't see how to detect
>
Hi David,
21.04.2023 01:49, David Rowley wrote:
On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin wrote:
please look at the similar list for v15+ (596b5af1d..HEAD).
I've now pushed most of these but didn't include the following ones:
Thank you!
3. BufFileOpenShared -> BufFileOpenFileSet // s
On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin wrote:
> please look at the similar list for v15+ (596b5af1d..HEAD).
I've now pushed most of these but didn't include the following ones:
> 3. BufFileOpenShared -> BufFileOpenFileSet // see dcac5e7ac
Maybe I need to spend longer, but I just didn't
Justin Pryzby writes:
> On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote:
>> On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote:
>>> and s/evade/avoid/
>> I didn't touch this. You'll need to provide more justification for why
>> you think it's more correct than what's there.
> I'd
Hi Justin and David,
18.04.2023 01:10, Justin Pryzby wrote:
Well done.
Thank you for reviewing!
On Mon, Apr 17, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote:
Hello hackers,
Please consider fixing the following unique words/identifiers introduced in v16:
Note that your patches are over
On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote:
> On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote:
> > > - * USER SET values are appliciable only for PGC_USERSET
> > > parameters. We
> > > + * USER SET values are applicable only for PGC_USERSET
> > > par
David Rowley writes:
> On Tue, 18 Apr 2023 at 06:00, Alexander Lakhin wrote:
>> Also, maybe OID_MAX should be removed from src/include/postgres_ext.h as
>> it's unused since eb8312a22.
> I didn't touch this. It seems like it could be useful for extensions
> and client apps even if it's not used
On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote:
> > - * USER SET values are appliciable only for PGC_USERSET
> > parameters. We
> > + * USER SET values are applicable only for PGC_USERSET
> > parameters. We
> >* use InvalidOid as role in order to evad
On Tue, 18 Apr 2023 at 06:00, Alexander Lakhin wrote:
> Please consider fixing the following unique words/identifiers introduced in
> v16:
Thanks, I've pushed all of these apart from the following 2.
> 45. tar_set_error -- remove (obsolete since ebfb814f7)
> 46. test_tranche_name -- remove (not
On Mon, Apr 17, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote:
> Hello hackers,
>
> Please consider fixing the following unique words/identifiers introduced in
> v16:
Well done.
Note that your patches are overlapping:
3 --- a/src/backend/utils/misc/guc.c
2 --- a/src/test/perl/Po
Hello hackers,
Please consider fixing the following unique words/identifiers introduced in v16:
1. addresess -> addresses
2. adminstrator -> administrator // the same typo found in src/backend/po/id.po, but perhaps it should be fixed via
pgsql-translators
3. appeneded -> appended
4. appliciable
12 matches
Mail list logo
