On Tue, Feb 28, 2023 at 02:06:05PM +0900, Michael Paquier wrote:
> Are there any objections to do what's proposed in the patch and
> improve the testing coverage of query jumbling by default?
Well, done this one as of d28a449. More validation tests could always
be added later if there are better
On Thu, Feb 16, 2023 at 02:08:42PM +0900, Michael Paquier wrote:
> Other ideas are welcome. At least this would be a start.
The main idea of the patch is here:
> +# Check some data from pg_stat_statements.
> +$node_primary->safe_psql('postgres', 'CREATE EXTENSION pg_stat_statements');
> +# This
On Tue, Feb 14, 2023 at 10:11:21AM -0800, Andres Freund wrote:
> I didn't mean printing in the sense of outputting the statements to the tap
> log. Maybe creating a temp table or such for all the queries. And yes, then
> doing some top-level analysis on it like you describe sounds like a good idea.
Hi,
On 2023-02-14 16:04:16 +0900, Michael Paquier wrote:
> On Mon, Feb 13, 2023 at 09:45:12AM -0800, Andres Freund wrote:
> > Shouldn't there at least be some basic verification of pg_stat_statements
> > output being sane after running the test? Even if that's perhaps just
> > actually
> > printi
On Mon, Feb 13, 2023 at 09:45:12AM -0800, Andres Freund wrote:
> Shouldn't there at least be some basic verification of pg_stat_statements
> output being sane after running the test? Even if that's perhaps just actually
> printing the statements.
There is a total of 20k entries in pg_stat_statemen
Hi,
On 2023-02-13 14:00:36 +0900, Michael Paquier wrote:
> With this addition, the query jumbling gets covered at 95%~, while
> https://coverage.postgresql.org/src/backend/nodes/index.html reports
> currently 35%.
>
> Thoughts or comments?
Shouldn't there at least be some basic verification of p
Hi all,
As mentioned two times on this thread, there is not much coverage for
the query jumbling code, even if it is in core:
https://www.postgresql.org/message-id/Y5BHOUhX3zTH/i...@paquier.xyz
Ths issue is that we have the options to enable it, but only
pg_stat_statements is able to enable and s
