Re: FullTransactionId changes are causing portability issues

2019-05-23 Thread Tom Lane
Andres Freund writes: > On 2019-05-23 14:05:19 -0400, Tom Lane wrote: >> I think you're vastly overstating the case for refusing support for this. >> Adding "#ifndef FRONTEND" to relevant headers isn't a huge amount of work >> --- it's certainly far less of a problem than the Microsoft-droppings

Re: FullTransactionId changes are causing portability issues

2019-05-23 Thread Andres Freund
Hi, On 2019-05-23 14:05:19 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-23 13:46:15 -0400, Tom Lane wrote: > >> I'm not really excited about adopting a position that PG will only > >> build on GCC and clones thereof. > > > That's not what I said though? Not supporting one

Re: FullTransactionId changes are causing portability issues

2019-05-23 Thread Tom Lane
Andres Freund writes: > On 2019-05-23 13:46:15 -0400, Tom Lane wrote: >> I'm not really excited about adopting a position that PG will only >> build on GCC and clones thereof. > That's not what I said though? Not supporting one compiler, on an OS > that's effectively not being developed anymore,

Re: FullTransactionId changes are causing portability issues

2019-05-23 Thread Andres Freund
Hi, On 2019-05-23 13:46:15 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-22 16:13:02 -0400, Tom Lane wrote: > >> It doesn't sound like "use a newer compiler" is going to be a helpful > >> answer there. > > > Well, GCC is available on solaris, and IIRC not that hard to install >

Re: FullTransactionId changes are causing portability issues

2019-05-23 Thread Tom Lane
Andres Freund writes: > On 2019-05-22 16:13:02 -0400, Tom Lane wrote: >> It doesn't sound like "use a newer compiler" is going to be a helpful >> answer there. > Well, GCC is available on solaris, and IIRC not that hard to install > (isn't it just a 'pkg install gcc' or such?). Don't think we

Re: FullTransactionId changes are causing portability issues

2019-05-23 Thread Andres Freund
Hi, On 2019-05-22 16:13:02 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-22 15:55:50 -0400, Tom Lane wrote: > Per Bjorn's report: > >> The compiler used in Sun Studio 12u1, very old and and I can try to > >> upgrade and see if that helps. > > I tried Sun Studio 12u2 and then a

Re: FullTransactionId changes are causing portability issues

2019-05-22 Thread Tom Lane
Andres Freund writes: > On 2019-05-22 15:55:50 -0400, Tom Lane wrote: >>> So the disturbing thing here is that we no longer have any active >>> buildfarm members that can build HEAD but have the won't-elide- >>> unused-static-functions problem. Clearly we'd better close that >>> gap somehow ...

Re: FullTransactionId changes are causing portability issues

2019-05-22 Thread Andres Freund
Hi, On 2019-05-22 15:55:50 -0400, Tom Lane wrote: > I wrote: > >> Our Solaris packager reports that 12beta1 is failing to build for him > >> on some Solaris variants: > >>> The link failure is: > >>> Undefined first referenced > >>> symbolin file > >>>

Re: FullTransactionId changes are causing portability issues

2019-05-22 Thread Tom Lane
I wrote: >> Our Solaris packager reports that 12beta1 is failing to build for him >> on some Solaris variants: >>> The link failure is: >>> Undefined first referenced >>> symbol in file >>> ReadNextFullTransactionId pg_checksums.o > On looking

Re: FullTransactionId changes are causing portability issues

2019-05-22 Thread Tom Lane
I wrote: > Our Solaris packager reports that 12beta1 is failing to build for him > on some Solaris variants: >> The link failure is: >> --- >> Undefinedfirst referenced >> symbol in file >> ReadNextFullTransactionId pg_checksums.o >> ld:

FullTransactionId changes are causing portability issues

2019-05-22 Thread Tom Lane
Our Solaris packager reports that 12beta1 is failing to build for him on some Solaris variants: > The link failure is: > --- > Undefined first referenced > symbol in file > ReadNextFullTransactionId pg_checksums.o > ld: fatal: symbol