Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Mon, Apr 16, 2018 at 07:48:47PM +0300, Liudmila Mantrova wrote: > Hi everyone, > > When translating doc updates, Alexander Lakhin noticed that trigram examples > were not quite accurate. > A small patch fixing this issue is attached. FYI, this has been applied by Teodor Sigaev:

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

Hi everyone, When translating doc updates, Alexander Lakhin noticed that trigram examples were not quite accurate. A small patch fixing this issue is attached. On 03/21/2018 03:35 PM, Teodor Sigaev wrote: Thank you, pushed David Steele wrote: On 3/6/18 7:04 AM, Teodor Sigaev wrote: I

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

Thank you, pushed David Steele wrote: On 3/6/18 7:04 AM, Teodor Sigaev wrote: I agree with Teodor (upthread, not quoted here) that the documentation could use some editing. I started to do it myself, but quickly realized I have no knowledge of the content.  I'm afraid I would destroy the

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Tue, Mar 6, 2018 at 7:59 PM, David Steele wrote: > On 3/6/18 7:04 AM, Teodor Sigaev wrote: > >> I agree with Teodor (upthread, not quoted here) that the documentation > >> could use some editing. > >> > >> I started to do it myself, but quickly realized I have no

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On 3/6/18 7:04 AM, Teodor Sigaev wrote: >> I agree with Teodor (upthread, not quoted here) that the documentation >> could use some editing. >> >> I started to do it myself, but quickly realized I have no knowledge of >> the content.  I'm afraid I would destroy the meaning while updating the >>

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

I agree with Teodor (upthread, not quoted here) that the documentation could use some editing. I started to do it myself, but quickly realized I have no knowledge of the content. I'm afraid I would destroy the meaning while updating the grammar. Anyone understand the subject matter well enough

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

Hi Alexander, On 3/1/18 4:26 PM, Alexander Korotkov wrote: On Thu, Mar 1, 2018 at 11:05 PM, David Steele > wrote: I agree with Teodor (upthread, not quoted here) that the documentation could use some editing. I started to do it

Re: Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Thu, Mar 1, 2018 at 11:05 PM, David Steele wrote: > On 1/4/18 4:25 PM, Alexander Korotkov wrote: > > > > I just found that patch apply is failed according to > > commitfest.cputube.org . I think it's > > because I sent only second patch

Re: Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

Hi Alexander, On 1/4/18 4:25 PM, Alexander Korotkov wrote: > > I just found that patch apply is failed according to > commitfest.cputube.org .  I think it's > because I sent only second patch from patchset in last message. > Anyway I resend both patches rebased to

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

Hello everyone, I would like to contribute to documentation review of the patches discussed in thread https://www.postgresql.org/message-id/flat/cy4pr17mb13207ed8310f847cf117eed0d8...@cy4pr17mb1320.namprd17.prod.outlook.com (https://commitfest.postgresql.org/16/1403/). Unfortunately, I was

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Wed, Dec 13, 2017 at 2:13 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Tue, Dec 12, 2017 at 2:33 PM, Teodor Sigaev wrote: > >> 0002-pg-trgm-strict_word-similarity.patch – implementation of >>> strict_word_similarity() with comments, docs and tests. >>> >>

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Tue, Dec 12, 2017 at 2:33 PM, Teodor Sigaev wrote: > 0002-pg-trgm-strict_word-similarity.patch – implementation of >> strict_word_similarity() with comments, docs and tests. >> > After some looking in > > 1) > repeated piece of code: > + if (strategy ==

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

0001-pg-trgm-word-similarity-docs-improvement.patch – contains improvement to documentation of word_similarity() and related operators.  I decided to give formal definition first (what exactly it internally does), and then example and some more human-understandable description.  This patch also

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

0002-pg-trgm-strict_word-similarity.patch – implementation of strict_word_similarity() with comments, docs and tests. After some looking in 1) repeated piece of code: + if (strategy == SimilarityStrategyNumber) + nlimit = similarity_threshold; + else if

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

0002-pg-trgm-strict_word-similarity.patch – implementation of strict_word_similarity() with comments, docs and tests. The patch looks commmitable, but sometime I get *** ...pgsql/contrib/pg_trgm/expected/pg_strict_word_trgm.out 2017-12-12 14:16:55.190989000 +0300 ---

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Fri, Dec 8, 2017 at 2:50 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Thu, Dec 7, 2017 at 8:59 PM, Robert Haas wrote: > >> On Tue, Nov 7, 2017 at 7:51 AM, Jan Przemysław Wójcik >> wrote: >> > I'm afraid that creating

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Thu, Dec 7, 2017 at 8:59 PM, Robert Haas wrote: > On Tue, Nov 7, 2017 at 7:51 AM, Jan Przemysław Wójcik > wrote: > > I'm afraid that creating a function that implements quite different > > algorithms depending on a global parameter

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Tue, Nov 7, 2017 at 7:51 AM, Jan Przemysław Wójcik wrote: > I'm afraid that creating a function that implements quite different > algorithms depending on a global parameter seems very hacky and would lead > to misunderstandings. I do understand the need of

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Tue, Nov 7, 2017 at 7:24 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Tue, Nov 7, 2017 at 3:51 PM, Jan Przemysław Wójcik < > jan.przemyslaw.woj...@gmail.com> wrote: > >> my statement about the function usefulness was probably too categorical, >> though I had in mind the