Hello,
I've discovered that the pg_bsd_indent test added here makes an
ASAN-instrumented build fail on:
ASAN_OPTIONS=detect_leaks=0:strict_string_checks=1 make check-world
as follows:
# +++ tap check in src/tools/pg_bsd_indent +++
t/001_pg_bsd_indent.pl .. 1/?
# Failed test 'pg_bsd_indent
On Sun, Feb 12, 2023 at 2:44 PM Tom Lane wrote:
> I wrote:
> > Hmmm ... ci autoconf build is now happy, but the Windows run complains
> > that none of the output files match. I'm betting that this is a
> > Windows-newline problem, since I now see that indent.c opens both the
> > input and output
Hmmm ... ci autoconf build is now happy, but the Windows run complains
that none of the output files match. I'm betting that this is a
Windows-newline problem, since I now see that indent.c opens both the
input and output files in default (text) mode. I'm inclined to
change it to open the output
Andres Freund writes:
> # Running: pg_bsd_indent --version
> Command 'pg_bsd_indent' not found in
> /tmp/cirrus-ci-build/tmp_install/usr/local/pgsql/bin,
> /tmp/cirrus-ci-build/src/tools/pg_bsd_indent, /usr/local/sbin,
> /usr/local/bin, /usr/sbin, /usr/bin, /sbin, /bin at
>
Hi,
On 2023-02-11 18:54:00 -0500, Tom Lane wrote:
> I ended up converting the test infrastructure into a TAP test,
> which kind of feels like overkill; but the Meson system doesn't
> seem to provide any lower-overhead way to run a test.
FWIW, The default way to indicate failures in a test is the
Andres Freund writes:
> Perhaps we should install it, just not in bin/, but alongside pgxs/, similar
> to pg_regress et al?
For my own purposes, I really don't want it anywhere in the --prefix
tree. That's not necessarily present when I'm using the program.
(Hmm, clarify: it wouldn't matter if
On 2023-02-09 19:20:37 -0500, Tom Lane wrote:
> Andres Freund writes:
> > I'm fine either way. It's barely noticeable compared to the rest of
> > postgres.
>
> Yeah, build-by-default isn't really a big deal. Install-by-default
> is more of a problem...
Perhaps we should install it, just not
Andres Freund writes:
> On 2023-02-09 18:19:06 -0500, Tom Lane wrote:
>> I thought about registering it, but that won't teach us anything unless
>> we make it built-by-default, which was not my intention. I guess we
>> could temporarily include it in the build.
> The meson patch I sent did
Hi,
On 2023-02-09 18:19:06 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-02-09 17:19:22 -0500, Tom Lane wrote:
> >> Hmmm .. a shell script would be fine by me, but it won't help in
> >> testing a Windows build. Maybe we need to make it a Perl script?
>
> > At least for casual
Andres Freund writes:
> On 2023-02-09 17:19:22 -0500, Tom Lane wrote:
>> Hmmm .. a shell script would be fine by me, but it won't help in
>> testing a Windows build. Maybe we need to make it a Perl script?
> At least for casual testing a shell script actually mostly works, due to git
> it's
Hi,
On 2023-02-09 17:19:22 -0500, Tom Lane wrote:
> Andres Freund writes:
> > The trivial fix of using MAXPGPATH made it build, without warnings. That
> > doesn't say anything about actually working. So I guess porting the test
> > would
> > make sense.
>
> > Opinions on whether it would make
Andres Freund writes:
> The trivial fix of using MAXPGPATH made it build, without warnings. That
> doesn't say anything about actually working. So I guess porting the test would
> make sense.
> Opinions on whether it would make sense as a shell script?
Hmmm .. a shell script would be fine by
Hi,
On 2023-02-09 13:55:32 -0800, Andres Freund wrote:
> ../src/tools/pg_bsd_indent/args.c(179): error C2065: 'PATH_MAX': undeclared
> identifier
> ../src/tools/pg_bsd_indent/args.c(179): error C2057: expected constant
> expression
> ../src/tools/pg_bsd_indent/args.c(179): error C2466: cannot
Andres Freund writes:
> Did that in the attached.
Thanks.
> I didn't convert the test though, due to the duplicating it'd create. Perhaps
> we should just move it to a shell script? Or maybe it just doesn't matter
> enough to bother with?
We could move it to a shell script perhaps, but that
Andres Freund writes:
> On 2023-02-09 13:30:30 -0500, Tom Lane wrote:
>> 0003 lacks meson support (anyone want to help with that?)
> I'll give it a go, unless somebody else wants to.
Thanks.
> Do we expect pg_bsd_indent to build / work on windows, right now?
It would be desirable, for sure.
Hi,
On 2023-02-09 13:30:30 -0500, Tom Lane wrote:
> 0003 lacks meson support (anyone want to help with that?)
I'll give it a go, unless somebody else wants to.
Do we expect pg_bsd_indent to build / work on windows, right now? If it
doesn't, do we want to make that a hard requirement?
I'll
16 matches
Mail list logo
