Re: Incorrect version number given to sync_pgdata() in pg_combinebackup.c

2025-10-18 Thread Chao Li
> On Oct 10, 2025, at 14:21, Michael Paquier wrote: > > Hi all, > > While hacking on a different thing that touched pg_combinebackup, I > have bumped into a silly bug. > > To keep it short, the version number is calculated based on this code > in read_pg_version_file(), where "version" is the

Incorrect version number given to sync_pgdata() in pg_combinebackup.c

2025-10-17 Thread Michael Paquier
Hi all, While hacking on a different thing that touched pg_combinebackup, I have bumped into a silly bug. To keep it short, the version number is calculated based on this code in read_pg_version_file(), where "version" is the result of strtoul() applied to the contents of PG_VERSION: return

Re: Incorrect version number given to sync_pgdata() in pg_combinebackup.c

2025-10-13 Thread Michael Paquier
On Fri, Oct 10, 2025 at 02:39:58PM +0800, Chao Li wrote: > Yeah, looks like a stupid bug. read_pg_version_file() has multiplied > 1 to version number. Thanks for the review. Applied this one down to v17. -- Michael signature.asc Description: PGP signature