Re: Increase footprint of %m and reduce strerror()

2019-12-23 Thread Michael Paquier
On Fri, Dec 06, 2019 at 02:09:05PM +0900, Michael Paquier wrote: > I guess that we should do that at the end of the day. A lookup at the > in-core tools I see three areas which stand out compared to the rest: > - pg_waldump, and attached is a patch for it. Okay, I have committed this one. -- Mich

Re: Increase footprint of %m and reduce strerror()

2019-12-05 Thread Michael Paquier
On Thu, Dec 05, 2019 at 12:29:29PM +0900, Kyotaro Horiguchi wrote: > At Thu, 05 Dec 2019 12:06:54 +0900 (JST), Kyotaro Horiguchi > wrote in >> So, (IIUC) do we replace fprintf()s for error reporting together (but >> maybe in a separate patch)? I guess that we should do that at the end of the da

Re: Increase footprint of %m and reduce strerror()

2019-12-04 Thread Kyotaro Horiguchi
(Just to clarifying the last mail..) At Thu, 05 Dec 2019 12:06:54 +0900 (JST), Kyotaro Horiguchi wrote in > At Thu, 5 Dec 2019 11:36:48 +0900, Michael Paquier > wrote in > > On Wed, Dec 04, 2019 at 03:32:11PM +0900, Kyotaro Horiguchi wrote: > > > It sounds good to me. Message unification (i

Re: Increase footprint of %m and reduce strerror()

2019-12-04 Thread Kyotaro Horiguchi
At Thu, 5 Dec 2019 11:36:48 +0900, Michael Paquier wrote in > On Wed, Dec 04, 2019 at 03:32:11PM +0900, Kyotaro Horiguchi wrote: > > It sounds good to me. Message unification (including printf) needs > > somehow treating trailing new lines, though. About translation > > burden, I'm not sure ho

Re: Increase footprint of %m and reduce strerror()

2019-12-04 Thread Michael Paquier
On Wed, Dec 04, 2019 at 03:32:11PM +0900, Kyotaro Horiguchi wrote: > It sounds good to me. Message unification (including printf) needs > somehow treating trailing new lines, though. About translation > burden, I'm not sure how the message unification eases translators' > work. Identical messages

Re: Increase footprint of %m and reduce strerror()

2019-12-03 Thread Kyotaro Horiguchi
At Fri, 29 Nov 2019 15:51:15 +0900, Michael Paquier wrote in > Hi all, > > Since commit d6c55de1, we support %m in the in-core port for printf > and such. And it seems to me that we could do better for the frontend > code by reducing the dependency to strerror(). > > One advantage of doing a

Increase footprint of %m and reduce strerror()

2019-11-28 Thread Michael Paquier
Hi all, Since commit d6c55de1, we support %m in the in-core port for printf and such. And it seems to me that we could do better for the frontend code by reducing the dependency to strerror(). One advantage of doing a switch, or at least reduce the use of strerror(), would be to ease the work of