Re: Index maintenance function for BRIN doesn't check RecoveryInProgress()

2018-06-15 Thread Masahiko Sawada
On Fri, Jun 15, 2018 at 2:20 AM, Alvaro Herrera wrote: > On 2018-Jun-14, Michael Paquier wrote: > >> On Thu, Jun 14, 2018 at 02:06:57AM +0900, Masahiko Sawada wrote: >> > On Thu, Jun 14, 2018 at 12:04 AM, Simon Riggs >> > wrote: >> >> On 13 June 2018 at 15:51, Alvaro Herrera wrote: >> >>> I gue

Re: Index maintenance function for BRIN doesn't check RecoveryInProgress()

2018-06-14 Thread Alvaro Herrera
On 2018-Jun-14, Michael Paquier wrote: > On Thu, Jun 14, 2018 at 02:06:57AM +0900, Masahiko Sawada wrote: > > On Thu, Jun 14, 2018 at 12:04 AM, Simon Riggs wrote: > >> On 13 June 2018 at 15:51, Alvaro Herrera wrote: > >>> I guess you could go either way ... we're just changing one unhelpful > >>

Re: Index maintenance function for BRIN doesn't check RecoveryInProgress()

2018-06-13 Thread Michael Paquier
On Thu, Jun 14, 2018 at 02:06:57AM +0900, Masahiko Sawada wrote: > On Thu, Jun 14, 2018 at 12:04 AM, Simon Riggs wrote: >> On 13 June 2018 at 15:51, Alvaro Herrera wrote: >>> I guess you could go either way ... we're just changing one unhelpful >>> error with a better one: there is no change in b

Re: Index maintenance function for BRIN doesn't check RecoveryInProgress()

2018-06-13 Thread Masahiko Sawada
On Thu, Jun 14, 2018 at 12:04 AM, Simon Riggs wrote: > On 13 June 2018 at 15:51, Alvaro Herrera wrote: >> On 2018-Jun-13, Alexander Korotkov wrote: >> >>> On Wed, Jun 13, 2018 at 12:48 PM Kuntal Ghosh >>> wrote: >>> > On Wed, Jun 13, 2018 at 2:28 PM, Masahiko Sawada >>> > wrote: >>> > > Hi, >>

Re: Index maintenance function for BRIN doesn't check RecoveryInProgress()

2018-06-13 Thread Simon Riggs
On 13 June 2018 at 15:51, Alvaro Herrera wrote: > On 2018-Jun-13, Alexander Korotkov wrote: > >> On Wed, Jun 13, 2018 at 12:48 PM Kuntal Ghosh >> wrote: >> > On Wed, Jun 13, 2018 at 2:28 PM, Masahiko Sawada >> > wrote: >> > > Hi, >> > > >> > > Three functions: brin_summarize_new_values, brin_su

Re: Index maintenance function for BRIN doesn't check RecoveryInProgress()

2018-06-13 Thread Alvaro Herrera
On 2018-Jun-13, Alexander Korotkov wrote: > On Wed, Jun 13, 2018 at 12:48 PM Kuntal Ghosh > wrote: > > On Wed, Jun 13, 2018 at 2:28 PM, Masahiko Sawada > > wrote: > > > Hi, > > > > > > Three functions: brin_summarize_new_values, brin_summarize_range and > > > brin_desummarize_range can be calle

Re: Index maintenance function for BRIN doesn't check RecoveryInProgress()

2018-06-13 Thread Alexander Korotkov
On Wed, Jun 13, 2018 at 12:48 PM Kuntal Ghosh wrote: > On Wed, Jun 13, 2018 at 2:28 PM, Masahiko Sawada > wrote: > > Hi, > > > > Three functions: brin_summarize_new_values, brin_summarize_range and > > brin_desummarize_range can be called during recovery as follows. > > > > =# select brin_summar

Re: Index maintenance function for BRIN doesn't check RecoveryInProgress()

2018-06-13 Thread Kuntal Ghosh
On Wed, Jun 13, 2018 at 2:28 PM, Masahiko Sawada wrote: > Hi, > > Three functions: brin_summarize_new_values, brin_summarize_range and > brin_desummarize_range can be called during recovery as follows. > > =# select brin_summarize_new_values('a_idx'); > ERROR: cannot acquire lock mode ShareUpdate

Index maintenance function for BRIN doesn't check RecoveryInProgress()

2018-06-13 Thread Masahiko Sawada
Hi, Three functions: brin_summarize_new_values, brin_summarize_range and brin_desummarize_range can be called during recovery as follows. =# select brin_summarize_new_values('a_idx'); ERROR: cannot acquire lock mode ShareUpdateExclusiveLock on database objects while recovery is in progress HINT: