Re: Inheriting table AMs for partitioned tables

2019-03-06 Thread David Rowley
On Wed, 6 Mar 2019 at 07:19, Robert Haas wrote: > > On Tue, Mar 5, 2019 at 12:59 PM Andres Freund wrote: > > Based on this mail I'm currently planning to simply forbid specifying > > USING for partitioned tables. Then we can argue about this later. > > +1. I actually think that might be the righ

Re: Inheriting table AMs for partitioned tables

2019-03-05 Thread David Rowley
On Tue, 5 Mar 2019 at 19:08, Andres Freund wrote: > > On 2019-03-05 16:01:50 +1300, David Rowley wrote: > > I'd suggest it's made to work the same way as ca4103025dfe26 made > > tablespaces work. > > Hm, is that actually correct? Because as far as I can tell that doesn't > have the necessary pg_d

Re: Inheriting table AMs for partitioned tables

2019-03-05 Thread Robert Haas
On Tue, Mar 5, 2019 at 12:59 PM Andres Freund wrote: > Based on this mail I'm currently planning to simply forbid specifying > USING for partitioned tables. Then we can argue about this later. +1. I actually think that might be the right thing in the long-term, but it undeniably avoids committin

Re: Inheriting table AMs for partitioned tables

2019-03-05 Thread Andres Freund
On 2019-03-04 22:08:04 -0800, Andres Freund wrote: > Hi, > > On 2019-03-05 16:01:50 +1300, David Rowley wrote: > > On Tue, 5 Mar 2019 at 12:47, Andres Freund wrote: > > > CREATE TABLE tableam_parted_heap2 (a text, b int) PARTITION BY list (a) > > > USING heap2; > > > > > > SET default_table_acce

Re: Inheriting table AMs for partitioned tables

2019-03-04 Thread Andres Freund
Hi, On 2019-03-05 16:01:50 +1300, David Rowley wrote: > On Tue, 5 Mar 2019 at 12:47, Andres Freund wrote: > > CREATE TABLE tableam_parted_heap2 (a text, b int) PARTITION BY list (a) > > USING heap2; > > > > SET default_table_access_method = 'heap'; > > CREATE TABLE tableam_parted_a_heap2 PARTITI

Re: Inheriting table AMs for partitioned tables

2019-03-04 Thread Haribabu Kommi
On Tue, Mar 5, 2019 at 10:47 AM Andres Freund wrote: > Hi, > > In the pluggable storage patch [1], one thing that I'm wondering about > is how exactly to inherit the storage AM across partitions. I think > that's potentially worthy of a discussion with a wider audience than I'd > get in that thre

Re: Inheriting table AMs for partitioned tables

2019-03-04 Thread Amit Langote
On 2019/03/05 11:59, Amit Langote wrote: > On 2019/03/05 8:47, Andres Freund wrote: >> Hi, >> >> In the pluggable storage patch [1], one thing that I'm wondering about >> is how exactly to inherit the storage AM across partitions. I think >> that's potentially worthy of a discussion with a wider au

Re: Inheriting table AMs for partitioned tables

2019-03-04 Thread David Rowley
On Tue, 5 Mar 2019 at 16:01, David Rowley wrote: > I'd suggest it's made to work the same way as ca4103025dfe26 made > tablespaces work. i.e. if they specify the storage type when creating > the partition, then always use that, unless they mention otherwise. If > nothing was mentioned when they c

Re: Inheriting table AMs for partitioned tables

2019-03-04 Thread David Rowley
On Tue, 5 Mar 2019 at 12:47, Andres Freund wrote: > CREATE TABLE tableam_parted_heap2 (a text, b int) PARTITION BY list (a) USING > heap2; > > SET default_table_access_method = 'heap'; > CREATE TABLE tableam_parted_a_heap2 PARTITION OF tableam_parted_heap2 FOR > VALUES IN ('a'); > But for tabl

Re: Inheriting table AMs for partitioned tables

2019-03-04 Thread Amit Langote
On 2019/03/05 8:47, Andres Freund wrote: > Hi, > > In the pluggable storage patch [1], one thing that I'm wondering about > is how exactly to inherit the storage AM across partitions. I think > that's potentially worthy of a discussion with a wider audience than I'd > get in that thread. It seems

Re: Inheriting table AMs for partitioned tables

2019-03-04 Thread Amit Kapila
On Tue, Mar 5, 2019 at 5:17 AM Andres Freund wrote: > > Hi, > > In the pluggable storage patch [1], one thing that I'm wondering about > is how exactly to inherit the storage AM across partitions. I think > that's potentially worthy of a discussion with a wider audience than I'd > get in that thre

Inheriting table AMs for partitioned tables

2019-03-04 Thread Andres Freund
Hi, In the pluggable storage patch [1], one thing that I'm wondering about is how exactly to inherit the storage AM across partitions. I think that's potentially worthy of a discussion with a wider audience than I'd get in that thread. It seems also related to the recent discussion in [2] Consid