Re: Instability in parallel regression tests

2018-03-14 Thread Tom Lane
Thomas Munro writes: > On Thu, Mar 15, 2018 at 3:32 PM, Tom Lane wrote: >> ... I manually filtered >> out a bunch of non-problems, in particular discarding names that are in >> per-test schemas; I think it's all right to allow tests that are taking >> that precaution to do what they like name-wis

Re: Instability in parallel regression tests

2018-03-14 Thread Thomas Munro
On Thu, Mar 15, 2018 at 3:32 PM, Tom Lane wrote: > ... I manually filtered > out a bunch of non-problems, in particular discarding names that are in > per-test schemas; I think it's all right to allow tests that are taking > that precaution to do what they like name-wise. What if we always did th

Re: Instability in parallel regression tests

2018-03-14 Thread Tom Lane
Thomas Munro writes: > On Thu, Mar 15, 2018 at 12:31 PM, Tom Lane wrote: >> Moral: choose names less generic than "test" for globally-visible >> objects. I wonder if there's some way we could check for such >> conflicts automatically? > Ugh. Yeah. Non-temporary table and view names used in mo

Re: Instability in parallel regression tests

2018-03-14 Thread Thomas Munro
On Thu, Mar 15, 2018 at 12:31 PM, Tom Lane wrote: > guaibasaurus just failed in a way I'd not seen before: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2018-03-14%2006%3A33%3A01 > > Inspection of the diffs makes it depressingly obvious what happened: > the concurrent

Instability in parallel regression tests

2018-03-14 Thread Tom Lane
guaibasaurus just failed in a way I'd not seen before: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2018-03-14%2006%3A33%3A01 Inspection of the diffs makes it depressingly obvious what happened: the concurrently-executing "alter_table" and "with" scripts both create sho