Re: Invalid Assert while validating REPLICA IDENTITY?

2024-09-11 Thread vignesh C
On Wed, 11 Sept 2024 at 10:05, Amit Kapila wrote: > > On Tue, Sep 10, 2024 at 2:16 PM Amit Kapila wrote: > > > > On Tue, Sep 10, 2024 at 11:36 AM vignesh C wrote: > > > > > > On Mon, 9 Sept 2024 at 13:12, Amit Kapila wrote: > > > > > > > > The second part of the assertion is incomplete. The > >

Re: Invalid Assert while validating REPLICA IDENTITY?

2024-09-10 Thread Amit Kapila
On Tue, Sep 10, 2024 at 2:16 PM Amit Kapila wrote: > > On Tue, Sep 10, 2024 at 11:36 AM vignesh C wrote: > > > > On Mon, 9 Sept 2024 at 13:12, Amit Kapila wrote: > > > > > > The second part of the assertion is incomplete. The > > > IsIndexUsableForReplicaIdentityFull() should be used only when t

Re: Invalid Assert while validating REPLICA IDENTITY?

2024-09-10 Thread Amit Kapila
On Tue, Sep 10, 2024 at 11:36 AM vignesh C wrote: > > On Mon, 9 Sept 2024 at 13:12, Amit Kapila wrote: > > > > The second part of the assertion is incomplete. The > > IsIndexUsableForReplicaIdentityFull() should be used only when the > > remote relation has REPLICA_IDENTITY_FULL set. I haven't te

Re: Invalid Assert while validating REPLICA IDENTITY?

2024-09-09 Thread vignesh C
On Mon, 9 Sept 2024 at 13:12, Amit Kapila wrote: > > On Mon, Sep 9, 2024 at 11:44 AM Dilip Kumar wrote: > > > > On Fri, Sep 6, 2024 at 4:48 PM vignesh C wrote: > > > > > > On Mon, 2 Sept 2024 at 18:22, Dilip Kumar wrote: > > > > > > > > On Mon, Sep 2, 2024 at 3:32 PM Amit Kapila > > > > wrote

Re: Invalid Assert while validating REPLICA IDENTITY?

2024-09-09 Thread Amit Kapila
On Mon, Sep 9, 2024 at 11:44 AM Dilip Kumar wrote: > > On Fri, Sep 6, 2024 at 4:48 PM vignesh C wrote: > > > > On Mon, 2 Sept 2024 at 18:22, Dilip Kumar wrote: > > > > > > On Mon, Sep 2, 2024 at 3:32 PM Amit Kapila > > > wrote: > > > > > > > > On Mon, Sep 2, 2024 at 11:21 AM Dilip Kumar > >

Re: Invalid Assert while validating REPLICA IDENTITY?

2024-09-08 Thread Dilip Kumar
On Fri, Sep 6, 2024 at 4:48 PM vignesh C wrote: > > On Mon, 2 Sept 2024 at 18:22, Dilip Kumar wrote: > > > > On Mon, Sep 2, 2024 at 3:32 PM Amit Kapila wrote: > > > > > > On Mon, Sep 2, 2024 at 11:21 AM Dilip Kumar wrote: > > > > > > > > While working on some other code I noticed that in > > >

Re: Invalid Assert while validating REPLICA IDENTITY?

2024-09-06 Thread vignesh C
On Mon, 2 Sept 2024 at 18:22, Dilip Kumar wrote: > > On Mon, Sep 2, 2024 at 3:32 PM Amit Kapila wrote: > > > > On Mon, Sep 2, 2024 at 11:21 AM Dilip Kumar wrote: > > > > > > While working on some other code I noticed that in > > > FindReplTupleInLocalRel() there is an assert [1] that seems to be

Re: Invalid Assert while validating REPLICA IDENTITY?

2024-09-02 Thread Dilip Kumar
On Mon, Sep 2, 2024 at 3:32 PM Amit Kapila wrote: > > On Mon, Sep 2, 2024 at 11:21 AM Dilip Kumar wrote: > > > > While working on some other code I noticed that in > > FindReplTupleInLocalRel() there is an assert [1] that seems to be > > passing IndexRelation to GetRelationIdentityOrPK() whereas

Re: Invalid Assert while validating REPLICA IDENTITY?

2024-09-02 Thread Amit Kapila
On Mon, Sep 2, 2024 at 11:21 AM Dilip Kumar wrote: > > While working on some other code I noticed that in > FindReplTupleInLocalRel() there is an assert [1] that seems to be > passing IndexRelation to GetRelationIdentityOrPK() whereas it should > be passing normal relation. > Agreed. But this sho

Invalid Assert while validating REPLICA IDENTITY?

2024-09-01 Thread Dilip Kumar
While working on some other code I noticed that in FindReplTupleInLocalRel() there is an assert [1] that seems to be passing IndexRelation to GetRelationIdentityOrPK() whereas it should be passing normal relation. [1] if (OidIsValid(localidxoid)) { #ifdef USE_ASSERT_CHECKING Relation idxrel =