Re: Invalid remote sampling test in postgres_fdw.

2025-08-31 Thread Michael Paquier
On Tue, Aug 12, 2025 at 08:58:47AM +0900, Michael Paquier wrote: > I would suggest waiting a bit for the resolution of the other bug, and > make sure that we have at least one reference to the trick with the DO > block. While the way you are writing the test is more readable, > there's also a case

Re: Invalid remote sampling test in postgres_fdw.

2025-08-12 Thread Michael Paquier
On Tue, Aug 12, 2025 at 08:58:47AM +0900, Michael Paquier wrote: > CREATE FOREIGN TABLE analyze_ftable (id int, a text, b bigint) > - SERVER loopback OPTIONS (table_name 'analyze_rtable1'); > + SERVER loopback OPTIONS (table_name 'analyze_table'); > > Good catch. So what your patch i

Re: Invalid remote sampling test in postgres_fdw.

2025-08-11 Thread Michael Paquier
On Mon, Aug 11, 2025 at 10:23:47AM -0400, Corey Huinker wrote: > Patch 0001 concerns what appears to be a bug in the postgres_fdw regression > tests. > > As it was, the tests set the sampling method for the foreign server, but > rather than analyzing a table on that foreign server, the local table

Invalid remote sampling test in postgres_fdw.

2025-08-11 Thread Corey Huinker
Patch 0001 concerns what appears to be a bug in the postgres_fdw regression tests. As it was, the tests set the sampling method for the foreign server, but rather than analyzing a table on that foreign server, the local table analyze_table was analyzed instead. The analyze commands now analyze a