Re: Is MaxHeapAttributeNumber a reasonable restriction for foreign-tables?

2021-02-04 Thread Kohei KaiGai
2021年2月4日(木) 23:45 Tom Lane : > > Amit Langote writes: > > On Thu, Feb 4, 2021 at 4:24 PM Kohei KaiGai wrote: > >> I think that MaxHeapAttributeNumber is a senseless restriction for foreign- > >> tables. How about your opinions? > > > My first reaction to this was a suspicion that the > > MaxHeap

Re: Is MaxHeapAttributeNumber a reasonable restriction for foreign-tables?

2021-02-04 Thread Amit Langote
On Thu, Feb 4, 2021 at 11:45 PM Tom Lane wrote: > Amit Langote writes: > > On Thu, Feb 4, 2021 at 4:24 PM Kohei KaiGai wrote: > >> I think that MaxHeapAttributeNumber is a senseless restriction for foreign- > >> tables. How about your opinions? > > > My first reaction to this was a suspicion tha

Re: Is MaxHeapAttributeNumber a reasonable restriction for foreign-tables?

2021-02-04 Thread Tom Lane
Amit Langote writes: > On Thu, Feb 4, 2021 at 4:24 PM Kohei KaiGai wrote: >> I think that MaxHeapAttributeNumber is a senseless restriction for foreign- >> tables. How about your opinions? > My first reaction to this was a suspicion that the > MaxHeapAttributeNumber limit would be too ingrained

Re: Is MaxHeapAttributeNumber a reasonable restriction for foreign-tables?

2021-02-04 Thread Amit Langote
Hello, On Thu, Feb 4, 2021 at 4:24 PM Kohei KaiGai wrote: > I noticed that CheckAttributeNamesTypes() prevents to create a table that has > more than MaxHeapAttributeNumber (1600) columns, for foreign-table also. > IIUC, this magic number comes from length of the null-bitmap can be covered > with

Is MaxHeapAttributeNumber a reasonable restriction for foreign-tables?

2021-02-03 Thread Kohei KaiGai
Hello, I noticed that CheckAttributeNamesTypes() prevents to create a table that has more than MaxHeapAttributeNumber (1600) columns, for foreign-table also. IIUC, this magic number comes from length of the null-bitmap can be covered with t_hoff in HeapTupleHeaderData. For heap-tables, it seems to