Is it time to retire type "opaque"?

2020-03-03 Thread Tom Lane
While looking at the proposed ALTER TYPE patch, I got annoyed about the amount of cruft that exists in typecmds.c to deal with ancient, non-type-safe ways of declaring type I/O functions. The CREATE TYPE reference pages explains this well enough: Before PostgreSQL version 8.2, the shell-type c

Re: Is it time to retire type "opaque"?

2020-03-03 Thread Tom Lane
I wrote: > In short, I propose ripping out OPAQUE entirely. Like so... I separated out the changes in CREATE TYPE because that's a bit more complicated than the rest. The behavior around shell types gets somewhat simpler, and I moved the I/O function result type checks into the lookup functions

Re: Is it time to retire type "opaque"?

2020-03-06 Thread Andres Freund
Hi, On 2020-03-03 12:10:15 -0500, Tom Lane wrote: > In short, I propose ripping out OPAQUE entirely. +1 > I wouldn't lobby too hard against removing the auto-shell-type hack > either, but it's not actually type-unsafe and it doesn't require > very much code to support, so the case for removing