Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-11-22 Thread Alvaro Herrera
On 2021-Oct-28, Bharath Rupireddy wrote: > Thanks all for reviewing this. Here's the CF entry - > https://commitfest.postgresql.org/35/3378/ Thanks, pushed. I changed a couple of things though -- notably changed the elog() to ereport() as suggested by Nathan early on, but never materialized in

Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-11-10 Thread Bossart, Nathan
On 10/28/21, 5:42 AM, "Bharath Rupireddy" wrote: > Thanks all for reviewing this. Here's the CF entry - > https://commitfest.postgresql.org/35/3378/ I've marked this one as ready-for-committer. Nathan

Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-10-28 Thread Bharath Rupireddy
On Thu, Oct 28, 2021 at 12:41 PM Masahiko Sawada wrote: > > On Thu, Oct 28, 2021 at 11:44 AM Bharath Rupireddy > wrote: > > > > On Thu, Oct 28, 2021 at 7:11 AM Kyotaro Horiguchi > > wrote: > > > > > > At Wed, 27 Oct 2021 14:26:11 -0500, Justin Pryzby > > > wrote in > > > > On Wed, Oct 27,

Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-10-28 Thread Masahiko Sawada
On Thu, Oct 28, 2021 at 11:44 AM Bharath Rupireddy wrote: > > On Thu, Oct 28, 2021 at 7:11 AM Kyotaro Horiguchi > wrote: > > > > At Wed, 27 Oct 2021 14:26:11 -0500, Justin Pryzby > > wrote in > > > On Wed, Oct 27, 2021 at 07:05:10PM +, Bossart, Nathan wrote: > > > > My vote is to just

Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-10-27 Thread Dilip Kumar
On Thu, Oct 28, 2021 at 8:14 AM Bharath Rupireddy wrote: > > > LOG: level: 1; AV worker: 8192 total in 1 blocks; 7928 free (0 chunks); > > 264 used > > Good catch. I've seen the use of "AV" in some of the mem context > names, why that? Let's be specific and say "Autovacuum". Attached > patch

Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-10-27 Thread Bharath Rupireddy
On Thu, Oct 28, 2021 at 7:11 AM Kyotaro Horiguchi wrote: > > At Wed, 27 Oct 2021 14:26:11 -0500, Justin Pryzby > wrote in > > On Wed, Oct 27, 2021 at 07:05:10PM +, Bossart, Nathan wrote: > > > My vote is to just change it to > > > > > > ereport(WARNING, > > >

Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-10-27 Thread Kyotaro Horiguchi
At Wed, 27 Oct 2021 14:26:11 -0500, Justin Pryzby wrote in > On Wed, Oct 27, 2021 at 07:05:10PM +, Bossart, Nathan wrote: > > My vote is to just change it to > > > > ereport(WARNING, > > (errmsg("autovacuum worker took too long to start; > > canceled"))); > > > >

Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-10-27 Thread Justin Pryzby
On Wed, Oct 27, 2021 at 07:05:10PM +, Bossart, Nathan wrote: > On 10/27/21, 9:29 AM, "Bharath Rupireddy" > wrote: > > Is there a specific reason that we have a generic WARNING "worker took > > too long to start; canceled" for an autovacuum worker? Isn't it better > > with "autovacuum worker

Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-10-27 Thread Bossart, Nathan
On 10/27/21, 9:29 AM, "Bharath Rupireddy" wrote: > Is there a specific reason that we have a generic WARNING "worker took > too long to start; canceled" for an autovacuum worker? Isn't it better > with "autovacuum worker took too long to start; canceled"? It is > confusing to see the generic

Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto

2021-10-27 Thread Bharath Rupireddy
Hi, Is there a specific reason that we have a generic WARNING "worker took too long to start; canceled" for an autovacuum worker? Isn't it better with "autovacuum worker took too long to start; canceled"? It is confusing to see the generic message in the server logs while debugging an issue for a