Re: Letter case of "admin option"

2022-08-30 Thread Alvaro Herrera
On 2022-Aug-26, Robert Haas wrote: > Here's a patch changing all occurrences of "admin option" in error > messages to "ADMIN OPTION". > > Two of these five messages also exist in previous releases; the other > three are new. > > I'm not sure if this is our final conclusion on what we want to do

Re: Letter case of "admin option"

2022-08-26 Thread Robert Haas
Here's a patch changing all occurrences of "admin option" in error messages to "ADMIN OPTION". Two of these five messages also exist in previous releases; the other three are new. I'm not sure if this is our final conclusion on what we want to do here, so please speak up if you don't agree.

Re: Letter case of "admin option"

2022-08-25 Thread Robert Haas
On Thu, Aug 25, 2022 at 4:58 AM Alvaro Herrera wrote: > I ran a quick poll in a Spanish community. Everyone who responded (not > many admittedly) agreed with this idea -- they find the message clearer > if the keyword is mentioned explicitly in the translation. Makes sense. I didn't really

Re: Letter case of "admin option"

2022-08-25 Thread Alvaro Herrera
On 2022-Aug-25, Kyotaro Horiguchi wrote: > At Tue, 23 Aug 2022 09:58:47 -0400, Robert Haas wrote > in > I would translate "ADMIN OPTION" to "ADMIN OPTION" in Japanese but > "admin option" is translated to "管理者オプション" which is a bit hard > for the readers to come up with the connection to

Re: Letter case of "admin option"

2022-08-24 Thread Kyotaro Horiguchi
Thanks for the comment. At Tue, 23 Aug 2022 09:58:47 -0400, Robert Haas wrote in > On Mon, Aug 22, 2022 at 9:29 PM Kyotaro Horiguchi > wrote: > In the case of GRANT, that's more ambiguous, because the word OPTION > actually appears in the syntax. But isn't that sort of accidental? Yeah I

Re: Letter case of "admin option"

2022-08-23 Thread Robert Haas
On Mon, Aug 22, 2022 at 9:29 PM Kyotaro Horiguchi wrote: > Today, I see some error messages have been added, two of which look > somewhat inconsistent. > > commands/user.c > @707: > >errmsg("must have admin option on role \"%s\" to add members", > @1971: > >errmsg("grantor must have ADMIN

Re: Letter case of "admin option"

2022-08-23 Thread Alvaro Herrera
On 2022-Aug-23, Kyotaro Horiguchi wrote: > commands/user.c > @707: > >errmsg("must have admin option on role \"%s\" to add members", > @1971: > >errmsg("grantor must have ADMIN OPTION on \"%s\"", > > A grep'ing told me that the latter above is the only outlier among 6 > occurrences in

Letter case of "admin option"

2022-08-22 Thread Kyotaro Horiguchi
Today, I see some error messages have been added, two of which look somewhat inconsistent. commands/user.c @707: >errmsg("must have admin option on role \"%s\" to add members", @1971: >errmsg("grantor must have ADMIN OPTION on \"%s\"", A grep'ing told me that the latter above is the only