Re: List of Bitmapset (was Re: ExecRTCheckPerms() and many prunable partitions)

2022-11-15 Thread Amit Langote
On Wed, Nov 16, 2022 at 3:25 AM Tom Lane wrote: > Amit Langote writes: > > On Mon, Nov 14, 2022 at 11:57 PM Tom Lane wrote: > >> + * The new member is identified by the zero-based index of the List > >> + * element it should go into, and the bit number to be set therein. > > > The comment

Re: List of Bitmapset (was Re: ExecRTCheckPerms() and many prunable partitions)

2022-11-15 Thread Tom Lane
Amit Langote writes: > On Mon, Nov 14, 2022 at 11:57 PM Tom Lane wrote: >> + * The new member is identified by the zero-based index of the List >> + * element it should go into, and the bit number to be set therein. > The comment sounds a bit ambiguous, especially the ", and the bit > number

Re: List of Bitmapset (was Re: ExecRTCheckPerms() and many prunable partitions)

2022-11-15 Thread Tom Lane
Alvaro Herrera writes: > On 2022-Nov-14, Tom Lane wrote: >> For discussion's sake, here's my current version of that 0004 patch, >> rewritten to use list-of-bitmapset as the data structure. > I feel that there should be more commentary that explains what a > multi-bms is. Not sure where, maybe

Re: List of Bitmapset (was Re: ExecRTCheckPerms() and many prunable partitions)

2022-11-15 Thread Alvaro Herrera
On 2022-Nov-14, Tom Lane wrote: > For discussion's sake, here's my current version of that 0004 patch, > rewritten to use list-of-bitmapset as the data structure. I feel that there should be more commentary that explains what a multi-bms is. Not sure where, maybe just put it near the function

Re: List of Bitmapset (was Re: ExecRTCheckPerms() and many prunable partitions)

2022-11-14 Thread Amit Langote
On Mon, Nov 14, 2022 at 11:57 PM Tom Lane wrote: > Amit Langote writes: > > On Sat, Nov 12, 2022 at 1:46 AM Tom Lane wrote: > >> The main thing I was wondering about in connection with that > >> was whether to assume that there could be other future applications > >> of the logic to perform

List of Bitmapset (was Re: ExecRTCheckPerms() and many prunable partitions)

2022-11-14 Thread Tom Lane
[ I'm intentionally forking this off as a new thread, so as to not confuse the cfbot about what's the live patchset on the ExecRTCheckPerms thread. ] Amit Langote writes: > On Sat, Nov 12, 2022 at 1:46 AM Tom Lane wrote: >> The main thing I was wondering about in connection with that >> was