On Fri, Sep 25, 2020 at 1:53 PM Dilip Kumar wrote:
>
> On Fri, Sep 25, 2020 at 8:12 AM Amit Kapila wrote:
> >
> >
> > No that won't happen because we send this option to the server
> > (publisher in this case) only when version is >=14 and user has
> > specified this option. See the below check i
On Fri, Sep 25, 2020 at 8:12 AM Amit Kapila wrote:
>
> On Thu, Sep 24, 2020 at 6:33 PM Ashutosh Sharma wrote:
> >
> > Hi Amit,
> >
> > > Here, I think instead of using MySubscription->stream, we should use
> > > server/walrecv version number as we used at one place in tablesync.c.
> >
> > Should
On Fri, Sep 25, 2020 at 8:12 AM Amit Kapila wrote:
>
> On Thu, Sep 24, 2020 at 6:33 PM Ashutosh Sharma wrote:
> >
> > Hi Amit,
> >
> > > Here, I think instead of using MySubscription->stream, we should use
> > > server/walrecv version number as we used at one place in tablesync.c.
> >
> > Should
On Thu, Sep 24, 2020 at 6:33 PM Ashutosh Sharma wrote:
>
> Hi Amit,
>
> > Here, I think instead of using MySubscription->stream, we should use
> > server/walrecv version number as we used at one place in tablesync.c.
>
> Should subscribers be setting the LR protocol value based on what is
> the pu
On Fri, Sep 25, 2020 at 7:21 AM Dilip Kumar wrote:
>
> On Thu, Sep 24, 2020 at 5:31 PM Amit Kapila wrote:
> >
> > On Thu, Sep 24, 2020 at 5:11 PM Dilip Kumar wrote:
> > >
> > > On Thu, Sep 24, 2020 at 4:45 PM Amit Kapila
> > > wrote:
> > > >
> > > >
> > > > Have you checked what will function
On Thu, Sep 24, 2020 at 5:31 PM Amit Kapila wrote:
>
> On Thu, Sep 24, 2020 at 5:11 PM Dilip Kumar wrote:
> >
> > On Thu, Sep 24, 2020 at 4:45 PM Amit Kapila wrote:
> > >
> > >
> > > Have you checked what will function walrcv_server_version() will
> > > return? I was thinking that if we know tha
Hi Amit,
On Thu, Sep 24, 2020 at 11:55 AM Amit Kapila wrote:
>
> On Tue, Sep 22, 2020 at 5:15 PM Dilip Kumar wrote:
> >
> > On Tue, Sep 22, 2020 at 12:02 PM Amit Kapila
> > wrote:
> > >
> > >
> > > I am not sure if this suggestion makes it better than what is purposed
> > > by Dilip but I thin
On Thu, Sep 24, 2020 at 5:11 PM Dilip Kumar wrote:
>
> On Thu, Sep 24, 2020 at 4:45 PM Amit Kapila wrote:
> >
> >
> > Have you checked what will function walrcv_server_version() will
> > return? I was thinking that if we know that subscriber is connected to
> > Publisher version < 14 then we can
On Thu, Sep 24, 2020 at 4:45 PM Amit Kapila wrote:
>
> On Thu, Sep 24, 2020 at 4:31 PM Dilip Kumar wrote:
> >
> > On Thu, Sep 24, 2020 at 11:55 AM Amit Kapila
> > wrote:
> > >
> > > On Tue, Sep 22, 2020 at 5:15 PM Dilip Kumar wrote:
> > > >
> > > > On Tue, Sep 22, 2020 at 12:02 PM Amit Kapila
On Thu, Sep 24, 2020 at 4:31 PM Dilip Kumar wrote:
>
> On Thu, Sep 24, 2020 at 11:55 AM Amit Kapila wrote:
> >
> > On Tue, Sep 22, 2020 at 5:15 PM Dilip Kumar wrote:
> > >
> > > On Tue, Sep 22, 2020 at 12:02 PM Amit Kapila
> > > wrote:
> > > >
> > > >
> > > > I am not sure if this suggestion m
On Thu, Sep 24, 2020 at 11:55 AM Amit Kapila wrote:
>
> On Tue, Sep 22, 2020 at 5:15 PM Dilip Kumar wrote:
> >
> > On Tue, Sep 22, 2020 at 12:02 PM Amit Kapila
> > wrote:
> > >
> > >
> > > I am not sure if this suggestion makes it better than what is purposed
> > > by Dilip but I think we can d
On Tue, Sep 22, 2020 at 5:15 PM Dilip Kumar wrote:
>
> On Tue, Sep 22, 2020 at 12:02 PM Amit Kapila wrote:
> >
> >
> > I am not sure if this suggestion makes it better than what is purposed
> > by Dilip but I think we can declare them in define number order like
> > below:
> > #define LOGICALREP_
On Tue, Sep 22, 2020 at 12:02 PM Amit Kapila wrote:
>
> On Tue, Sep 22, 2020 at 8:34 AM Ashutosh Sharma wrote:
> >
> > On Mon, Sep 21, 2020 at 6:58 PM Amit Kapila wrote:
> > >
> > > On Mon, Sep 21, 2020 at 6:27 PM Ashutosh Sharma
> > > wrote:
> > > >
> > > > Thanks Dilip for the patch. AFAIU,
On Tue, Sep 22, 2020 at 12:22 PM Ashutosh Sharma wrote:
>
> On Tue, Sep 22, 2020 at 12:02 PM Amit Kapila wrote:
> >
> > On Tue, Sep 22, 2020 at 8:34 AM Ashutosh Sharma
> > wrote:
> > >
> > > On Mon, Sep 21, 2020 at 6:58 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Mon, Sep 21, 2020 at 6:27
On Tue, Sep 22, 2020 at 12:02 PM Amit Kapila wrote:
>
> On Tue, Sep 22, 2020 at 8:34 AM Ashutosh Sharma wrote:
> >
> > On Mon, Sep 21, 2020 at 6:58 PM Amit Kapila wrote:
> > >
> > > On Mon, Sep 21, 2020 at 6:27 PM Ashutosh Sharma
> > > wrote:
> > > >
> > > > Thanks Dilip for the patch. AFAIU,
On Tue, Sep 22, 2020 at 8:34 AM Ashutosh Sharma wrote:
>
> On Mon, Sep 21, 2020 at 6:58 PM Amit Kapila wrote:
> >
> > On Mon, Sep 21, 2020 at 6:27 PM Ashutosh Sharma
> > wrote:
> > >
> > > Thanks Dilip for the patch. AFAIU, the fix looks good. One small comment:
> > >
> >
> > Thanks Ashutosh an
On Mon, Sep 21, 2020 at 6:58 PM Amit Kapila wrote:
>
> On Mon, Sep 21, 2020 at 6:27 PM Ashutosh Sharma wrote:
> >
> > Thanks Dilip for the patch. AFAIU, the fix looks good. One small comment:
> >
>
> Thanks Ashutosh and Dilip for working on this. I'll look into it in a
> day or two.
>
Just a tho
On Mon, Sep 21, 2020 at 6:27 PM Ashutosh Sharma wrote:
>
> Thanks Dilip for the patch. AFAIU, the fix looks good. One small comment:
>
Thanks Ashutosh and Dilip for working on this. I'll look into it in a
day or two.
--
With Regards,
Amit Kapila.
On Mon, Sep 21, 2020 at 6:27 PM Ashutosh Sharma wrote:
>
> Thanks Dilip for the patch. AFAIU, the fix looks good. One small comment:
>
> In the error message we are still referring to the native protocol
> version number. Shouldn't it be replaced with the greatest protocol
> version number we supp
Thanks Dilip for the patch. AFAIU, the fix looks good. One small comment:
In the error message we are still referring to the native protocol
version number. Shouldn't it be replaced with the greatest protocol
version number we support now (i.e. LOGICALREP_PROTO_MAX_VERSION_NUM)?
- if (data-
On Mon, Sep 21, 2020 at 4:15 PM Dilip Kumar wrote:
>
> On Mon, Sep 21, 2020 at 3:26 PM Ashutosh Sharma wrote:
> >
> > Hi All,
> >
> > Today, while exploring logical replication in PostgreSQL, I noticed
> > that logical replication from PG version 13 and below to PG v14
> > (development version) i
On Mon, Sep 21, 2020 at 3:26 PM Ashutosh Sharma wrote:
>
> Hi All,
>
> Today, while exploring logical replication in PostgreSQL, I noticed
> that logical replication from PG version 13 and below to PG v14
> (development version) is not working. It has stopped working from the
> following git commi
On Mon, Sep 21, 2020 at 3:26 PM Ashutosh Sharma wrote:
>
> commit 464824323e57dc4b397e8b05854d779908b55304
> Author: Amit Kapila
> Date: Thu Sep 3 07:54:07 2020 +0530
>
> Above select query produces no result. When this experiment is
> performed below the mentioned git commit, it works fine.
>
Hi All,
Today, while exploring logical replication in PostgreSQL, I noticed
that logical replication from PG version 13 and below to PG v14
(development version) is not working. It has stopped working from the
following git commit onwards:
commit 464824323e57dc4b397e8b05854d779908b55304
Author: A
24 matches
Mail list logo
