Re: Meson far from ready on Windows

2024-08-18 Thread walther
Andres Freund: That's not necessarily true. The nix package manager and thus NixOS track all dependencies for a piece of software. If any of the dependencies are updated, all dependents are rebuilt, too. So the security concern doesn't apply here. There is a "static overlay", which builds ever

Re: Meson far from ready on Windows

2024-07-24 Thread Dave Page
On Sat, 20 Jul 2024 at 21:56, Andres Freund wrote: > Hi, > > On 2024-07-17 09:49:47 -0700, Andres Freund wrote: > > On 2024-07-16 15:53:45 -0500, Tristan Partin wrote: > > > Other than that, it looks pretty solid. > > > > Thanks for looking! I'm thinking of pushing the first few patches > soon-i

Re: Meson far from ready on Windows

2024-07-20 Thread Andres Freund
Hi, On 2024-07-17 09:49:47 -0700, Andres Freund wrote: > On 2024-07-16 15:53:45 -0500, Tristan Partin wrote: > > Other than that, it looks pretty solid. > > Thanks for looking! I'm thinking of pushing the first few patches soon-ish. > > I'm debating between going for 17 + HEAD or also applying

Re: Meson far from ready on Windows

2024-07-17 Thread Andres Freund
Hi, On 2024-07-16 15:53:45 -0500, Tristan Partin wrote: > Other than that, it looks pretty solid. Thanks for looking! I'm thinking of pushing the first few patches soon-ish. I'm debating between going for 17 + HEAD or also applying it to 16, to keep the trees more similar. > Looks like we cou

Re: Meson far from ready on Windows

2024-07-16 Thread Tristan Partin
From 9f7c96dfab4d807e668c9d32b44db5f4ff122e15 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Mon, 8 Jul 2024 15:55:56 -0700 Subject: [PATCH v2 02/10] Don't define HAVE_[GSSAPI_]GSSAPI_EXT_H The check for gssapi_ext.h was added in f7431bca8b0. As we require gssapi_ext.h to be present, there's

Re: Meson far from ready on Windows

2024-07-08 Thread Andres Freund
Hi, I've been hacking on addressing some of the complaints (after having been off-work in a somewhat unplanned way for most of the last two weeks). With some already opened and soon-to-be-proposed PRs to Dave's winbuild and the attached changes I think the concerns can largely be addressed. Her

Re: Meson far from ready on Windows

2024-06-25 Thread Dave Page
Hi On Tue, 25 Jun 2024 at 12:39, Andres Freund wrote: > Hi, > > On 2024-06-25 11:54:56 +0100, Dave Page wrote: > > https://github.com/dpage/winpgbuild proves that the hacks above are not > > required *if* you build the dependencies in the recommended way for use > > with MSVC++ (where documented

Re: Meson far from ready on Windows

2024-06-25 Thread Andres Freund
Hi, On 2024-06-25 11:54:56 +0100, Dave Page wrote: > https://github.com/dpage/winpgbuild proves that the hacks above are not > required *if* you build the dependencies in the recommended way for use > with MSVC++ (where documented), otherwise just native Windows. Partially it just means that some

Re: Meson far from ready on Windows

2024-06-25 Thread Andres Freund
Hi, On 2024-06-24 09:44:57 +0100, Dave Page wrote: > To address Andres' concerns around mis-detection of dependencies, or other > oddities such as required compiler flags not being included, I would > suggest that a) that's happened very rarely, if ever, in the past, and b) > we can always spit ou

Re: Meson far from ready on Windows

2024-06-25 Thread Dave Page
On Tue, 25 Jun 2024 at 11:41, Andres Freund wrote: > Hi, > > On 2024-06-21 12:20:49 +0100, Dave Page wrote: > > > I'm confused - the old build system wasn't flexible around this stuff > *at > > > all*. Everyone had to patch it to get dependencies to work, unless you > > > chose > > > exactly the

Re: Meson far from ready on Windows

2024-06-25 Thread Andres Freund
Hi, On 2024-06-21 12:20:49 +0100, Dave Page wrote: > > I'm confused - the old build system wasn't flexible around this stuff *at > > all*. Everyone had to patch it to get dependencies to work, unless you > > chose > > exactly the right source to download from - which was often not documented > > o

Re: Meson far from ready on Windows

2024-06-24 Thread Dave Page
On Sat, 22 Jun 2024 at 17:35, Andres Freund wrote: > Hi, > > On 2024-06-21 15:36:56 +0100, Dave Page wrote: > > For giggles, I took a crack at doing that, manually creating .pc files > for > > everything I've been working with so far. > > Cool! > > > > It seems to work as expected, except that un

Re: Meson far from ready on Windows

2024-06-24 Thread Andres Freund
Hi, On 2024-06-24 09:54:51 +0100, Dave Page wrote: > > The old system was a major bottleneck. For one, there was no way to run all > > tests. And even the tests that one could run, would run serially, leading > > to > > exceedingly long tests times. While that could partially be addressed by > > h

Re: Meson far from ready on Windows

2024-06-24 Thread Dave Page
Hi On Sat, 22 Jun 2024 at 17:32, Andres Freund wrote: > > I don't think it's unreasonable to not support static linking, but I take > > your point. > > Separately from this thread: ISTM that on windows it'd be quite beneficial > to > link a few things statically, given how annoying dealing with

Re: Meson far from ready on Windows

2024-06-24 Thread Dave Page
Hi Tristan, On Fri, 21 Jun 2024 at 18:16, Tristan Partin wrote: > > Hey Dave, > > I'm a maintainer for Meson, and am happy to help you in any way that > I reasonably can. > Thank you! > > Let's start with the state of Windows support in Meson. If I were to > rank Meson support for platforms, I

Re: Meson far from ready on Windows

2024-06-23 Thread Andrew Dunstan
On 2024-06-21 Fr 11:15 AM, Robert Haas wrote: As a practical matter, I don't think MSVC is coming back. The buildfarm was already changed over to use meson, and it would be pretty disruptive to try to re-add buildfarm coverage for a resurrected MSVC on the eve of beta2. I think we should focus o

Re: Meson far from ready on Windows

2024-06-22 Thread Andres Freund
Hi, On June 22, 2024 7:32:01 PM GMT+02:00, walt...@technowledgy.de wrote: >Andres Freund: >> FWIW, dynamic linking has a noticeable overhead on other platforms too. A >> non-dependencies-enabled postgres can do about 2x the connections-per-second >> than a fully kitted out postgres can (basically

Re: Meson far from ready on Windows

2024-06-22 Thread walther
Andres Freund: FWIW, dynamic linking has a noticeable overhead on other platforms too. A non-dependencies-enabled postgres can do about 2x the connections-per-second than a fully kitted out postgres can (basically due to more memory mapping metadata being copied). But on windows the overhead is

Re: Meson far from ready on Windows

2024-06-22 Thread Andres Freund
Hi, On 2024-06-21 15:36:56 +0100, Dave Page wrote: > For giggles, I took a crack at doing that, manually creating .pc files for > everything I've been working with so far. Cool! > It seems to work as expected, except that unlike everything else libintl is > detected entirely based on whether th

Re: Meson far from ready on Windows

2024-06-22 Thread Andres Freund
Hi, On 2024-06-21 12:20:49 +0100, Dave Page wrote: > On Thu, 20 Jun 2024 at 21:58, Andres Freund wrote: > That is precisely what https://github.com/dpage/winpgbuild/ was intended > for - and it works well for PG <= 16. If we develop it into that - I'd be happy. I mostly want to be able to do aut

Re: Meson far from ready on Windows

2024-06-21 Thread Tristan Partin
On Fri Jun 21, 2024 at 10:46 AM CDT, Dave Page wrote: On Fri, 21 Jun 2024 at 16:15, Robert Haas wrote: > As a practical matter, I don't think MSVC is coming back. The > buildfarm was already changed over to use meson, and it would be > pretty disruptive to try to re-add buildfarm coverage for a

Re: Meson far from ready on Windows

2024-06-21 Thread Dave Page
On Fri, 21 Jun 2024 at 16:15, Robert Haas wrote: > On Fri, Jun 21, 2024 at 7:21 AM Dave Page wrote: > > My assumption all along was that Meson would replace autoconf etc. > before anything happened with MSVC, precisely because that's the type of > environment all the Postgres devs work in primar

Re: Meson far from ready on Windows

2024-06-21 Thread Robert Haas
On Fri, Jun 21, 2024 at 7:21 AM Dave Page wrote: > My assumption all along was that Meson would replace autoconf etc. before > anything happened with MSVC, precisely because that's the type of environment > all the Postgres devs work in primarily. Instead we seem to have taken what I > think is

Re: Meson far from ready on Windows

2024-06-21 Thread Dave Page
Hi On Fri, 21 Jun 2024 at 12:20, Dave Page wrote: > > We/I *could* add cmake/pc file generation to that tool, which would make > things work nicely with PostgreSQL 17 of course. > For giggles, I took a crack at doing that, manually creating .pc files for everything I've been working with so far

Re: Meson far from ready on Windows

2024-06-21 Thread Dave Page
Hi On Thu, 20 Jun 2024 at 21:58, Andres Freund wrote: > > > I don't think requiring or expecting vcpkg or conan is reasonable at all, > > for a number of reasons: > > > > - Neither supports all the dependencies at present. > > - There are real supply chain verification concerns for vendors. > >

Re: Meson far from ready on Windows

2024-06-20 Thread Andres Freund
Hi, On 2024-06-19 14:47:50 +0100, Dave Page wrote: > > I'm *NOT* sure that vcpkg is the way to go, fwiw. It does seem > > advantageous to > > use one of the toolkits thats commonly built for building dependencies on > > windows, which seems to mean vcpkg or conan. > > > > I don't think requiring

Re: Meson far from ready on Windows

2024-06-19 Thread Dave Page
Hi On Tue, 18 Jun 2024 at 17:08, Andres Freund wrote: > > None of the dependencies include cmake files for distribution on Windows, > > so there are no additional files to tell meson to search for. The same > > applies to pkgconfig files, which is why the EDB team had to manually > craft > > the

Re: Meson far from ready on Windows

2024-06-18 Thread Andres Freund
Hi, On 2024-06-18 15:54:27 +0100, Dave Page wrote: > On Tue, 18 Jun 2024 at 15:38, Andres Freund wrote: > > Do you have logs for those failures? > > > > Sure - https://developer.pgadmin.org/~dpage/build-logs.zip. Those are all > without any modifications to %LIB% or %INCLUDE%. Thanks. > > I t

Re: Meson far from ready on Windows

2024-06-18 Thread Dave Page
Hi On Tue, 18 Jun 2024 at 15:38, Andres Freund wrote: > Hi, > > On 2024-06-18 14:53:53 +0100, Dave Page wrote: > > My next task was to extend that to support PostgreSQL 17 and beyond, > which > > is where I started to run into problems. I've attempted builds using > Meson > > with each of the de

Re: Meson far from ready on Windows

2024-06-18 Thread Andres Freund
Hi, On 2024-06-18 14:53:53 +0100, Dave Page wrote: > My next task was to extend that to support PostgreSQL 17 and beyond, which > is where I started to run into problems. I've attempted builds using Meson > with each of the dependencies defined in the old-style config.pl, both with > and without m

Meson far from ready on Windows

2024-06-18 Thread Dave Page
Hi Further to my previous report [1] about zlib detection not working with Meson on Windows, I found it's similarly or entirely broken for the majority of other dependencies, none of which are tested on the buildfarm as far as I can see. For convenience, I've put together a number of Github actio