Re: Minor comment update in execPartition.c

2018-04-24 Thread Etsuro Fujita
(2018/04/25 11:05), Alvaro Herrera wrote: Amit Langote wrote: I think we should remove the words "if not already done" from that comment because 1) that function is called if the partition wasn't already initialized and 2) that function assumes that. Attached is a small patch for removing the

Re: Minor comment update in execPartition.c

2018-04-24 Thread Alvaro Herrera
Amit Langote wrote: > > I think we should remove the words "if not already done" from that > > comment because 1) that function is called if the partition wasn't > > already initialized and 2) that function assumes that. Attached is a > > small patch for removing the words. > > Thanks, sounds

Re: Minor comment update in execPartition.c

2018-04-24 Thread Amit Langote
Fujita-san, On 2018/04/24 20:14, Etsuro Fujita wrote: > Hi, > > Here is a comment for ExecInitPartitionInfo: > > 296 * ExecInitPartitionInfo > 297 * Initialize ResultRelInfo and other information for a > partition if not > 298 * already done > > I think we should remove the

Minor comment update in execPartition.c

2018-04-24 Thread Etsuro Fujita
Hi, Here is a comment for ExecInitPartitionInfo: 296 * ExecInitPartitionInfo 297 * Initialize ResultRelInfo and other information for a partition if not 298 * already done I think we should remove the words "if not already done" from that comment because 1) that function is