Re: Misleading comment in pg_upgrade.c

2019-12-21 Thread Julien Rouhaud
Le sam. 21 déc. 2019 à 18:46, Bruce Momjian a écrit : > On Thu, Dec 5, 2019 at 11:45:09PM +0100, Daniel Gustafsson wrote: > > > On 5 Dec 2019, at 10:17, Julien Rouhaud wrote: > > > > > While reading pg_upgrade code to restore the objects on the new > > > cluster, I noticed that 5b570d771b8 didn

Re: Misleading comment in pg_upgrade.c

2019-12-21 Thread Bruce Momjian
On Thu, Dec 5, 2019 at 11:45:09PM +0100, Daniel Gustafsson wrote: > > On 5 Dec 2019, at 10:17, Julien Rouhaud wrote: > > > While reading pg_upgrade code to restore the objects on the new > > cluster, I noticed that 5b570d771b8 didn't adjust the database name in > > the comments explaining the re

Re: Misleading comment in pg_upgrade.c

2019-12-05 Thread Daniel Gustafsson
> On 5 Dec 2019, at 10:17, Julien Rouhaud wrote: > While reading pg_upgrade code to restore the objects on the new > cluster, I noticed that 5b570d771b8 didn't adjust the database name in > the comments explaining the requirements for an extra "--clean" for > template1 and postgres databases. Wh

Misleading comment in pg_upgrade.c

2019-12-05 Thread Julien Rouhaud
Hello, While reading pg_upgrade code to restore the objects on the new cluster, I noticed that 5b570d771b8 didn't adjust the database name in the comments explaining the requirements for an extra "--clean" for template1 and postgres databases. While it's true that both databases will already exis