Re: Missing generated column in ALTER TABLE ADD COLUMN doc

2019-06-10 Thread Masahiko Sawada
On Tue, Jun 11, 2019 at 1:02 PM Michael Paquier wrote: > > On Mon, Jun 10, 2019 at 06:09:53PM +0900, Masahiko Sawada wrote: > > We already have the following line in action part but you mean we need > > an extra line for that? > > > >ADD [ COLUMN ] [ IF NOT EXISTS ] column_name data_type [

Re: Missing generated column in ALTER TABLE ADD COLUMN doc

2019-06-10 Thread Michael Paquier
On Mon, Jun 10, 2019 at 06:09:53PM +0900, Masahiko Sawada wrote: > We already have the following line in action part but you mean we need > an extra line for that? > >ADD [ COLUMN ] [ IF NOT EXISTS ] column_name data_type [ COLLATE > collation ] [ column_constraint [ ... ] ] I was looking at

Re: Missing generated column in ALTER TABLE ADD COLUMN doc

2019-06-10 Thread Masahiko Sawada
On Mon, Jun 10, 2019 at 5:05 PM Michael Paquier wrote: > > On Fri, Jun 07, 2019 at 06:07:34PM +0900, Masahiko Sawada wrote: > > We support ALTER TABLE ADD COLUMN .. GENERATED ALWAYS AS .. but the > > doc is missing it. Attached small patch fixes this. > > Your patch updates the section related to

Re: Missing generated column in ALTER TABLE ADD COLUMN doc

2019-06-10 Thread Michael Paquier
On Fri, Jun 07, 2019 at 06:07:34PM +0900, Masahiko Sawada wrote: > We support ALTER TABLE ADD COLUMN .. GENERATED ALWAYS AS .. but the > doc is missing it. Attached small patch fixes this. Your patch updates the section related to constraint_name. Don't you need an extra line for the "action"

Missing generated column in ALTER TABLE ADD COLUMN doc

2019-06-07 Thread Masahiko Sawada
Hi, We support ALTER TABLE ADD COLUMN .. GENERATED ALWAYS AS .. but the doc is missing it. Attached small patch fixes this. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center doc_alter_column_add_generated_column.patch Description: Binary