Re: NLS doesn't work for pg_combinebackup

2024-04-09 Thread Kyotaro Horiguchi
At Tue, 9 Apr 2024 15:00:27 +0900, Michael Paquier wrote in > I've checked the whole tree, and the two you are pointing at are the > only incorrect paths. So applied, thanks! Thank you for cross-checking and committing! regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: NLS doesn't work for pg_combinebackup

2024-04-08 Thread Michael Paquier
On Mon, Apr 08, 2024 at 04:31:05PM +0900, Kyotaro Horiguchi wrote: >> diff --git a/src/bin/pg_combinebackup/pg_combinebackup.c >> b/src/bin/pg_combinebackup/pg_combinebackup.c >> index 1b07ca3fb6..2788c78fdd 100644 >> +++ b/src/bin/pg_combinebackup/pg_combinebackup.c > +++ b/src/bin/pg_walsummary/

Re: NLS doesn't work for pg_combinebackup

2024-04-08 Thread Michael Paquier
On Mon, Apr 08, 2024 at 04:27:02PM +0900, Kyotaro Horiguchi wrote: > I noticed that NLS doesn't work for pg_combinebackup. The cause is > that the tool forgets to call set_pglocale_pgservice(). > > This issue is fixed by the following chage. Indeed. Good catch. -- Michae

Re: NLS doesn't work for pg_combinebackup

2024-04-08 Thread Kyotaro Horiguchi
At Mon, 08 Apr 2024 16:27:02 +0900 (JST), Kyotaro Horiguchi wrote in > Hello. > > I noticed that NLS doesn't work for pg_combinebackup. The cause is > that the tool forgets to call set_pglocale_pgservice(). > > This issue is fixed by the following chage. &g

NLS doesn't work for pg_combinebackup

2024-04-08 Thread Kyotaro Horiguchi
Hello. I noticed that NLS doesn't work for pg_combinebackup. The cause is that the tool forgets to call set_pglocale_pgservice(). This issue is fixed by the following chage. diff --git a/src/bin/pg_combinebackup/pg_combinebackup.c b/src/bin/pg_combinebackup/pg_combinebackup.c index 1b07c