Re: Naming of the different stats systems / "stats collector"

2022-04-03 Thread Andres Freund
Hi, On 2022-03-08 20:17:06 -0700, David G. Johnston wrote: > On Tue, Mar 8, 2022 at 7:32 PM Andres Freund wrote: > > > we need a descriptive term / shorthand that > > describes the type of statistics we currently send to the stats collector. > > > > "cumulative stats subsystem"? > > > > > I'm

Re: Naming of the different stats systems / "stats collector"

2022-03-08 Thread David G. Johnston
On Tue, Mar 8, 2022 at 7:32 PM Andres Freund wrote: > we need a descriptive term / shorthand that > describes the type of statistics we currently send to the stats collector. > > "cumulative stats subsystem"? > > I'm growing fond of "cumulative". It is more precise (and restrictive) than

Re: Naming of the different stats systems / "stats collector"

2022-03-08 Thread Andres Freund
Hi, On 2022-03-08 19:13:45 -0700, David G. Johnston wrote: > On Tue, Mar 8, 2022 at 6:50 PM Andres Freund wrote: > > > On 2022-03-08 15:55:04 -0700, David G. Johnston wrote: > > > On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote: > > > > One thing I'm not yet happy around the shared memory

Re: Naming of the different stats systems / "stats collector"

2022-03-08 Thread David G. Johnston
On Tue, Mar 8, 2022 at 6:50 PM Andres Freund wrote: > On 2022-03-08 15:55:04 -0700, David G. Johnston wrote: > > On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote: > > > One thing I'm not yet happy around the shared memory stats patch is > > > naming. Currently a lot of comments say things

Re: Naming of the different stats systems / "stats collector"

2022-03-08 Thread Andres Freund
On 2022-03-08 15:55:04 -0700, David G. Johnston wrote: > On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote: > > One thing I'm not yet happy around the shared memory stats patch is > > naming. Currently a lot of comments say things like: > > > > * [...] We convert to > > * microseconds in

Re: Naming of the different stats systems / "stats collector"

2022-03-08 Thread Kyotaro Horiguchi
At Tue, 8 Mar 2022 15:55:04 -0700, "David G. Johnston" wrote in > On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote: > > the immediate question for the patch is what to replace "collector" with. > > > > > Not really following the broader context here so this came out of nowhere > for me.

Re: Naming of the different stats systems / "stats collector"

2022-03-08 Thread David G. Johnston
On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote: > > One thing I'm not yet happy around the shared memory stats patch is > naming. Currently a lot of comments say things like: > > * [...] We convert to > * microseconds in PgStat_Counter format when transmitting to the > collector. > > or

Naming of the different stats systems / "stats collector"

2022-03-08 Thread Andres Freund
Hi, One thing I'm not yet happy around the shared memory stats patch is naming. Currently a lot of comments say things like: * [...] We convert to * microseconds in PgStat_Counter format when transmitting to the collector. or # - Query and Index Statistics Collector - or /* -- *