On Mon, Jul 1, 2024 at 6:01 PM Zhijie Hou (Fujitsu)
wrote:
>
> Thanks! I am attaching another patch to modify the release note as discussed.
>
Pushed.
--
With Regards,
Amit Kapila.
On Monday, July 1, 2024 6:45 PM Amit Kapila wrote:
>
> On Thu, Jun 27, 2024 at 7:14 AM Masahiko Sawada
> wrote:
> >
> > On Wed, Jun 26, 2024 at 6:15 PM Zhijie Hou (Fujitsu)
> > wrote:
> >
> > Thank you for updating the patch. The v2 patch looks good to me.
> >
>
> Pushed.
Thanks! I am
On Thu, Jun 27, 2024 at 7:14 AM Masahiko Sawada wrote:
>
> On Wed, Jun 26, 2024 at 6:15 PM Zhijie Hou (Fujitsu)
> wrote:
>
> Thank you for updating the patch. The v2 patch looks good to me.
>
Pushed.
--
With Regards,
Amit Kapila.
On Wed, Jun 26, 2024 at 6:15 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Wednesday, June 26, 2024 12:49 PM Bertrand Drouvot
> wrote:
> >
> > Hi,
> >
> > On Wed, Jun 26, 2024 at 04:17:45AM +, Zhijie Hou (Fujitsu) wrote:
> > > On Wednesday, June 26, 2024 9:40 AM Masahiko Sawada
> > wrote:
> > > >
On 21.06.24 17:37, Bruce Momjian wrote:
The release notes have this item:
Allow specification of physical standbys that must be synchronized
before they are visible to subscribers (Hou Zhijie, Shveta Malik)
The new server variable is standby_slot_names.
Is
On Wed, Jun 26, 2024 at 6:00 PM Bertrand Drouvot
wrote:
>
> On Wed, Jun 26, 2024 at 09:15:48AM +, Zhijie Hou (Fujitsu) wrote:
> > Renamed these to the names suggested by Amit.
> >
> > Attach the v2 patch set which addressed above and removed
> > the changes in release-17.sgml according to the
Hi,
On Wed, Jun 26, 2024 at 09:15:48AM +, Zhijie Hou (Fujitsu) wrote:
> Renamed these to the names suggested by Amit.
>
> Attach the v2 patch set which addressed above and removed
> the changes in release-17.sgml according to the comment from Amit.
>
Thanks! LGTM.
Regards,
--
Bertrand
On Wednesday, June 26, 2024 12:49 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Wed, Jun 26, 2024 at 04:17:45AM +, Zhijie Hou (Fujitsu) wrote:
> > On Wednesday, June 26, 2024 9:40 AM Masahiko Sawada
> wrote:
> > >
> > > On Tue, Jun 25, 2024 at 5:32 PM Amit Kapila
> > >
> > > wrote:
> > > >
>
Hi,
On Wed, Jun 26, 2024 at 11:39:45AM +0530, Amit Kapila wrote:
> On Wed, Jun 26, 2024 at 10:19 AM Bertrand Drouvot
> wrote:
> >
> >
> > 2
> >
> > Should we rename StandbySlotNamesConfigData too?
> >
>
> How about SyncStandbySlotsConfigData?
>
> > 3
> >
> > Should we rename
On Wed, Jun 26, 2024 at 11:39:45AM +0530, Amit Kapila wrote:
> --- a/doc/src/sgml/release-17.sgml
> +++ b/doc/src/sgml/release-17.sgml
> @@ -1325,7 +1325,7 @@ Author: Michael Paquier
>
>
On Wed, Jun 26, 2024 at 10:19 AM Bertrand Drouvot
wrote:
>
>
> 2
>
> Should we rename StandbySlotNamesConfigData too?
>
How about SyncStandbySlotsConfigData?
> 3
>
> Should we rename SlotExistsInStandbySlotNames too?
>
Similarly SlotExistsInSyncStandbySlots?
> 4
>
> Should we
Hi,
On Wed, Jun 26, 2024 at 04:17:45AM +, Zhijie Hou (Fujitsu) wrote:
> On Wednesday, June 26, 2024 9:40 AM Masahiko Sawada
> wrote:
> >
> > On Tue, Jun 25, 2024 at 5:32 PM Amit Kapila
> > wrote:
> > >
> > > I feel synchronized better indicates the purpose because we ensure
> > > such
On Wednesday, June 26, 2024 9:40 AM Masahiko Sawada
wrote:
>
> On Tue, Jun 25, 2024 at 5:32 PM Amit Kapila
> wrote:
> >
> > On Tue, Jun 25, 2024 at 12:30 PM Masahiko Sawada
> wrote:
> > >
> > > On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila
> wrote:
> > > >
> > >
> > > > So, my
> > > >
On Tue, Jun 25, 2024 at 5:32 PM Amit Kapila wrote:
>
> On Tue, Jun 25, 2024 at 12:30 PM Masahiko Sawada
> wrote:
> >
> > On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila wrote:
> > >
> >
> > > So, my
> > > preference is in order as follows: synchronized_standby_slots,
> > > wait_for_standby_slots,
On Tue, Jun 25, 2024 at 02:02:09PM +0530, Amit Kapila wrote:
> On Tue, Jun 25, 2024 at 12:30 PM Masahiko Sawada
> wrote:
>> On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila wrote:
>> > So, my
>> > preference is in order as follows: synchronized_standby_slots,
>> > wait_for_standby_slots,
On Tue, Jun 25, 2024 at 12:30 PM Masahiko Sawada wrote:
>
> On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila wrote:
> >
>
> > So, my
> > preference is in order as follows: synchronized_standby_slots,
> > wait_for_standby_slots, logical_replication_wait_slots,
> >
On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila wrote:
>
> On Tue, Jun 25, 2024 at 8:20 AM Masahiko Sawada wrote:
> >
> > On Tue, Jun 25, 2024 at 11:21 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > I agree the current name seems too generic and the suggested '
> > > synchronized_standby_slots '
>
Hi,
On Tue, Jun 25, 2024 at 10:24:41AM +0530, Amit Kapila wrote:
> On Tue, Jun 25, 2024 at 8:20 AM Masahiko Sawada wrote:
> >
> > On Tue, Jun 25, 2024 at 11:21 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > I agree the current name seems too generic and the suggested '
> > >
On Tue, Jun 25, 2024 at 8:20 AM Masahiko Sawada wrote:
>
> On Tue, Jun 25, 2024 at 11:21 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > I agree the current name seems too generic and the suggested '
> > synchronized_standby_slots '
> > is better than the current one.
> >
> > Some other ideas could
On Tue, Jun 25, 2024 at 11:21 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Saturday, June 22, 2024 5:47 PM Amit Kapila
> wrote:
> >
> > On Sat, Jun 22, 2024 at 1:49 AM Nathan Bossart
> > wrote:
> > >
> > > On Fri, Jun 21, 2024 at 03:50:00PM -0400, Tom Lane wrote:
> > > > Allow specification of
On Saturday, June 22, 2024 5:47 PM Amit Kapila wrote:
>
> On Sat, Jun 22, 2024 at 1:49 AM Nathan Bossart
> wrote:
> >
> > On Fri, Jun 21, 2024 at 03:50:00PM -0400, Tom Lane wrote:
> > > Allow specification of physical standbys that must be
> > > synchronized before they are visible to
Bruce Momjian writes:
> FYI, changing this GUC name could force an initdb because
> postgresql.conf would have the old name and removing the comment to
> change it would cause an error. Therefore, we should change it ASAP.
That's not reason for a forced initdb IMO. It's easily fixed by
hand.
On Sat, Jun 22, 2024 at 03:17:03PM +0530, Amit Kapila wrote:
> On Sat, Jun 22, 2024 at 1:49 AM Nathan Bossart
> wrote:
> >
> > On Fri, Jun 21, 2024 at 03:50:00PM -0400, Tom Lane wrote:
> > > Allow specification of physical standbys that must be synchronized
> > > before they are visible
On Sat, Jun 22, 2024 at 1:49 AM Nathan Bossart wrote:
>
> On Fri, Jun 21, 2024 at 03:50:00PM -0400, Tom Lane wrote:
> > Allow specification of physical standbys that must be synchronized
> > before they are visible to subscribers (Hou Zhijie, Shveta Malik)
> >
> > it seems like the name
On Sat, Jun 22, 2024 at 1:49 AM Nathan Bossart wrote:
>
> On Fri, Jun 21, 2024 at 03:50:00PM -0400, Tom Lane wrote:
> > Allow specification of physical standbys that must be synchronized
> > before they are visible to subscribers (Hou Zhijie, Shveta Malik)
> >
> > it seems like the name
On Fri, Jun 21, 2024 at 03:50:00PM -0400, Tom Lane wrote:
> Allow specification of physical standbys that must be synchronized
> before they are visible to subscribers (Hou Zhijie, Shveta Malik)
>
> it seems like the name ought to have some connection to
> synchronization. Perhaps
Thanks Tom Lane. You are more insightful.
Regards,
Ikram
On Sat, Jun 22, 2024 at 12:50 AM Tom Lane wrote:
> Muhammad Ikram writes:
> > A humble input, as on primary we have #primary_slot_name = '' then
> should
> > not it be okay to have standby_slot_names or standby_slot_name ? It seems
> >
Muhammad Ikram writes:
> A humble input, as on primary we have #primary_slot_name = '' then should
> not it be okay to have standby_slot_names or standby_slot_name ? It seems
> consistent with the Guc on primary.
> Another suggestion is *standby_replication_slots*.
IIUC, Bruce's complaint is
Hi,
A humble input, as on primary we have #primary_slot_name = '' then should
not it be okay to have standby_slot_names or standby_slot_name ? It seems
consistent with the Guc on primary.
Another suggestion is *standby_replication_slots*.
Regards,
Muhammad Ikram
Bitnine Global.
On Fri, Jun
On Fri, Jun 21, 2024 at 11:37:54AM -0400, Bruce Momjian wrote:
> The release notes have this item:
>
> Allow specification of physical standbys that must be synchronized
> before they are visible to subscribers (Hou Zhijie, Shveta Malik)
>
> The new server variable is
The release notes have this item:
Allow specification of physical standbys that must be synchronized
before they are visible to subscribers (Hou Zhijie, Shveta Malik)
The new server variable is standby_slot_names.
Is standby_slot_names an accurate name for this GUC? It
31 matches
Mail list logo
