Re: Non-configure build of thread_test has been broken for awhile

2020-10-26 Thread Bruce Momjian
On Tue, Oct 20, 2020 at 12:25:48PM -0400, Tom Lane wrote: > Alvaro Herrera writes: > > On 2020-Oct-18, Tom Lane wrote: > >> It doesn't really seem sane to me to support two different build > >> environments for thread_test, especially when one of them is so > >> little-used that it can be broken

Re: Non-configure build of thread_test has been broken for awhile

2020-10-20 Thread Tom Lane
Alvaro Herrera writes: > On 2020-Oct-18, Tom Lane wrote: >> It doesn't really seem sane to me to support two different build >> environments for thread_test, especially when one of them is so >> little-used that it can be broken for years before we notice. >> So I'd be inclined to rip out the

Re: Non-configure build of thread_test has been broken for awhile

2020-10-19 Thread Alvaro Herrera
On 2020-Oct-18, Tom Lane wrote: > It doesn't really seem sane to me to support two different build > environments for thread_test, especially when one of them is so > little-used that it can be broken for years before we notice. > So I'd be inclined to rip out the Makefile and just consider >

Non-configure build of thread_test has been broken for awhile

2020-10-18 Thread Tom Lane
If you go into src/test/thread/ and type "make", you get a bunch of "undefined reference to `pg_fprintf'" failures. That's because thread_test.c #include's postgres.h but the Makefile doesn't bother to link it with libpgport, arguing (falsely) that that might not exist yet. Presumably, this has