Re: Notify downstream to discard the streamed transaction which was aborted due to crash.

2023-01-07 Thread Amit Kapila
On Fri, Jan 6, 2023 at 11:18 AM Dilip Kumar wrote: > > > > > To fix it, One idea is to send a stream abort message when we are cleaning > > up > > crashed transaction on publisher(e.g. in ReorderBufferAbortOld()). And here > > is > > a tiny patch which changes the same. I have confirmed that

Re: Notify downstream to discard the streamed transaction which was aborted due to crash.

2023-01-05 Thread Dilip Kumar
On Fri, Jan 6, 2023 at 9:25 AM houzj.f...@fujitsu.com wrote: > > Hi, > > When developing another feature, I find an existing bug which was reported > from Dilip[1]. > > Currently, it's possible that we only send a streaming block without sending a > end of stream message(stream abort) when

RE: Notify downstream to discard the streamed transaction which was aborted due to crash.

2023-01-05 Thread houzj.f...@fujitsu.com
On Friday, January 6, 2023 1:15 PM Amit Kapila wrote: > > On Fri, Jan 6, 2023 at 9:25 AM houzj.f...@fujitsu.com > wrote: > > > > > > To fix it, One idea is to send a stream abort message when we are > > cleaning up crashed transaction on publisher(e.g. in > > ReorderBufferAbortOld()). And here

Re: Notify downstream to discard the streamed transaction which was aborted due to crash.

2023-01-05 Thread Amit Kapila
On Fri, Jan 6, 2023 at 9:25 AM houzj.f...@fujitsu.com wrote: > > > To fix it, One idea is to send a stream abort message when we are cleaning up > crashed transaction on publisher(e.g. in ReorderBufferAbortOld()). And here is > a tiny patch which changes the same. I have confirmed that the bug is

Notify downstream to discard the streamed transaction which was aborted due to crash.

2023-01-05 Thread houzj.f...@fujitsu.com
Hi, When developing another feature, I find an existing bug which was reported from Dilip[1]. Currently, it's possible that we only send a streaming block without sending a end of stream message(stream abort) when decoding and streaming a transaction that was aborted due to crash because we