On Thu, Jan 20, 2022 at 12:00:56PM +0900, Kyotaro Horiguchi wrote:
> This is that. I think this is a separate issue from the actual
> bug. This is applicable at least back to 9.6 and I think this should
> be applied back to all supported versions to avoid future backptach
> conflicts.
Looks fine e
On Thu, Jan 20, 2022 at 12:00:56PM +0900, Kyotaro Horiguchi wrote:
> This is that. I think this is a separate issue from the actual
> bug. This is applicable at least back to 9.6 and I think this should
> be applied back to all supported versions to avoid future backptach
> conflicts.
Thanks. I'l
At Tue, 18 Jan 2022 13:48:11 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Tue, 18 Jan 2022 10:43:55 +0900, Michael Paquier
> wrote in
> > On Sun, Jan 16, 2022 at 11:01:25PM -0500, Tom Lane wrote:
> > > Isn't that a very bad way to write "i = j + 1"?
> > >
> > > I agree with Horiguchi-san tha
At Tue, 18 Jan 2022 10:43:55 +0900, Michael Paquier wrote
in
> On Sun, Jan 16, 2022 at 11:01:25PM -0500, Tom Lane wrote:
> > Isn't that a very bad way to write "i = j + 1"?
> >
> > I agree with Horiguchi-san that
> > for (i = 0, headxid = xid;;)
>
> Okay. Horiguchi-san, would you like to
On Sun, Jan 16, 2022 at 11:01:25PM -0500, Tom Lane wrote:
> Isn't that a very bad way to write "i = j + 1"?
>
> I agree with Horiguchi-san that
> for (i = 0, headxid = xid;;)
Okay. Horiguchi-san, would you like to write a patch?
--
Michael
signature.asc
Description: PGP signature
Michael Paquier writes:
> On Mon, Jan 17, 2022 at 11:17:24AM +0900, Kyotaro Horiguchi wrote:
>> I found some confusing lines around but they need not a fix
>> considering back-patching conflict?
>>> i += j - i + 1;
> I am not sure. Do you have anything specific in mind? Perhaps
> something that
On Mon, Jan 17, 2022 at 11:17:24AM +0900, Kyotaro Horiguchi wrote:
> At Fri, 14 Jan 2022 22:49:59 +, "Kingsborough, Alex"
> wrote in
>> The fix for this is very simple
>>
>>
>> /* if we wrote out all subxids, we're done. /
>> - if (j + 1 >= nsubxids)
>> + if (j >= nsubxids)
>> brea
At Fri, 14 Jan 2022 22:49:59 +, "Kingsborough, Alex"
wrote in
> The fix for this is very simple
>
>
> /* if we wrote out all subxids, we're done. /
> - if (j + 1 >= nsubxids)
> + if (j >= nsubxids)
> break;
It looks like a thinko and the fix is correct. (It's a matter of taste
cho
