Re: Optimizer docs typos

2020-05-22 Thread Richard Guo
On Fri, May 22, 2020 at 2:53 PM Etsuro Fujita wrote: > > Done. > Thanks! Thanks Richard

Re: Optimizer docs typos

2020-05-21 Thread Etsuro Fujita
On Wed, May 20, 2020 at 7:17 PM Etsuro Fujita wrote: > On Tue, May 19, 2020 at 7:35 PM Etsuro Fujita wrote: > > On Mon, May 18, 2020 at 7:45 PM Richard Guo wrote: > > > In this same README doc, another suspicious typo to me, which happens in > > > section "Optimizer Functions", is in the prefix

Re: Optimizer docs typos

2020-05-20 Thread Etsuro Fujita
On Thu, May 21, 2020 at 11:25 AM Kyotaro Horiguchi wrote: > At Wed, 20 May 2020 19:17:48 +0900, Etsuro Fujita > wrote in > > Here is a patch including the change I proposed. (Yet another thing I > > noticed is the indent spaces for join_search_one_level(): that > > function is called within sta

Re: Optimizer docs typos

2020-05-20 Thread Kyotaro Horiguchi
At Wed, 20 May 2020 19:17:48 +0900, Etsuro Fujita wrote in > On Tue, May 19, 2020 at 7:35 PM Etsuro Fujita wrote: > > On Mon, May 18, 2020 at 7:45 PM Richard Guo wrote: > > > ---query_planner() > > > +---query_planner() > > > make list of base relations used in query > > > split up the

Re: Optimizer docs typos

2020-05-20 Thread Etsuro Fujita
On Tue, May 19, 2020 at 7:35 PM Etsuro Fujita wrote: > On Mon, May 18, 2020 at 7:45 PM Richard Guo wrote: > > In this same README doc, another suspicious typo to me, which happens in > > section "Optimizer Functions", is in the prefix to query_planner(), > > we should have three dashes, rather th

Re: Optimizer docs typos

2020-05-19 Thread Etsuro Fujita
On Mon, May 18, 2020 at 7:45 PM Richard Guo wrote: > In this same README doc, another suspicious typo to me, which happens in > section "Optimizer Functions", is in the prefix to query_planner(), > we should have three dashes, rather than two, since query_planner() is > called within grouping_plan

Re: Optimizer docs typos

2020-05-18 Thread Richard Guo
In this same README doc, another suspicious typo to me, which happens in section "Optimizer Functions", is in the prefix to query_planner(), we should have three dashes, rather than two, since query_planner() is called within grouping_planner(). diff --git a/src/backend/optimizer/README b/src/back

Re: Optimizer docs typos

2020-05-18 Thread Etsuro Fujita
On Mon, May 18, 2020 at 6:56 PM Magnus Hagander wrote: > On Mon, May 18, 2020 at 11:31 AM Daniel Gustafsson wrote: >> Attached diff fixes two small typos in the optimizer README. > Pushed, thanks. Thank you! Best regards, Etsuro Fujita

Re: Optimizer docs typos

2020-05-18 Thread Magnus Hagander
On Mon, May 18, 2020 at 11:31 AM Daniel Gustafsson wrote: > Attached diff fixes two small typos in the optimizer README. > Pushed, thanks. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Optimizer docs typos

2020-05-18 Thread Daniel Gustafsson
Attached diff fixes two small typos in the optimizer README. cheers ./daniel optimizer_doc_typos.diff Description: Binary data