Re: PG 18 release notes draft committed

2025-06-11 Thread Bruce Momjian
On Wed, Jun 11, 2025 at 02:45:58PM -0400, Melanie Plageman wrote: > On Thu, May 29, 2025 at 12:41 PM Bruce Momjian wrote: > > > > On Thu, May 29, 2025 at 09:42:30AM -0400, Melanie Plageman wrote: > > > > > "Add an asynchronous I/O subsystem" > > > I noticed in the PG 17 release notes [1] we did in

Re: PG 18 release notes draft committed

2025-06-11 Thread Melanie Plageman
On Thu, May 29, 2025 at 12:41 PM Bruce Momjian wrote: > > On Thu, May 29, 2025 at 09:42:30AM -0400, Melanie Plageman wrote: > > > > "Add an asynchronous I/O subsystem" > > I noticed in the PG 17 release notes [1] we did include the shas of > > each of the commits for the read stream users. Should

Re: PG 18 release notes draft committed

2025-06-07 Thread Bruce Momjian
On Thu, Jun 5, 2025 at 08:32:44PM -0400, Bruce Momjian wrote: > On Wed, Jun 4, 2025 at 05:53:38PM -0400, Bruce Momjian wrote: > > On Wed, Jun 4, 2025 at 02:29:46PM -0700, Noah Misch wrote: > > > I agree with David G. Johnston's feedback on this. My draft didn't > > > mention > > > SECURITY DEF

Re: PG 18 release notes draft committed

2025-06-05 Thread Bruce Momjian
On Wed, Jun 4, 2025 at 05:53:38PM -0400, Bruce Momjian wrote: > On Wed, Jun 4, 2025 at 02:29:46PM -0700, Noah Misch wrote: > > I agree with David G. Johnston's feedback on this. My draft didn't mention > > SECURITY DEFINER, because I consider it redundant from a user's perspective. > > If a func

Re: PG 18 release notes draft committed

2025-06-04 Thread Bruce Momjian
On Wed, Jun 4, 2025 at 06:37:57PM -0400, Tom Lane wrote: > "David G. Johnston" writes: > > Is this covering the case of executing at the end of an outer SQL command > > (thus not deferred) that contains volatile DML functions that temporarily > > change current_user within the function? > > Not

Re: PG 18 release notes draft committed

2025-06-04 Thread Tom Lane
"David G. Johnston" writes: > Is this covering the case of executing at the end of an outer SQL command > (thus not deferred) that contains volatile DML functions that temporarily > change current_user within the function? Not quite. I think that a non-deferred AFTER trigger would ordinarily run

Re: PG 18 release notes draft committed

2025-06-04 Thread David G. Johnston
On Wed, Jun 4, 2025 at 3:17 PM Noah Misch wrote: > On Wed, Jun 04, 2025 at 06:10:38PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > but you are right it is part of the function, not the > > > trigger: > > > > > Execute deferred constraint triggers attached to > > > non-SECURITY-

Re: PG 18 release notes draft committed

2025-06-04 Thread Noah Misch
On Wed, Jun 04, 2025 at 06:10:38PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I think we have to keep the non-SECURITY-DEFINER designation to keep the > > text accurate, I don't see it that way, because there's currently no experiment the user can perform to distinguish between the follow

Re: PG 18 release notes draft committed

2025-06-04 Thread Tom Lane
Bruce Momjian writes: > I think we have to keep the non-SECURITY-DEFINER designation to keep the > text accurate, but you are right it is part of the function, not the > trigger: > Execute deferred constraint triggers attached to > non-SECURITY-DEFINER functions as the role that was a

Re: PG 18 release notes draft committed

2025-06-04 Thread Bruce Momjian
On Wed, Jun 4, 2025 at 02:29:46PM -0700, Noah Misch wrote: > I agree with David G. Johnston's feedback on this. My draft didn't mention > SECURITY DEFINER, because I consider it redundant from a user's perspective. > If a function is SECURITY DEFINER, that always overrides other sources of user >

Re: PG 18 release notes draft committed

2025-06-04 Thread Bruce Momjian
On Wed, Jun 4, 2025 at 02:02:38PM -0700, David G. Johnston wrote: > On Wed, Jun 4, 2025 at 1:45 PM Bruce Momjian wrote: > > Now, if we do want to mention it, it should be done in a way that makes > it clear to readers whether they are affected by this change.  We can > try text like:

Re: PG 18 release notes draft committed

2025-06-04 Thread Noah Misch
On Wed, Jun 04, 2025 at 04:45:18PM -0400, Bruce Momjian wrote: > On Tue, Jun 3, 2025 at 10:21:23AM -0700, Noah Misch wrote: > > When a commit changes the user that runs a function in existing queries, I > > think that almost always needs a release notes entry. It would follow that > > commit 0146

Re: PG 18 release notes draft committed

2025-06-04 Thread David G. Johnston
On Wed, Jun 4, 2025 at 1:45 PM Bruce Momjian wrote: > Now, if we do want to mention it, it should be done in a way that makes > it clear to readers whether they are affected by this change. We can > try text like: > > Execute non-SECURITY-DEFINER AFTER triggers as the role that was >

Re: PG 18 release notes draft committed

2025-06-04 Thread Bruce Momjian
On Tue, Jun 3, 2025 at 10:21:23AM -0700, Noah Misch wrote: > On Thu, May 01, 2025 at 10:44:50PM -0400, Bruce Momjian wrote: > > I have committd the first draft of the PG 18 release notes. > > When a commit changes the user that runs a function in existing queries, I > think that almost always nee

Re: PG 18 release notes draft committed

2025-06-03 Thread Noah Misch
On Thu, May 01, 2025 at 10:44:50PM -0400, Bruce Momjian wrote: > I have committd the first draft of the PG 18 release notes. When a commit changes the user that runs a function in existing queries, I think that almost always needs a release notes entry. It would follow that commit 01463e1 needs a

Re: PG 18 release notes draft committed

2025-05-29 Thread Bruce Momjian
On Thu, May 29, 2025 at 09:42:30AM -0400, Melanie Plageman wrote: > > > "Add an asynchronous I/O subsystem" > > > > > > I notice we don't call out any of the operations where users could > > > expect to see asynchronous IO be used. Some were enabled in 17 (like > > > sequential scans, analyze, and

Re: PG 18 release notes draft committed

2025-05-29 Thread Melanie Plageman
On Wed, May 28, 2025 at 10:49 PM Bruce Momjian wrote: > > On Wed, May 28, 2025 at 08:07:20PM -0400, Melanie Plageman wrote: > > Yes, I can now see it is two items so I have split it into two in the > attached, applied patch. In a separate commit I adjusted the docs for > log_connections to more c

Re: PG 18 release notes draft committed

2025-05-29 Thread Joe Conway
On 5/29/25 07:53, Álvaro Herrera wrote: On 2025-May-28, Bruce Momjian wrote: Sure, we can just link to: https://www.postgresql.org/list/pgsql-committers/ and they can choose any recent commit. IMO this is useless, because there's no assurance that the "recent commit" they choose is

Re: PG 18 release notes draft committed

2025-05-29 Thread Álvaro Herrera
On 2025-May-28, Bruce Momjian wrote: > Sure, we can just link to: > > https://www.postgresql.org/list/pgsql-committers/ > > and they can choose any recent commit. IMO this is useless, because there's no assurance that the "recent commit" they choose is actually following good practices.

Re: PG 18 release notes draft committed

2025-05-28 Thread Bruce Momjian
On Wed, May 28, 2025 at 08:07:20PM -0400, Melanie Plageman wrote: > For the item: > > "Increase the logging granularity of server variable log_connections" > > I noticed that you cite the commit 9219093cab2 that actually does > modularize the GUC but you also cite a separate following commit > 18

Re: PG 18 release notes draft committed

2025-05-28 Thread Melanie Plageman
On Thu, May 1, 2025 at 10:44 PM Bruce Momjian wrote: > > I will continue improving it until beta 1, and until the final release. Hi Bruce, Thanks so much for putting these together. For the item: "Increase the logging granularity of server variable log_connections" I noticed that you cite the

Re: PG 18 release notes draft committed

2025-05-28 Thread Bruce Momjian
On Wed, May 28, 2025 at 02:54:29PM -0400, Joe Conway wrote: > On 5/27/25 17:27, Bruce Momjian wrote: > > On Mon, May 26, 2025 at 10:20:08AM -0400, Joe Conway wrote: > > > On 5/23/25 09:47, Bruce Momjian wrote: > > > > On Fri, May 23, 2025 at 09:54:54AM +0200, Álvaro Herrera wrote: > > > > > I also

Re: PG 18 release notes draft committed

2025-05-28 Thread Bruce Momjian
On Wed, May 28, 2025 at 11:25:03PM +0900, Yugo Nagata wrote: > On Wed, 28 May 2025 23:14:36 +0900 > Yugo Nagata wrote: > > > On Thu, 1 May 2025 22:44:50 -0400 > > Bruce Momjian wrote: > > > > > I have committd the first draft of the PG 18 release notes. The item > > > count looks strong: > >

Re: PG 18 release notes draft committed

2025-05-28 Thread Joe Conway
On 5/27/25 17:27, Bruce Momjian wrote: On Mon, May 26, 2025 at 10:20:08AM -0400, Joe Conway wrote: On 5/23/25 09:47, Bruce Momjian wrote: > On Fri, May 23, 2025 at 09:54:54AM +0200, Álvaro Herrera wrote: > > I also think that showing an XML-ish format of a commit message is > > unhelpful, not to

Re: PG 18 release notes draft committed

2025-05-28 Thread Bruce Momjian
On Wed, May 28, 2025 at 10:55:50AM +0100, Dean Rasheed wrote: > For "Improve the speed of multiplication", I think it should say > "numeric multiplication" rather than simply "multiplication", and I > think it's worth also linking to commits ca481d3c9ab and c4e44224cf6 > which were part of the same

Re: PG 18 release notes draft committed

2025-05-28 Thread Yugo Nagata
On Wed, 28 May 2025 23:14:36 +0900 Yugo Nagata wrote: > On Thu, 1 May 2025 22:44:50 -0400 > Bruce Momjian wrote: > > > I have committd the first draft of the PG 18 release notes. The item > > count looks strong: > > Some items in the "EXPLAIN" section are actually not about the EXPLAIN > but

Re: PG 18 release notes draft committed

2025-05-28 Thread Yugo Nagata
On Thu, 1 May 2025 22:44:50 -0400 Bruce Momjian wrote: > I have committd the first draft of the PG 18 release notes. The item > count looks strong: Some items in the "EXPLAIN" section are actually not about the EXPLAIN but the ANALYZE command. The attached patch is move them to the "Utility Com

Re: PG 18 release notes draft committed

2025-05-28 Thread Dean Rasheed
For "Improve the speed of multiplication", I think it should say "numeric multiplication" rather than simply "multiplication", and I think it's worth also linking to commits ca481d3c9ab and c4e44224cf6 which were part of the same work. I think it's also worth mentioning 9428c001f67, which sped up

Re: PG 18 release notes draft committed

2025-05-27 Thread Bruce Momjian
On Tue, May 27, 2025 at 09:26:41AM -0500, Nathan Bossart wrote: > For the "Deprecate MD5 password authentication" item, IMHO we should > emphasize that support for MD5 passwords will be removed in a future major > release, as we did for the 18beta1 announcement. Here's an attempt: > > Depre

Re: PG 18 release notes draft committed

2025-05-27 Thread Bruce Momjian
On Tue, May 27, 2025 at 08:13:24AM +1000, Peter Smith wrote: > Hi, > > There seems to be some unexpected ">" here: > > "E.1.3.7.3. Logical Replication Applications>" Yes, a mistake, fixed. -- Bruce Momjian https://momjian.us EDB https://enterpr

Re: PG 18 release notes draft committed

2025-05-27 Thread Bruce Momjian
On Mon, May 26, 2025 at 10:20:08AM -0400, Joe Conway wrote: > On 5/23/25 09:47, Bruce Momjian wrote: > > On Fri, May 23, 2025 at 09:54:54AM +0200, Álvaro Herrera wrote: > > > I also think that showing an XML-ish format of a commit message is > > > unhelpful, not to mention hard to read. Showing a

Re: PG 18 release notes draft committed

2025-05-27 Thread Nathan Bossart
For the "Deprecate MD5 password authentication" item, IMHO we should emphasize that support for MD5 passwords will be removed in a future major release, as we did for the 18beta1 announcement. Here's an attempt: Deprecate MD5 password authentication (Nathan Bossart) Support for M

Re: PG 18 release notes draft committed

2025-05-26 Thread Peter Smith
Hi, There seems to be some unexpected ">" here: "E.1.3.7.3. Logical Replication Applications>" == Kind Regards, Peter Smith. Fujitsu Australia

Re: PG 18 release notes draft committed

2025-05-26 Thread Joe Conway
On 5/23/25 09:47, Bruce Momjian wrote: On Fri, May 23, 2025 at 09:54:54AM +0200, Álvaro Herrera wrote: I also think that showing an XML-ish format of a commit message is unhelpful, not to mention hard to read. Showing a few actual examples would be better. Agreed, but the XML came from Joe Co

Re: PG 18 release notes draft committed

2025-05-23 Thread Michael Paquier
On Fri, May 23, 2025 at 04:01:41PM -0400, Bruce Momjian wrote: > I updated the release notes to current and included your patch, > attached, thanks. Just noticed 1ca583f6c0f9. Thanks for the commit. -- Michael signature.asc Description: PGP signature

Re: PG 18 release notes draft committed

2025-05-23 Thread Bruce Momjian
On Fri, May 23, 2025 at 10:01:13AM -0400, Peter Geoghegan wrote: > On Thu, May 22, 2025 at 10:24 PM Bruce Momjian wrote: > > I see your point that we are not defining what this does. I went with > > the attached text. > > You propose the wording is "This allows muti-column btree indexes to > be

Re: PG 18 release notes draft committed

2025-05-23 Thread Bruce Momjian
On Fri, May 23, 2025 at 03:16:51PM +0900, Michael Paquier wrote: > On Thu, May 01, 2025 at 10:44:50PM -0400, Bruce Momjian wrote: > > I will continue improving it until beta 1, and until the final release. > > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) > > May I sugges

Re: PG 18 release notes draft committed

2025-05-23 Thread Peter Geoghegan
On Thu, May 22, 2025 at 10:24 PM Bruce Momjian wrote: > I see your point that we are not defining what this does. I went with > the attached text. You propose the wording is "This allows muti-column btree indexes to be used by queries that only reference the second or later indexed columns". I

Re: PG 18 release notes draft committed

2025-05-23 Thread Bruce Momjian
On Fri, May 23, 2025 at 09:54:54AM +0200, Álvaro Herrera wrote: > On 2025-May-20, Bruce Momjian wrote: > > > On Tue, May 20, 2025 at 05:15:54PM +0300, Nazir Bilal Yavuz wrote: > > > > As of the date of the commit, "Co-authored-by:" is listed as: > > > > > > > > https://wiki.postgresql.org/

Re: PG 18 release notes draft committed

2025-05-23 Thread Bruce Momjian
On Fri, May 23, 2025 at 10:46:09AM +0200, Álvaro Herrera wrote: > On 2025-May-22, Bruce Momjian wrote: > > > Ah, I see, fixed with the attached patch. It might be nice if we had a > > more organized way of recording such commit corrections. > > `git notes` can do that. They can also be used to

Re: PG 18 release notes draft committed

2025-05-23 Thread Álvaro Herrera
On 2025-May-22, Bruce Momjian wrote: > Ah, I see, fixed with the attached patch. It might be nice if we had a > more organized way of recording such commit corrections. `git notes` can do that. They can also be used to indicate things such as commits being reverted. -- Álvaro Herrera

Re: PG 18 release notes draft committed

2025-05-23 Thread Álvaro Herrera
On 2025-May-20, Bruce Momjian wrote: > On Tue, May 20, 2025 at 05:15:54PM +0300, Nazir Bilal Yavuz wrote: > > > As of the date of the commit, "Co-authored-by:" is listed as: > > > > > > https://wiki.postgresql.org/wiki/Commit_Message_Guidance > No problem. The "Co-authored-by:" guidance

Re: PG 18 release notes draft committed

2025-05-22 Thread Michael Paquier
On Thu, May 01, 2025 at 10:44:50PM -0400, Bruce Momjian wrote: > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) May I suggest the attached addition for the release notes, following commit 371f2db8b t

Re: PG 18 release notes draft committed

2025-05-22 Thread Bruce Momjian
On Fri, May 23, 2025 at 08:19:15AM +0530, vignesh C wrote: > On Fri, 2 May 2025 at 08:14, Bruce Momjian wrote: > > > > I have committd the first draft of the PG 18 release notes. The item > > count looks strong: > > > > I will continue improving it until beta 1, and until the final release. > > I

Re: PG 18 release notes draft committed

2025-05-22 Thread vignesh C
On Fri, 2 May 2025 at 08:14, Bruce Momjian wrote: > > I have committd the first draft of the PG 18 release notes. The item > count looks strong: > > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) Re

Re: PG 18 release notes draft committed

2025-05-22 Thread Bruce Momjian
On Wed, May 21, 2025 at 05:57:07PM -0400, Peter Geoghegan wrote: > For example, TimescaleDB offers Loose index scan as part of the > TimescaleDB Postgres extension, which (for whatever reason) they chose > to call skip scan: > > https://www.timescale.com/blog/how-we-made-distinct-queries-up-to-800

Re: PG 18 release notes draft committed

2025-05-22 Thread Bruce Momjian
On Wed, May 21, 2025 at 05:57:07PM -0400, Peter Geoghegan wrote: > On Thu, May 1, 2025 at 10:44 PM Bruce Momjian wrote: > > I have committd the first draft of the PG 18 release notes. > > I suggest that you use something like the following wording for the > skip scan feature: > > Add the "skip s

Re: PG 18 release notes draft committed

2025-05-21 Thread Peter Geoghegan
On Thu, May 1, 2025 at 10:44 PM Bruce Momjian wrote: > I have committd the first draft of the PG 18 release notes. I suggest that you use something like the following wording for the skip scan feature: Add the "skip scan" optimization, which enables more efficient scans of multicolumn B-tree ind

Re: PG 18 release notes draft committed

2025-05-20 Thread Bruce Momjian
On Tue, May 20, 2025 at 05:15:54PM +0300, Nazir Bilal Yavuz wrote: > > As of the date of the commit, "Co-authored-by:" is listed as: > > > > https://wiki.postgresql.org/wiki/Commit_Message_Guidance > > > > "Co-authored-by:" is used by committers when they want to give full > > cred

Re: PG 18 release notes draft committed

2025-05-20 Thread Nazir Bilal Yavuz
Hi, On Tue, 20 May 2025 at 16:52, Bruce Momjian wrote: > > On Tue, May 20, 2025 at 03:46:44PM +0300, Nazir Bilal Yavuz wrote: > > Hi, > > > > Thanks for working on this! > > > > On Fri, 2 May 2025 at 05:44, Bruce Momjian wrote: > > > > > > I will continue improving it until beta 1, and until the

Re: PG 18 release notes draft committed

2025-05-20 Thread Bruce Momjian
On Tue, May 20, 2025 at 03:46:44PM +0300, Nazir Bilal Yavuz wrote: > Hi, > > Thanks for working on this! > > On Fri, 2 May 2025 at 05:44, Bruce Momjian wrote: > > > > I will continue improving it until beta 1, and until the final release. > > I will probably add markup in 1-3 weeks. Let the fee

Re: PG 18 release notes draft committed

2025-05-20 Thread Nazir Bilal Yavuz
Hi, Thanks for working on this! On Fri, 2 May 2025 at 05:44, Bruce Momjian wrote: > > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) + + +Add server variable file_copy_method to control the file co

Re: PG 18 release notes draft committed

2025-05-20 Thread Bruce Momjian
On Tue, May 13, 2025 at 08:05:24AM +0200, Laurenz Albe wrote: > On Mon, 2025-05-12 at 20:27 -0700, David G. Johnston wrote: > > Should all columns removed from system views and/or catalogs be listed in > > “Migration” or is there some filtering criteria? There are at minimum quite > > a few statist

Re: PG 18 release notes draft committed

2025-05-20 Thread Bruce Momjian
On Thu, May 15, 2025 at 02:02:02PM -0400, Álvaro Herrera wrote: > As related anecdote, the rename of columns in pg_stat_activity a few > years back caused some pg_upgrade pain, which IMO was understandable; > it's reasonable to call that kind of thing out as a possible > incompatibility, at least I

Re: PG 18 release notes draft committed

2025-05-15 Thread Álvaro Herrera
On 2025-May-13, Laurenz Albe wrote: > On the one hand, the catalogs don't promise to be a stable API, so there > would be no need to enumerate such changes as compatibility breaks. I think it might be useful to distinguish changes to views, which are intended to be user-facing, from changes to "i

Re: PG 18 release notes draft committed

2025-05-12 Thread Laurenz Albe
On Mon, 2025-05-12 at 20:27 -0700, David G. Johnston wrote: > On Thursday, May 1, 2025, Bruce Momjian wrote: > > I will continue improving it until beta 1, and until the final release. > > I will probably add markup in 1-3 weeks.  Let the feedback begin.  ;-) > > > Should all columns removed fro

Re: PG 18 release notes draft committed

2025-05-12 Thread David G. Johnston
On Thursday, May 1, 2025, Bruce Momjian wrote: > > > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) > Should all columns removed from system views and/or catalogs be listed in “Migration” or is there

Re: PG 18 release notes draft committed

2025-05-09 Thread Bruce Momjian
On Sat, May 10, 2025 at 10:38:06AM +1200, David Rowley wrote: > On Fri, 2 May 2025 at 14:44, Bruce Momjian wrote: > > I will continue improving it until beta 1, and until the final release. > > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) > > Minor detail, but "Improve t

Re: PG 18 release notes draft committed

2025-05-09 Thread David Rowley
On Fri, 2 May 2025 at 14:44, Bruce Momjian wrote: > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) Minor detail, but "Improve the performance and reduce memory usage of hash joins and GROUP BY" proba

Re: PG 18 release notes draft committed

2025-05-09 Thread Bruce Momjian
On Fri, May 9, 2025 at 04:51:03PM +0800, Steven Niu wrote: > Hi, Bruce, > > I have one comment, in E.1.3.4. Functions, crc32c also needs bracket. > "Add functions crc32() and crc32c to compute CRC values" --> > "Add functions crc32() and crc32c() to compute CRC values" Thanks, fixed. -- Bruc

Re: PG 18 release notes draft committed

2025-05-09 Thread Bruce Momjian
On Fri, May 9, 2025 at 12:05:07PM +0900, Richard Guo wrote: > > I think there are two patterns here: > > > > * 247dea89f and cc5d98525 fix cases where grouping expressions fail to > > match lower-level target items due to expression preprocessing or > > subquery pull-up. Subqueries are one exampl

Re: PG 18 release notes draft committed

2025-05-09 Thread Steven Niu
Hi, Bruce, I have one comment, in E.1.3.4. Functions, crc32c also needs bracket. "Add functions crc32() and crc32c to compute CRC values" --> "Add functions crc32() and crc32c() to compute CRC values" Regards, Steven 在 2025/5/2 10:44, Bruce Momjian 写道: > I have committd the first draft of the P

Re: PG 18 release notes draft committed

2025-05-08 Thread Richard Guo
On Fri, May 9, 2025 at 11:47 AM Richard Guo wrote: > On Fri, May 9, 2025 at 12:18 AM Bruce Momjian wrote: > > On Thu, May 8, 2025 at 07:46:11PM +0900, Richard Guo wrote: > > > On Thu, May 8, 2025 at 5:41 AM Bruce Momjian wrote: > > > > On Wed, May 7, 2025 at 03:03:32PM +0900, Richard Guo wrote

Re: PG 18 release notes draft committed

2025-05-08 Thread Richard Guo
On Fri, May 9, 2025 at 12:18 AM Bruce Momjian wrote: > On Thu, May 8, 2025 at 07:46:11PM +0900, Richard Guo wrote: > > On Thu, May 8, 2025 at 5:41 AM Bruce Momjian wrote: > > > On Wed, May 7, 2025 at 03:03:32PM +0900, Richard Guo wrote: > > > > I'm wondering if we should consider mentioning tha

Re: PG 18 release notes draft committed

2025-05-08 Thread Bruce Momjian
On Thu, May 8, 2025 at 07:46:11PM +0900, Richard Guo wrote: > On Thu, May 8, 2025 at 5:41 AM Bruce Momjian wrote: > > On Wed, May 7, 2025 at 03:03:32PM +0900, Richard Guo wrote: > > > I'm wondering if we should consider mentioning that several > > > long-standing issues related to grouping sets

Re: PG 18 release notes draft committed

2025-05-08 Thread Bruce Momjian
On Thu, May 8, 2025 at 03:45:00PM +0800, jian he wrote: > On Fri, May 2, 2025 at 10:44 AM Bruce Momjian wrote: > > > > release-18: 209 > > > > I will continue improving it until beta 1, and until the final release. > > I will probably add markup in 1-3 weeks. Let the feedback begin. ;

Re: PG 18 release notes draft committed

2025-05-08 Thread Richard Guo
On Thu, May 8, 2025 at 5:41 AM Bruce Momjian wrote: > On Wed, May 7, 2025 at 03:03:32PM +0900, Richard Guo wrote: > > I'm wondering if we should consider mentioning that several > > long-standing issues related to grouping sets have been fixed starting > > from PostgreSQL v18. I understand that

Re: PG 18 release notes draft committed

2025-05-08 Thread jian he
On Fri, May 2, 2025 at 10:44 AM Bruce Momjian wrote: > > release-18: 209 > > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) > > You can see the most current HTML-built version here: > >

Re: PG 18 release notes draft committed

2025-05-07 Thread Bruce Momjian
On Thu, May 8, 2025 at 01:16:45PM +1200, David Rowley wrote: > On Thu, 8 May 2025 at 13:11, Bruce Momjian wrote: > > Ah, I see those now. It was two commits. For some reason the edits are > > hard for me; applied patch attached. > > Thanks. There's been lots of work done in the last year, so

Re: PG 18 release notes draft committed

2025-05-07 Thread David Rowley
On Thu, 8 May 2025 at 13:11, Bruce Momjian wrote: > Ah, I see those now. It was two commits. For some reason the edits are > hard for me; applied patch attached. Thanks. There's been lots of work done in the last year, so lots of work to understand it all to a level where you can write meanin

Re: PG 18 release notes draft committed

2025-05-07 Thread Bruce Momjian
On Thu, May 8, 2025 at 12:47:22PM +1200, David Rowley wrote: > On Thu, 8 May 2025 at 12:36, Bruce Momjian wrote: > > +Change pg_backend_memory_contexts.level and > > pg_log_backend_memory_contexts()() to be one-based (Melih Mutlu, Fujii > > Masao) > > There's an extra set of parentheses on tha

Re: PG 18 release notes draft committed

2025-05-07 Thread David Rowley
On Thu, 8 May 2025 at 12:36, Bruce Momjian wrote: > +Change pg_backend_memory_contexts.level and > pg_log_backend_memory_contexts()() to be one-based (Melih Mutlu, Fujii Masao) There's an extra set of parentheses on that function name. There's also an inconsistency between the commit link you ad

Re: PG 18 release notes draft committed

2025-05-07 Thread Bruce Momjian
On Thu, May 8, 2025 at 09:33:49AM +1200, David Rowley wrote: > On Fri, 2 May 2025 at 14:44, Bruce Momjian wrote: > > You can see the most current HTML-built version here: > > > > https://momjian.us/pgsql_docs/release-18.html > > You might have left it out on purpose as the output isn't l

Re: PG 18 release notes draft committed

2025-05-07 Thread David Rowley
On Fri, 2 May 2025 at 14:44, Bruce Momjian wrote: > You can see the most current HTML-built version here: > > https://momjian.us/pgsql_docs/release-18.html You might have left it out on purpose as the output isn't likely to be read by a machine, but for "Change pg_backend_memory_contexts.

Re: PG 18 release notes draft committed

2025-05-07 Thread Bruce Momjian
On Wed, May 7, 2025 at 07:59:41PM +0900, Yugo Nagata wrote: > On Thu, 1 May 2025 22:44:50 -0400 > Bruce Momjian wrote: > > > I have committd the first draft of the PG 18 release notes. The item > > count looks strong: > > Thank you for working on this. > > > Have pgbench report the number of

Re: PG 18 release notes draft committed

2025-05-07 Thread Bruce Momjian
On Wed, May 7, 2025 at 03:03:32PM +0900, Richard Guo wrote: > On Fri, May 2, 2025 at 11:44 AM Bruce Momjian wrote: > > > > I have committd the first draft of the PG 18 release notes. > > > I will continue improving it until beta 1, and until the final release. > > I will probably add markup in 1

Re: PG 18 release notes draft committed

2025-05-07 Thread Yugo Nagata
On Thu, 1 May 2025 22:44:50 -0400 Bruce Momjian wrote: > I have committd the first draft of the PG 18 release notes. The item > count looks strong: Thank you for working on this. > Have pgbench report the number of failed transactions (Yugo Nagata) I think that should be "Have pgbench repo

Re: PG 18 release notes draft committed

2025-05-06 Thread Richard Guo
On Fri, May 2, 2025 at 11:44 AM Bruce Momjian wrote: > > I have committd the first draft of the PG 18 release notes. > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) Thanks for working on these. I'

Re: PG 18 release notes draft committed

2025-05-06 Thread David Rowley
On Wed, 7 May 2025 at 13:17, Bruce Momjian wrote: > > On Wed, May 7, 2025 at 09:27:14AM +1200, David Rowley wrote: > > On Wed, 7 May 2025 at 07:44, Bruce Momjian wrote: > > A query such as: SELECT * FROM table_with_lots_of_partitions ORDER BY > > col; will plan much faster now. No joins there. >

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Wed, May 7, 2025 at 09:27:14AM +1200, David Rowley wrote: > On Wed, 7 May 2025 at 07:44, Bruce Momjian wrote: > > I think what you are saying is that this has to do with partition > > processing of joins, but not the pruning process. I don't think a > > non-partition joins are likely to hit 3

Re: PG 18 release notes draft committed

2025-05-06 Thread David Rowley
On Wed, 7 May 2025 at 07:44, Bruce Momjian wrote: > I think what you are saying is that this has to do with partition > processing of joins, but not the pruning process. I don't think a > non-partition joins are likely to hit 32 EquivalenceClasses. A query such as: SELECT * FROM table_with_lots_

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Tue, May 6, 2025 at 10:13:36PM +0800, jian he wrote: > Add pg_dump options --with-schema, --with-data, and --with_statistics > (Jeff Davis) § > The negative versions of these options already existed. > > Add pg_dump option --sequence-data to dump sequence data that would > normally be excluded

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Tue, May 6, 2025 at 10:18:27PM +0800, jian he wrote: > Allow partitions to be pruned more efficienty (Ashutosh Bapat, Yuya > Watari, David Rowley) § § > typo, "efficienty" should be "efficiently"? Yes, fixed from other email report. My spellcheck filter was broken. -- Bruce Momjian

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Tue, May 6, 2025 at 03:08:13PM +0900, Amit Langote wrote: > > I don't think most people would know what EquivalenceMember is, and even > > if they did, would they be able to connect it to an SQL query? > > Thanks for splitting these (cf847d634). I think the text for the > locking item should m

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Tue, May 6, 2025 at 03:14:56PM +1200, David Rowley wrote: > On Tue, 6 May 2025 at 03:59, Bruce Momjian wrote: > > > > On Mon, May 5, 2025 at 09:42:10PM +1200, David Rowley wrote: > > > I agree that 88f55bc97 and d69d45a5a should be in their own item. > > > Likely no need to go into detail abo

Re: PG 18 release notes draft committed

2025-05-06 Thread jian he
Allow partitions to be pruned more efficienty (Ashutosh Bapat, Yuya Watari, David Rowley) § § typo, "efficienty" should be "efficiently"?

Re: PG 18 release notes draft committed

2025-05-06 Thread jian he
On Fri, May 2, 2025 at 10:44 AM Bruce Momjian wrote: > > release-16: 206 > release-17: 182 > release-18: 209 > > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) > > You ca

Re: PG 18 release notes draft committed

2025-05-05 Thread Amit Langote
On Sat, May 3, 2025 at 1:18 AM Bruce Momjian wrote: > On Fri, May 2, 2025 at 01:00:57PM +0900, Amit Langote wrote: > > 1. Speed up execution of cached plans by deferring locks on partitions > > subject to pruning (Amit Langote) > > (bb3ec16e1, d47cbf474, cbc127917, 525392d57) > > > > 2. Speed up

Re: PG 18 release notes draft committed

2025-05-05 Thread David Rowley
On Tue, 6 May 2025 at 03:59, Bruce Momjian wrote: > > On Mon, May 5, 2025 at 09:42:10PM +1200, David Rowley wrote: > > I agree that 88f55bc97 and d69d45a5a should be in their own item. > > Likely no need to go into detail about the speed up being about > > "EquivalenceClass lookups". I imagine so

Re: PG 18 release notes draft committed

2025-05-05 Thread Bruce Momjian
On Mon, May 5, 2025 at 04:12:16PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Capitalization changed, patch attached. > > I need to start wrapping the tarballs soon ... are you done > with the release notes for today? Yes, I am, thanks for asking. I was waiting for the case folding thre

Re: PG 18 release notes draft committed

2025-05-05 Thread Tom Lane
Bruce Momjian writes: > Capitalization changed, patch attached. I need to start wrapping the tarballs soon ... are you done with the release notes for today? regards, tom lane

Re: PG 18 release notes draft committed

2025-05-05 Thread Alexander Borisov
05.05.2025 03:22, Jelte Fennema-Nio wrote: [...] I think there are a few things at play here why that did not happen in Bruce his initial draft: 1. I personally think the requirement that Bruce uses for perf improvements to make it into the changelog is too strict (see my previous email for de

Re: PG 18 release notes draft committed

2025-05-05 Thread Bruce Momjian
On Mon, May 5, 2025 at 12:20:15PM -0700, Jacob Champion wrote: > On Thu, May 1, 2025 at 7:44 PM Bruce Momjian wrote: > > https://momjian.us/pgsql_docs/release-18.html > > > +Add support for the "oauth" authentication (Jacob Champion, Daniel > > Gustafsson, Thomas Munro) > > Should be e

Re: PG 18 release notes draft committed

2025-05-05 Thread Jacob Champion
On Thu, May 1, 2025 at 7:44 PM Bruce Momjian wrote: > https://momjian.us/pgsql_docs/release-18.html > +Add support for the "oauth" authentication (Jacob Champion, Daniel > Gustafsson, Thomas Munro) Should be either 'support for "oauth" authentication' or 'support for the "oauth" authent

Re: PG 18 release notes draft committed

2025-05-05 Thread Bruce Momjian
On Mon, May 5, 2025 at 02:09:26PM +, Bertrand Drouvot wrote: > A. > > "Per-backend I/O statistics can be cleared via pg_stat_reset_backend_stats()" > > and > > "Per-backend WAL statistics can be cleared via pg_stat_reset_backend_stats()" > > for consitency. > > Or: I went with the A opti

Re: PG 18 release notes draft committed

2025-05-05 Thread Bruce Momjian
On Mon, May 5, 2025 at 10:14:22PM +1200, David Rowley wrote: > On Fri, 2 May 2025 at 14:44, Bruce Momjian wrote: > > You can see the most current HTML-built version here: > > > > https://momjian.us/pgsql_docs/release-18.html > > Thanks for working on these. > > For "Improve the performa

Re: PG 18 release notes draft committed

2025-05-05 Thread Bruce Momjian
On Mon, May 5, 2025 at 09:42:10PM +1200, David Rowley wrote: > On Fri, 2 May 2025 at 16:01, Amit Langote wrote: > > +Allow partitions to be pruned earlier and quicker, and skipped in > > more places (Amit Langote, Ashutosh Bapat, Yuya Watari, David Rowley) > > > > Alternatively, 2 and 3 can be co

Re: PG 18 release notes draft committed

2025-05-05 Thread Daniel Westermann (DWE)
>On Thu, May 01, 2025 at 10:44:50PM -0400, Bruce Momjian wrote: >> I have committd the first draft of the PG 18 release notes. >I don't think pg_buffercache_numa does exist. Please ignore Regards Daniel

Re: PG 18 release notes draft committed

2025-05-05 Thread Daniel Westermann (DWE)
On Thu, May 01, 2025 at 10:44:50PM -0400, Bruce Momjian wrote: > I have committd the first draft of the PG 18 release notes. I don't think pg_buffercache_numa does exist. Regards Daniel

Re: PG 18 release notes draft committed

2025-05-05 Thread Bertrand Drouvot
Hi, On Thu, May 01, 2025 at 10:44:50PM -0400, Bruce Momjian wrote: > I have committd the first draft of the PG 18 release notes. Thanks for working on this! > You can see the most current HTML-built version here: > > https://momjian.us/pgsql_docs/release-18.html I have one comment rela

  1   2   >