On Mon, Sep 13, 2021 at 11:58 PM Tom Lane wrote:
>
> Amit Kapila writes:
> > Pushed the first patch. I am not so sure about the second one so I
> > won't do anything for the same. I'll close this CF entry in a day or
> > two unless there is an interest in the second patch.
>
> Sorry for not revie
Amit Kapila writes:
> Pushed the first patch. I am not so sure about the second one so I
> won't do anything for the same. I'll close this CF entry in a day or
> two unless there is an interest in the second patch.
Sorry for not reviewing this more promptly.
I made some further edits in the 0002
On Thu, Sep 9, 2021 at 9:50 AM Amit Kapila wrote:
>
> On Wed, Sep 8, 2021 at 12:24 PM Peter Smith wrote:
> >
> > v2 --> v3
> >
> > The subscription_parameter names are now split into 2 groups using
> > Amit's suggestion [1] on how to categorise them.
> >
> > I also made some grammar improvements
On Wed, Sep 8, 2021 at 12:24 PM Peter Smith wrote:
>
> v2 --> v3
>
> The subscription_parameter names are now split into 2 groups using
> Amit's suggestion [1] on how to categorise them.
>
> I also made some grammar improvements to their descriptions.
>
I have made minor edits to your first patch
v2 --> v3
The subscription_parameter names are now split into 2 groups using
Amit's suggestion [1] on how to categorise them.
I also made some grammar improvements to their descriptions.
PSA.
--
[1]
https://www.postgresql.org/message-id/CAA4eK1Kmu74xHk2jcHTmKq8HBj3xK6n%3DRfiJB6dfV5zVSqqiFg
On Sun, Sep 5, 2021 at 12:23 AM Tom Lane wrote:
>
> Amit Kapila writes:
> > On Mon, Apr 19, 2021 at 10:32 AM Peter Smith wrote:
> >> Yes, if there were dozens of list items then I would agree that they
> >> should be grouped somehow. But there aren't.
>
> > I think this list is going to grow in
Amit Kapila writes:
> On Mon, Apr 19, 2021 at 10:32 AM Peter Smith wrote:
>> Yes, if there were dozens of list items then I would agree that they
>> should be grouped somehow. But there aren't.
> I think this list is going to grow in the future as we enhance this
> subsystem. For example, the pe
v1 -> v2
Rebased.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v2-0001-create-subscription-options-list-order.patch
Description: Binary data
On Mon, Apr 19, 2021 at 10:32 AM Peter Smith wrote:
>
> On Mon, Apr 19, 2021 at 2:09 PM Amit Kapila wrote:
> >
> > On Mon, Apr 19, 2021 at 6:32 AM Euler Taveira wrote:
> > >
> > > On Sun, Apr 18, 2021, at 8:59 PM, Peter Smith wrote:
> > >
> > > The CREATE SUBSCRIPTION documentation [1] includes
On Mon, Apr 19, 2021 at 2:09 PM Amit Kapila wrote:
>
> On Mon, Apr 19, 2021 at 6:32 AM Euler Taveira wrote:
> >
> > On Sun, Apr 18, 2021, at 8:59 PM, Peter Smith wrote:
> >
> > The CREATE SUBSCRIPTION documentation [1] includes a list of "WITH"
> > options, which are currently in some kind of qua
On Mon, Apr 19, 2021 at 6:32 AM Euler Taveira wrote:
>
> On Sun, Apr 18, 2021, at 8:59 PM, Peter Smith wrote:
>
> The CREATE SUBSCRIPTION documentation [1] includes a list of "WITH"
> options, which are currently in some kind of quasi alphabetical /
> random order which I found unnecessarily confu
On Sun, Apr 18, 2021, at 8:59 PM, Peter Smith wrote:
> The CREATE SUBSCRIPTION documentation [1] includes a list of "WITH"
> options, which are currently in some kind of quasi alphabetical /
> random order which I found unnecessarily confusing.
>
> I can't think of any good reason for the current
Hi,
The CREATE SUBSCRIPTION documentation [1] includes a list of "WITH"
options, which are currently in some kind of quasi alphabetical /
random order which I found unnecessarily confusing.
I can't think of any good reason for the current ordering, so PSA my
patch which has identical content but
13 matches
Mail list logo
