Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-12 Thread Peter Smith
On Tue, Dec 13, 2022 at 6:25 AM Alvaro Herrera wrote: > > On 2022-Dec-07, samay sharma wrote: > > > On Tue, Dec 6, 2022 at 11:12 PM Peter Smith wrote: > > > > OK. I copied the tablesync note back to config.sgml definition of > > > 'max_replication_slots' and removed the link as suggested. Frankly

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-12 Thread Alvaro Herrera
On 2022-Dec-11, Tom Lane wrote: > Ian is still working on closing out the November 'fest :-(. > I suspect that in a day or so that one will get moved, and > you will have duplicate entries in the January 'fest. I've marked both as committed. -- Álvaro Herrera 48°01'N 7°57'E — ht

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-12 Thread Alvaro Herrera
On 2022-Dec-07, samay sharma wrote: > On Tue, Dec 6, 2022 at 11:12 PM Peter Smith wrote: > > OK. I copied the tablesync note back to config.sgml definition of > > 'max_replication_slots' and removed the link as suggested. Frankly, I > > also thought it is a bit strange that the max_replication_s

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-11 Thread Tom Lane
Peter Smith writes: > On Sat, Dec 10, 2022 at 5:10 AM samay sharma wrote: >> Also, I don't see this patch in the 2023/01 commitfest. Might be worth >> moving to that one. > Hmm, it was already recorded in the 2022-11 commitfest [1], so I > assumed it would just carry forward to the next one. I

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-11 Thread Peter Smith
On Sat, Dec 10, 2022 at 5:10 AM samay sharma wrote: > > > I don't have any other feedback. This looks good to me. > > Also, I don't see this patch in the 2023/01 commitfest. Might be worth moving > to that one. > Hmm, it was already recorded in the 2022-11 commitfest [1], so I assumed it would

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-09 Thread samay sharma
Hi, On Wed, Dec 7, 2022 at 9:20 PM Peter Smith wrote: > On Thu, Dec 8, 2022 at 10:49 AM samay sharma > wrote: > > > ... > > > Thanks for the changes. See a few points of feedback below. > > > > Patch v7 addresses this feedback. PSA. > > > > + > > > + For logical replication, > publisher

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-07 Thread Peter Smith
On Thu, Dec 8, 2022 at 10:49 AM samay sharma wrote: > ... > Thanks for the changes. See a few points of feedback below. > Patch v7 addresses this feedback. PSA. > > + > > + For logical replication, > > publishers > > + (servers that do > linkend="sql-createpublication">CREATE > >

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-07 Thread samay sharma
Hi, On Tue, Dec 6, 2022 at 11:12 PM Peter Smith wrote: > On Tue, Dec 6, 2022 at 5:57 AM samay sharma > wrote: > > > > Hi, > > > > On Mon, Oct 24, 2022 at 12:45 AM Peter Smith > wrote: > >> > >> Hi hackers. > >> > >> There is a docs Logical Replication section "31.10 Configuration > >> Settings

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-06 Thread Peter Smith
On Tue, Dec 6, 2022 at 5:57 AM samay sharma wrote: > > Hi, > > On Mon, Oct 24, 2022 at 12:45 AM Peter Smith wrote: >> >> Hi hackers. >> >> There is a docs Logical Replication section "31.10 Configuration >> Settings" [1] which describes some logical replication GUCs, and >> details on how they in

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-05 Thread samay sharma
Hi, On Mon, Oct 24, 2022 at 12:45 AM Peter Smith wrote: > Hi hackers. > > There is a docs Logical Replication section "31.10 Configuration > Settings" [1] which describes some logical replication GUCs, and > details on how they interact with each other and how to take that into > account when se

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-11-28 Thread Peter Smith
On Fri, Nov 25, 2022 at 9:23 PM Peter Eisentraut wrote: > > Your patch moves the description of the subscriber-related configuration > parameters from config.sgml to logical-replication.sgml. But > config.sgml is supposed to contain *all* configuration parameters. If > we're going to start split

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-11-25 Thread Peter Eisentraut
Your patch moves the description of the subscriber-related configuration parameters from config.sgml to logical-replication.sgml. But config.sgml is supposed to contain *all* configuration parameters. If we're going to start splitting this up and moving things around then we'd need a more com

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-11-23 Thread Peter Smith
On Wed, Nov 23, 2022 at 9:16 AM Peter Smith wrote: > > On Wed, Nov 16, 2022 at 10:24 PM vignesh C wrote: > > > ... > > > One suggestion: > > The format of subscribers includes the data type and default values, > > the format of publishers does not include data type and default > > values. We can

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-11-22 Thread Peter Smith
On Wed, Nov 16, 2022 at 10:24 PM vignesh C wrote: > ... > One suggestion: > The format of subscribers includes the data type and default values, > the format of publishers does not include data type and default > values. We can try to maintain the consistency for both publisher and > subscriber c

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-11-16 Thread vignesh C
On Tue, 15 Nov 2022 at 11:17, Peter Smith wrote: > > On Sun, Nov 13, 2022 at 11:47 AM vignesh C wrote: > > > > On Mon, 24 Oct 2022 at 13:15, Peter Smith wrote: > > > > > > Hi hackers. > > > > > > There is a docs Logical Replication section "31.10 Configuration > > > Settings" [1] which describes

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-11-14 Thread Peter Smith
On Sun, Nov 13, 2022 at 11:47 AM vignesh C wrote: > > On Mon, 24 Oct 2022 at 13:15, Peter Smith wrote: > > > > Hi hackers. > > > > There is a docs Logical Replication section "31.10 Configuration > > Settings" [1] which describes some logical replication GUCs, and > > details on how they interact

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-11-12 Thread vignesh C
On Mon, 24 Oct 2022 at 13:15, Peter Smith wrote: > > Hi hackers. > > There is a docs Logical Replication section "31.10 Configuration > Settings" [1] which describes some logical replication GUCs, and > details on how they interact with each other and how to take that into > account when setting t

PGDOCS - Logical replication GUCs - added some xrefs

2022-10-24 Thread Peter Smith
Hi hackers. There is a docs Logical Replication section "31.10 Configuration Settings" [1] which describes some logical replication GUCs, and details on how they interact with each other and how to take that into account when setting their values. There is another docs Server Configuration sectio