Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-30 Thread Peter Smith
Thanks for pushing! == Kind Regards, Peter Smith. Fujitsu Australia

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-30 Thread Amit Kapila
On Mon, Oct 16, 2023 at 6:15 AM Peter Smith wrote: > > Thanks for pushing the 0001 patch! I am unsure what the decision was > for the remaining patches, but anyway, here they are again (rebased). > To keep the link names the same in logical replication-related commands, I have pushed your patch.

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-15 Thread Peter Smith
Thanks for pushing the 0001 patch! I am unsure what the decision was for the remaining patches, but anyway, here they are again (rebased). == Kind Regards, Peter Smith. Fujitsu Australia v6-0002-Change-ids-for-CREATE-SUBSCRIPTION-parameters.patch Description: Binary data v6-0001-Change-ids

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-12 Thread Peter Smith
On Thu, Oct 12, 2023 at 3:44 PM Amit Kapila wrote: > > On Mon, Oct 9, 2023 at 12:15 PM Peter Smith wrote: > > > > On Mon, Oct 9, 2023 at 3:32 PM Amit Kapila wrote: > > > > > > > In v1, I used the same pattern as on the CREATE SUBSCRIPTION page, > > which doesn't look like those... > > > > Yeah,

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-11 Thread Amit Kapila
On Mon, Oct 9, 2023 at 12:15 PM Peter Smith wrote: > > On Mon, Oct 9, 2023 at 3:32 PM Amit Kapila wrote: > > > > In v1, I used the same pattern as on the CREATE SUBSCRIPTION page, > which doesn't look like those... > Yeah, I think it would have been better if we used params in the CREATE SUBSCRI

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-10 Thread Peter Smith
On Tue, Oct 10, 2023 at 5:10 PM vignesh C wrote: > > Few more instances in other logical replication related pages: > 1) Another instance was in alter_subscription.sgml: > Fetch missing table information from publisher. This will start > replication of tables that were added to the su

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-10 Thread Peter Smith
On Tue, Oct 10, 2023 at 11:33 PM Amit Kapila wrote: > > On Tue, Oct 10, 2023 at 11:40 AM vignesh C wrote: > > > > On Tue, 10 Oct 2023 at 08:47, Peter Smith wrote: > > > PSA v3. > > > > Few more instances in other logical replication related pages: > > 1) Another instance was in alter_subscriptio

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-10 Thread Amit Kapila
On Tue, Oct 10, 2023 at 11:40 AM vignesh C wrote: > > On Tue, 10 Oct 2023 at 08:47, Peter Smith wrote: > > PSA v3. > > Few more instances in other logical replication related pages: > 1) Another instance was in alter_subscription.sgml: > Fetch missing table information from publisher. This

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-09 Thread vignesh C
On Tue, 10 Oct 2023 at 08:47, Peter Smith wrote: > > On Tue, Oct 10, 2023 at 11:46 AM vignesh C wrote: > > > > I noticed a couple of other places where a link to "ALTER SUBSCRIPTION > > ... DISABLE" and "ALTER SUBSCRIPTION ... SET" can be specified in > > drop_subscription: > > To proceed in this

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-09 Thread Peter Smith
On Tue, Oct 10, 2023 at 11:46 AM vignesh C wrote: > > I noticed a couple of other places where a link to "ALTER SUBSCRIPTION > ... DISABLE" and "ALTER SUBSCRIPTION ... SET" can be specified in > drop_subscription: > To proceed in this situation, first disable the subscription by > executing ALTER

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-09 Thread vignesh C
On Mon, 9 Oct 2023 at 12:18, Peter Smith wrote: > > On Mon, Oct 9, 2023 at 3:32 PM Amit Kapila wrote: > > > > On Fri, Oct 6, 2023 at 12:15 PM Peter Smith wrote: > > > > > > Here is a patch to add the 2 missing references: > > > > > > ref/alter_subscription.sgml ==> added more ids > > > ref/alter

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-08 Thread Peter Smith
On Mon, Oct 9, 2023 at 3:32 PM Amit Kapila wrote: > > On Fri, Oct 6, 2023 at 12:15 PM Peter Smith wrote: > > > > Here is a patch to add the 2 missing references: > > > > ref/alter_subscription.sgml ==> added more ids > > ref/alter_publication.sgml ==> added link to > > "sql-altersubscription-refr

Re: PGDOCS - add more links in the pub/sub reference pages

2023-10-08 Thread Amit Kapila
On Fri, Oct 6, 2023 at 12:15 PM Peter Smith wrote: > > Here is a patch to add the 2 missing references: > > ref/alter_subscription.sgml ==> added more ids > ref/alter_publication.sgml ==> added link to > "sql-altersubscription-refresh-publication" > ref/drop_subscription.sgml ==> added link to "sq

PGDOCS - add more links in the pub/sub reference pages

2023-10-05 Thread Peter Smith
The "Description" and "Notes" parts of the following logical replication PUB/SUB reference pages (almost always) link to each other whenever a sibling command gets mentioned. CREATE PUBLICATION ALTER PUBLICATION DROP PUBLICATION CREATE SUBSCRIPTION ALTER SUBSCRIPTION DROP SUBSCRIPTION ~ AFAICT