On Sat, Mar 07, 2020 at 10:09:23AM +0900, Michael Paquier wrote:
> Thanks to both of you for the reviews. Please note that I will
> mention the business with pg_ctl and logging in a new thread and
> remove the diff of pg_ctl.c from the previous patch, and that the doc
> changes could be
On Thu, Mar 05, 2020 at 10:09:31AM +0100, Juan José Santamaría Flecha wrote:
> On Thu, Mar 5, 2020 at 9:40 AM Daniel Gustafsson wrote:
>> LGTM
>
> +1
Thanks to both of you for the reviews. Please note that I will
mention the business with pg_ctl and logging in a new thread and
remove the diff
On Thu, Mar 5, 2020 at 9:40 AM Daniel Gustafsson wrote:
> > On 5 Mar 2020, at 08:26, Michael Paquier wrote:
> >
> > So, combining the feedback from Fabien, Juan and Daniel I am finishing
> > with the attached. Any thoughts?
>
> LGTM
+1
Regards
> On 5 Mar 2020, at 08:26, Michael Paquier wrote:
>
> On Wed, Mar 04, 2020 at 10:05:30PM +0900, Michael Paquier wrote:
>> On Wed, Mar 04, 2020 at 11:31:27AM +0100, Fabien COELHO wrote:
>>> For "pgbench", you could also add the standard sentence that it uses libpq
>>> environment variables, as it
On Wed, Mar 04, 2020 at 10:05:30PM +0900, Michael Paquier wrote:
> On Wed, Mar 04, 2020 at 11:31:27AM +0100, Fabien COELHO wrote:
>> For "pgbench", you could also add the standard sentence that it uses libpq
>> environment variables, as it is also missing?
>
> Yeah, that's true. Let's fix this
On Wed, Mar 04, 2020 at 11:31:27AM +0100, Fabien COELHO wrote:
> No objection. I did not know there was such a thing…
>
> Maybe a more detailed explanation about PG_COLOR could be stored somewhere,
> and all affected tools could link to it? Or not.
One argument against that position is that each
On Wed, Mar 04, 2020 at 10:22:26AM +0100, Juan José Santamaría Flecha wrote:
> I think there are a couple tools missing: pg_archivecleanup, pg_ctl,
> pg_test_fsync and pg_upgrade. pg_regress also, but there is nothing to do
> in the documentation with it.
Indeed, true for pg_archivecleanup and
On Wed, Mar 04, 2020 at 10:12:23AM +0100, Daniel Gustafsson wrote:
> + color in diagnostics messages. Possible values are
> + always, auto,
> + never.
>
> Not being a native english speaker, I might have it backwards, but I find
> lists
> of values in a sentence like this to be easier to
Bonjour Michaël,
All the tools mentioned in $subject have been switched recently to use
the central logging infrastructure, which means that they have gained
coloring output. However we (mostly I) forgot to update the docs.
Attached is a patch to fix this issue. Please let me know if there
On Wed, Mar 4, 2020 at 8:54 AM Michael Paquier wrote:
>
> Attached is a patch to fix this issue. Please let me know if there
> are comments and/or objections.
>
I think there are a couple tools missing: pg_archivecleanup, pg_ctl,
pg_test_fsync and pg_upgrade. pg_regress also, but there is
> On 4 Mar 2020, at 08:54, Michael Paquier wrote:
> All the tools mentioned in $subject have been switched recently to use
> the central logging infrastructure, which means that they have gained
> coloring output. However we (mostly I) forgot to update the docs.
+1 on updating the docs with
Hi all,
All the tools mentioned in $subject have been switched recently to use
the central logging infrastructure, which means that they have gained
coloring output. However we (mostly I) forgot to update the docs.
Attached is a patch to fix this issue. Please let me know if there
are comments
12 matches
Mail list logo
