Re: PGroonga index-only scan problem with yesterday’s PostgreSQL updates

2022-02-16 Thread Bernd Helmle
Am Montag, dem 14.02.2022 um 16:02 -0500 schrieb Andrew Dunstan: > It occurred to me that this wasn't very well documented, so I created > some docco: > < > https://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto#Testing_Ad > ditional_Software> Thx Andrew, i wasn't aware of this, too! I'm goin

Re: PGroonga index-only scan problem with yesterday’s PostgreSQL updates

2022-02-14 Thread Andrew Dunstan
On 2/12/22 12:25, Tom Lane wrote: > > An even slicker answer would be to set up a PG buildfarm machine > that, in addition to the basic tests, builds PGroonga against the > new PG sources and runs your tests. Andrew's machine "crake" does > that for RedisFDW and BlackholeFDW, and the source code

Re: PGroonga index-only scan problem with yesterday’s PostgreSQL updates

2022-02-12 Thread Anders Kaseorg
On 2/12/22 09:25, Tom Lane wrote: I don't know that we'd go that far ... maybe if another bad problem turns up. In the meantime, though, I do have a modest suggestion: it would not be too hard to put some defenses in place against another such bug. The faulty commit was in our tree for a month

Re: Re: PGroonga index-only scan problem with yesterday’s PostgreSQL updates

2022-02-12 Thread Tom Lane
Anders Kaseorg writes: > On 2/11/22 15:57, Tom Lane wrote: >> Possibly same issue I just fixed? >> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=e5691cc9170bcd6c684715c2755d919c5a16fea2 > Yeah, that does seem to fix my test cases. Thanks! > Any chance this will make it into

Re: PGroonga index-only scan problem with yesterday’s PostgreSQL updates

2022-02-11 Thread Anders Kaseorg
On 2/11/22 15:57, Tom Lane wrote: Possibly same issue I just fixed? https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=e5691cc9170bcd6c684715c2755d919c5a16fea2 Yeah, that does seem to fix my test cases. Thanks! Any chance this will make it into minor releases sooner than thre

Re: PGroonga index-only scan problem with yesterday’s PostgreSQL updates

2022-02-11 Thread Tom Lane
Anders Kaseorg writes: > With yesterday’s release of PostgreSQL 11.15, 12.10, and 13.6 > (presumably 10.20 and 14.2 as well), Zulip’s test suite started failing > with “variable not found in subplan target list” errors from PostgreSQL > on a table that has a PGroonga index. Possibly same issue

PGroonga index-only scan problem with yesterday’s PostgreSQL updates

2022-02-11 Thread Anders Kaseorg
With yesterday’s release of PostgreSQL 11.15, 12.10, and 13.6 (presumably 10.20 and 14.2 as well), Zulip’s test suite started failing with “variable not found in subplan target list” errors from PostgreSQL on a table that has a PGroonga index. I found the following reproduction recipe from a f