Patch: Code comments: why some text-handling functions are leakproof

2022-01-10 Thread Gurjeet Singh
Please see attached a small patch to document why some text-processing functions are marked as leakproof, while some others are not. This is more or less a verbatim copy of Tom's comment in email thread at [1]. I could not find an appropriate spot to place these comments, so I placed them on btte

Re: Patch: Code comments: why some text-handling functions are leakproof

2022-03-28 Thread Greg Stark
I'm going to mark this returned with feedback. If you have a chance to update the patch moving the documentation to xfunc.sgml the way Tom describes make sure to create a new commitfest entry. I would suggest submitting the patch as a followup on this thread so when it's added to the commitfest it

Re: Patch: Code comments: why some text-handling functions are leakproof

2022-01-13 Thread Robert Haas
On Tue, Jan 11, 2022 at 2:07 AM Gurjeet Singh wrote: > Please see attached a small patch to document why some text-processing > functions are marked as leakproof, while some others are not. > > This is more or less a verbatim copy of Tom's comment in email thread at [1]. > > I could not find an a

Re: Patch: Code comments: why some text-handling functions are leakproof

2022-02-28 Thread Tom Lane
Robert Haas writes: > On Tue, Jan 11, 2022 at 2:07 AM Gurjeet Singh wrote: >> This is more or less a verbatim copy of Tom's comment in email thread at [1]. >> >> I could not find an appropriate spot to place these comments, so I placed >> them on bttextcmp() function, The only other place that