Per-tablespace autovacuum settings

2019-02-14 Thread Oleksii Kliukin
Hello, Is there any interest in making autovacuum parameters available on a tablespace level in order to apply those to all vacuumable objects in the tablespace? We have a set of tables running on ZFS, where autovacuum does almost no good to us (except for preventing anti-wraparound) due to the n

Per-tablespace autovacuum settings

2019-02-14 Thread Oleksii Kliukin
Hello, Is there any interest in making autovacuum parameters available on a tablespace level in order to apply those to all vacuumable objects in the tablespace? We have a set of tables running on ZFS, where autovacuum does almost no good to us (except for preventing anti-wraparound) due to the n

Re: Per-tablespace autovacuum settings

2019-02-14 Thread Andres Freund
Hi, On 2019-02-14 17:56:17 +0100, Oleksii Kliukin wrote: > Is there any interest in making autovacuum parameters available on a > tablespace level in order to apply those to all vacuumable objects in the > tablespace? > > We have a set of tables running on ZFS, where autovacuum does almost no goo

Re: Per-tablespace autovacuum settings

2019-02-14 Thread Tom Lane
Oleksii Kliukin writes: > Is there any interest in making autovacuum parameters available on a > tablespace level in order to apply those to all vacuumable objects in the > tablespace? I understand what you want to accomplish, and it doesn't seem unreasonable. But I just want to point out that t

Re: Per-tablespace autovacuum settings

2019-02-14 Thread Oleksii Kliukin
Andres Freund wrote: > Hi, > > On 2019-02-14 17:56:17 +0100, Oleksii Kliukin wrote: >> Is there any interest in making autovacuum parameters available on a >> tablespace level in order to apply those to all vacuumable objects in the >> tablespace? >> >> We have a set of tables running on ZFS, w

Re: Per-tablespace autovacuum settings

2019-02-14 Thread Oleksii Kliukin
Tom Lane wrote: > Oleksii Kliukin writes: >> Is there any interest in making autovacuum parameters available on a >> tablespace level in order to apply those to all vacuumable objects in the >> tablespace? > > I understand what you want to accomplish, and it doesn't seem > unreasonable. But I

Re: Per-tablespace autovacuum settings

2019-04-25 Thread Oleksii Kliukin
Hello, Oleksii Kliukin wrote: > Tom Lane wrote: > > >> I don't know how to make this better, but I wish we'd take a step >> back and think about it rather than just accreting more and more >> complexity. > > I am willing to do the refactoring when necessary, any particular place in > the cod

Re: Per-tablespace autovacuum settings

2019-05-03 Thread Robert Haas
On Thu, Apr 25, 2019 at 12:36 PM Oleksii Kliukin wrote: > - Fallbacks to autovacuum parameters in another scope. Right now in the > absence of the per-table and per-tablespace autovacuum parameters the code > uses the ones from the global scope. However, if only some of the reloptions > are set on

Re: Per-tablespace autovacuum settings

2019-05-06 Thread Oleksii Kliukin
Robert Haas wrote: > On Thu, Apr 25, 2019 at 12:36 PM Oleksii Kliukin wrote: >> - Fallbacks to autovacuum parameters in another scope. Right now in the >> absence of the per-table and per-tablespace autovacuum parameters the code >> uses the ones from the global scope. However, if only some of t

Re: Per-tablespace autovacuum settings

2019-02-14 Thread Andres Freund
Hi, On 2019-02-14 17:56:17 +0100, Oleksii Kliukin wrote: > Is there any interest in making autovacuum parameters available on a > tablespace level in order to apply those to all vacuumable objects in the > tablespace? > > We have a set of tables running on ZFS, where autovacuum does almost no goo

Re: Per-tablespace autovacuum settings

2019-02-14 Thread Tom Lane
Oleksii Kliukin writes: > Is there any interest in making autovacuum parameters available on a > tablespace level in order to apply those to all vacuumable objects in the > tablespace? I understand what you want to accomplish, and it doesn't seem unreasonable. But I just want to point out that t

Re: Per-tablespace autovacuum settings

2019-02-14 Thread Oleksii Kliukin
Andres Freund wrote: > Hi, > > On 2019-02-14 17:56:17 +0100, Oleksii Kliukin wrote: >> Is there any interest in making autovacuum parameters available on a >> tablespace level in order to apply those to all vacuumable objects in the >> tablespace? >> >> We have a set of tables running on ZFS, w

Re: Per-tablespace autovacuum settings

2019-02-14 Thread Oleksii Kliukin
Tom Lane wrote: > Oleksii Kliukin writes: >> Is there any interest in making autovacuum parameters available on a >> tablespace level in order to apply those to all vacuumable objects in the >> tablespace? > > I understand what you want to accomplish, and it doesn't seem > unreasonable. But I

Re: Per-tablespace autovacuum settings

2019-04-25 Thread Oleksii Kliukin
Hello, Oleksii Kliukin wrote: > Tom Lane wrote: > > >> I don't know how to make this better, but I wish we'd take a step >> back and think about it rather than just accreting more and more >> complexity. > > I am willing to do the refactoring when necessary, any particular place in > the cod

Re: Per-tablespace autovacuum settings

2019-05-03 Thread Robert Haas
On Thu, Apr 25, 2019 at 12:36 PM Oleksii Kliukin wrote: > - Fallbacks to autovacuum parameters in another scope. Right now in the > absence of the per-table and per-tablespace autovacuum parameters the code > uses the ones from the global scope. However, if only some of the reloptions > are set on

Re: Per-tablespace autovacuum settings

2019-05-06 Thread Oleksii Kliukin
Robert Haas wrote: > On Thu, Apr 25, 2019 at 12:36 PM Oleksii Kliukin wrote: >> - Fallbacks to autovacuum parameters in another scope. Right now in the >> absence of the per-table and per-tablespace autovacuum parameters the code >> uses the ones from the global scope. However, if only some of t