Re: PgStat_KindInfo.named_on_disk not required in shared stats

2024-06-30 Thread Michael Paquier
On Sat, Jun 08, 2024 at 07:31:21AM +0900, Michael Paquier wrote: > Thanks for looking, Andres! I guess I'll just apply that once v18 > opens up. Applied as of b19db55bd687. -- Michael signature.asc Description: PGP signature

Re: PgStat_KindInfo.named_on_disk not required in shared stats

2024-06-07 Thread Michael Paquier
On Fri, Jun 07, 2024 at 08:30:06AM -0700, Andres Freund wrote: > Yes, makes sense. Looks we changed direction during development a bunch of > times...q Thanks for looking, Andres! I guess I'll just apply that once v18 opens up. -- Michael signature.asc Description: PGP signature

Re: PgStat_KindInfo.named_on_disk not required in shared stats

2024-06-07 Thread Andres Freund
Hi, On 2024-06-07 14:07:33 +0900, Michael Paquier wrote: > While hacking on the area of pgstat_*.c, I have noticed the existence > of named_on_disk in PgStat_KindInfo, that is here to track the fact > that replication slots are a particular case in the PgStat_HashKey for > the dshash table of the

PgStat_KindInfo.named_on_disk not required in shared stats

2024-06-06 Thread Michael Paquier
Hi all, (Relevant folks in CC.) While hacking on the area of pgstat_*.c, I have noticed the existence of named_on_disk in PgStat_KindInfo, that is here to track the fact that replication slots are a particular case in the PgStat_HashKey for the dshash table of the stats because this kind of stats