Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-12 Thread Ranier Vilela
Posgres13_beta1, is consistently writing to the logs, "could not rename temporary statistics file". When analyzing the source that writes the log, I simplified the part that writes the logs a little. 1. I changed from if else if to if 2. For the user, better to have more errors recorded, which can

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-12 Thread Ranier Vilela
Em sex., 12 de jun. de 2020 às 15:15, Ranier Vilela escreveu: > Posgres13_beta1, is consistently writing to the logs, "could not rename > temporary statistics file". > When analyzing the source that writes the log, I simplified the part that > writes the logs a little. > > 1. I changed from if el

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-14 Thread Ranier Vilela
posix rename, "renames a file, moving it between directories if required". pgrename, win32 port uses MoveFileEx, to support rename files at Windows side, but, actually don't allow "renames a file, moving it between directories if required". To match the same characteristics as posix rename, we n

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-14 Thread Michael Paquier
On Fri, Jun 12, 2020 at 03:15:52PM -0300, Ranier Vilela wrote: > Posgres13_beta1, is consistently writing to the logs, "could not rename > temporary statistics file". > When analyzing the source that writes the log, I simplified the part that > writes the logs a little. FWIW, I have been running a

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-14 Thread Justin Pryzby
On Fri, Jun 12, 2020 at 03:15:52PM -0300, Ranier Vilela wrote: > Posgres13_beta1, is consistently writing to the logs, "could not rename > temporary statistics file". > When analyzing the source that writes the log, I simplified the part that > writes the logs a little. What windows version and co

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-15 Thread Ranier Vilela
Em dom., 14 de jun. de 2020 às 23:08, Michael Paquier escreveu: > On Fri, Jun 12, 2020 at 03:15:52PM -0300, Ranier Vilela wrote: > > Posgres13_beta1, is consistently writing to the logs, "could not rename > > temporary statistics file". > > When analyzing the source that writes the log, I simplif

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-15 Thread Ranier Vilela
Em dom., 14 de jun. de 2020 às 23:53, Justin Pryzby escreveu: > On Fri, Jun 12, 2020 at 03:15:52PM -0300, Ranier Vilela wrote: > > Posgres13_beta1, is consistently writing to the logs, "could not rename > > temporary statistics file". > > When analyzing the source that writes the log, I simplifie

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-15 Thread Ranier Vilela
Attached a log. I hacked dirmod.c (pgrename), to print GetLastError(); MoveFIleEx from: pg_stat_tmp/global.tmp MoveFIleEx to: pg_stat_tmp/global.stat MoveFIleEx win32 error code 5 regards, Ranier Vilela logfile Description: Binary data

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-15 Thread Ranier Vilela
I can confirm that the problem is in pgrename (dirmod.c), something is not OK, with MoveFileEx, even with the (MOVEFILE_REPLACE_EXISTING) flag. Replacing MoveFileEx, with unlink (to); rename (from, to); #if defined (WIN32) &&! defined (__ CYGWIN__) unlink(to); while (rename (from, to)! = 0) #else

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-15 Thread Michael Paquier
On Mon, Jun 15, 2020 at 09:49:31AM -0300, Ranier Vilela wrote: > II already reported on another thread, that vcregress is failing with > (float8 and partitionprune) and now these messages are showing up. > None buildfarm animal, have that combination, but as Postgres officially > supports it .. We

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-15 Thread Justin Pryzby
On Mon, Jun 15, 2020 at 11:49:33PM -0300, Ranier Vilela wrote: > I can confirm that the problem is in pgrename (dirmod.c), > something is not OK, with MoveFileEx, even with the > (MOVEFILE_REPLACE_EXISTING) flag. > > Replacing MoveFileEx, with > unlink (to); > rename (from, to); > > #if defined (

Re: Postgresql13_beta1 (could not rename temporary statistics file) Windows 64bits

2020-06-16 Thread Ranier Vilela
Em ter., 16 de jun. de 2020 às 01:10, Justin Pryzby escreveu: > On Mon, Jun 15, 2020 at 11:49:33PM -0300, Ranier Vilela wrote: > > I can confirm that the problem is in pgrename (dirmod.c), > > something is not OK, with MoveFileEx, even with the > > (MOVEFILE_REPLACE_EXISTING) flag. > > > > Replac